[{"id":23256,"web_url":"https://patchwork.libcamera.org/comment/23256/","msgid":"<20220531024632.GC2630765@pyrite.rasen.tech>","date":"2022-05-31T02:46:32","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix incorrect toString()\n\tto operator<<() conversions","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Tue, May 31, 2022 at 02:00:45AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Commit 8a845ab078c3 (\"libcamera: Replace toString with operator<<() for\n> format classes\") incorrectly converted some of the toString() usages,\n> resulting in pointer values being printed instead of formats. Fix it.\n> \n> Fixes: 8a845ab078c3 (\"libcamera: Replace toString with operator<<() for format classes\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/imgu.cpp | 4 ++--\n> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> 3 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index a4e4d302f841..08e254f75eee 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -211,7 +211,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tLOG(IPU3, Debug) << \"CIO2 output format \" << outputFormat;\n> +\tLOG(IPU3, Debug) << \"CIO2 output format \" << *outputFormat;\n> \n> \treturn 0;\n> }\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 34613feb8130..59305f85073c 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -479,7 +479,7 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tLOG(IPU3, Debug) << \"ImgU input format = \" << inputFormat;\n> +\tLOG(IPU3, Debug) << \"ImgU input format = \" << *inputFormat;\n> \n> \t/*\n> \t * \\todo The IPU3 driver implementation shall be changed to use the\n> @@ -568,7 +568,7 @@ int ImgUDevice::configureVideoDevice(V4L2VideoDevice *dev, unsigned int pad,\n> \n> \tconst char *name = dev == output_.get() ? \"output\" : \"viewfinder\";\n> \tLOG(IPU3, Debug) << \"ImgU \" << name << \" format = \"\n> -\t\t\t << outputFormat;\n> +\t\t\t << *outputFormat;\n> \n> \treturn 0;\n> }\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 76bd228b5aba..de75465eb3b5 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -610,7 +610,7 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> \t\t\t\t\t<< \" produces \" << sourceFormat\n> \t\t\t\t\t<< \", sink '\" << sink->entity()->name()\n> \t\t\t\t\t<< \"':\" << sink->index()\n> -\t\t\t\t\t<< \" requires \" << format;\n> +\t\t\t\t\t<< \" requires \" << *format;\n> \t\t\t\treturn -EINVAL;\n> \t\t\t}\n> \t\t}\n> @@ -620,7 +620,7 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> \t\t\t<< \"':\" << source->index()\n> \t\t\t<< \" -> '\" << sink->entity()->name()\n> \t\t\t<< \"':\" << sink->index()\n> -\t\t\t<< \" configured with format \" << format;\n> +\t\t\t<< \" configured with format \" << *format;\n> \t}\n> \n> \treturn 0;\n> \n> base-commit: e115a691353151b3136581ac7f49cab6a3b0eb9a","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FE04BD160\n\tfor ;\n\tTue, 31 May 2022 02:46:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78C2765633;\n\tTue, 31 May 2022 04:46:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C3366040A\n\tfor ;\n\tTue, 31 May 2022 04:46:42 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D9406F0;\n\tTue, 31 May 2022 04:46:40 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653965204;\n\tbh=jD8kypwURC2cYqVyH3J0JgerM41mQenoExrsMhKYRaY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FHbt94+hIvjPcUFNrRwLfw82EjRyK/YZ8Iynajq4wUHEnOCaIDrrp7LZH9seSFPNR\n\tWpV8MFwGP67WGLp7VoRMb6Rx+ueHDz1VKqmNEHk6sLCxccm56IPMzdUkW5Jo0FTYH3\n\tK2d6havAPxtP/3WxBmMQw5gvhkzvDr40g6y2hiwgZEntdPr3myKJcX6gEair+s088W\n\tQktArQc27HIMoHlcm4m9cgXjsdw3qte3dWo5w0LFgu6pM3afPZnis9a1Mb+mE7rbQ+\n\t5khxc6aMgDC9jWLL8+RfHnAdDTz7gVuYUoFfUfJmFfwwNGttOOKkoE4HocaJS7r8nT\n\trCtGplxnQIdfQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653965201;\n\tbh=jD8kypwURC2cYqVyH3J0JgerM41mQenoExrsMhKYRaY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GFJKjAh80Z0CXDx2tUEe+TScaUUGbnuUov9iVh+6BD3hUhU2eFuhMN98g4nPmchVN\n\tINJQa15DlAR3wv7gn2iKsX3rbjqDyAc0yWF+r+8V41eWnqQG+lyy9PJnQlelJfwB34\n\tDTuHAseD0UObgbRvIZrcbJ6F5KZN+p80rE5jLTaA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GFJKjAh8\"; dkim-atps=neutral","Date":"Tue, 31 May 2022 11:46:32 +0900","To":"Laurent Pinchart ","Message-ID":"<20220531024632.GC2630765@pyrite.rasen.tech>","References":"<20220530230045.5865-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220530230045.5865-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix incorrect toString()\n\tto operator<<() conversions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23267,"web_url":"https://patchwork.libcamera.org/comment/23267/","msgid":"<165398321051.2542469.13301667575787546236@Monstersaurus>","date":"2022-05-31T07:46:50","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix incorrect toString()\n\tto operator<<() conversions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-05-31 00:00:45)\n> Commit 8a845ab078c3 (\"libcamera: Replace toString with operator<<() for\n> format classes\") incorrectly converted some of the toString() usages,\n> resulting in pointer values being printed instead of formats. Fix it.\n> \n> Fixes: 8a845ab078c3 (\"libcamera: Replace toString with operator<<() for format classes\")\n> Signed-off-by: Laurent Pinchart \n\nOoops\n\nThese look reasonable, but I haven't checked if there are more.\n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/imgu.cpp | 4 ++--\n> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> 3 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index a4e4d302f841..08e254f75eee 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -211,7 +211,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)\n> if (ret)\n> return ret;\n> \n> - LOG(IPU3, Debug) << \"CIO2 output format \" << outputFormat;\n> + LOG(IPU3, Debug) << \"CIO2 output format \" << *outputFormat;\n> \n> return 0;\n> }\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 34613feb8130..59305f85073c 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -479,7 +479,7 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n> if (ret)\n> return ret;\n> \n> - LOG(IPU3, Debug) << \"ImgU input format = \" << inputFormat;\n> + LOG(IPU3, Debug) << \"ImgU input format = \" << *inputFormat;\n> \n> /*\n> * \\todo The IPU3 driver implementation shall be changed to use the\n> @@ -568,7 +568,7 @@ int ImgUDevice::configureVideoDevice(V4L2VideoDevice *dev, unsigned int pad,\n> \n> const char *name = dev == output_.get() ? \"output\" : \"viewfinder\";\n> LOG(IPU3, Debug) << \"ImgU \" << name << \" format = \"\n> - << outputFormat;\n> + << *outputFormat;\n> \n> return 0;\n> }\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 76bd228b5aba..de75465eb3b5 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -610,7 +610,7 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> << \" produces \" << sourceFormat\n> << \", sink '\" << sink->entity()->name()\n> << \"':\" << sink->index()\n> - << \" requires \" << format;\n> + << \" requires \" << *format;\n> return -EINVAL;\n> }\n> }\n> @@ -620,7 +620,7 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> << \"':\" << source->index()\n> << \" -> '\" << sink->entity()->name()\n> << \"':\" << sink->index()\n> - << \" configured with format \" << format;\n> + << \" configured with format \" << *format;\n> }\n> \n> return 0;\n> \n> base-commit: e115a691353151b3136581ac7f49cab6a3b0eb9a\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00DEFBD161\n\tfor ;\n\tTue, 31 May 2022 07:46:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 397A465633;\n\tTue, 31 May 2022 09:46:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9ADAA6040A\n\tfor ;\n\tTue, 31 May 2022 09:46:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 259676F0;\n\tTue, 31 May 2022 09:46:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653983215;\n\tbh=IWb7jBOVESxA5gyOtrPx5fOVPDxD24Lf0HGGZWSbIPg=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=bZ6euP6pddRa9xERuapw8KPljdaFql2fiaFOptrxprwQi37yHvqDlpcIdsgKdPfZb\n\t+NNv6hyb5HbhyAWKnAZQA47EO5k/ZnJvNAoOAQuDOm4n5/zVnq26X5SV9weJ+F307S\n\trl0+rvkZUEg40IFfXHAhlXijYFW/1dxShmo3njEwKJPFBrxxYAtli9RkHyR/L4M7y3\n\tiotNJGsVncq4Lojstj8OfG1c9dQ6uNbTMwHftuRJSRk6nQEdGuYbCL/WhKlE0s++o2\n\t2pXjmlOpf9X12hiKTuisA3bgpA4oAL4j7ChxGG8NMoaPNETPsw1aVQyUobVTgYoG8h\n\tSf2GFSSrq89Dg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653983213;\n\tbh=IWb7jBOVESxA5gyOtrPx5fOVPDxD24Lf0HGGZWSbIPg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=SkHQhzlBQe/W4Yj3+C4oG1w7ldWo2KuTqUVtoek8LKXDNo6V37B0J+Ssieff7a/Gi\n\txKpox5JL81qF3hBJKAxlu25vInBgKCZtuF5y3hWVtacThSBLBiGWIsa4Hrv+XdJPMz\n\trIPbig35vbZMcrkq7D+M/Lo4e6vnF7Qi1g5Ri094="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SkHQhzlB\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220530230045.5865-1-laurent.pinchart@ideasonboard.com>","References":"<20220530230045.5865-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 31 May 2022 08:46:50 +0100","Message-ID":"<165398321051.2542469.13301667575787546236@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix incorrect toString()\n\tto operator<<() conversions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23274,"web_url":"https://patchwork.libcamera.org/comment/23274/","msgid":"","date":"2022-06-01T08:06:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix incorrect toString()\n\tto operator<<() conversions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, May 31, 2022 at 08:46:50AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-05-31 00:00:45)\n> > Commit 8a845ab078c3 (\"libcamera: Replace toString with operator<<() for\n> > format classes\") incorrectly converted some of the toString() usages,\n> > resulting in pointer values being printed instead of formats. Fix it.\n> > \n> > Fixes: 8a845ab078c3 (\"libcamera: Replace toString with operator<<() for format classes\")\n> > Signed-off-by: Laurent Pinchart \n> \n> Ooops\n> \n> These look reasonable, but I haven't checked if there are more.\n\nNot to my knowledge :-)\n\nThis is one of the drawbacks of the conversion to operator<<() I\nsuppose, these issues are not caught by the compiler.\n\n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n> > src/libcamera/pipeline/ipu3/imgu.cpp | 4 ++--\n> > src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> > 3 files changed, 5 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> > index a4e4d302f841..08e254f75eee 100644\n> > --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> > @@ -211,7 +211,7 @@ int CIO2Device::configure(const Size &size, V4L2DeviceFormat *outputFormat)\n> > if (ret)\n> > return ret;\n> > \n> > - LOG(IPU3, Debug) << \"CIO2 output format \" << outputFormat;\n> > + LOG(IPU3, Debug) << \"CIO2 output format \" << *outputFormat;\n> > \n> > return 0;\n> > }\n> > diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> > index 34613feb8130..59305f85073c 100644\n> > --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> > @@ -479,7 +479,7 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n> > if (ret)\n> > return ret;\n> > \n> > - LOG(IPU3, Debug) << \"ImgU input format = \" << inputFormat;\n> > + LOG(IPU3, Debug) << \"ImgU input format = \" << *inputFormat;\n> > \n> > /*\n> > * \\todo The IPU3 driver implementation shall be changed to use the\n> > @@ -568,7 +568,7 @@ int ImgUDevice::configureVideoDevice(V4L2VideoDevice *dev, unsigned int pad,\n> > \n> > const char *name = dev == output_.get() ? \"output\" : \"viewfinder\";\n> > LOG(IPU3, Debug) << \"ImgU \" << name << \" format = \"\n> > - << outputFormat;\n> > + << *outputFormat;\n> > \n> > return 0;\n> > }\n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 76bd228b5aba..de75465eb3b5 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -610,7 +610,7 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> > << \" produces \" << sourceFormat\n> > << \", sink '\" << sink->entity()->name()\n> > << \"':\" << sink->index()\n> > - << \" requires \" << format;\n> > + << \" requires \" << *format;\n> > return -EINVAL;\n> > }\n> > }\n> > @@ -620,7 +620,7 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> > << \"':\" << source->index()\n> > << \" -> '\" << sink->entity()->name()\n> > << \"':\" << sink->index()\n> > - << \" configured with format \" << format;\n> > + << \" configured with format \" << *format;\n> > }\n> > \n> > return 0;\n> > \n> > base-commit: e115a691353151b3136581ac7f49cab6a3b0eb9a","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BABFBD160\n\tfor ;\n\tWed, 1 Jun 2022 08:06:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6C6D633A7;\n\tWed, 1 Jun 2022 10:06:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C58D060414\n\tfor ;\n\tWed, 1 Jun 2022 10:06:32 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(lmontsouris-659-1-41-236.w92-154.abo.wanadoo.fr [92.154.76.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B52230A;\n\tWed, 1 Jun 2022 10:06:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654070793;\n\tbh=MoA1TFNKlt4pdoYuXgpDLV+5K2ln0qh0FB90ze4A4nw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=h7Aka65HddA2HgGoVuSxGYz5aAUjARS792Jd4iKVIXnRv7TFlwfXR9u3YP5Z7om41\n\tAhuV0KHVNelIeo5CPXiiEoYEWSr6ylSgjnx40JvAHTNFFZHaCn+PMIkVhZv8tzDjET\n\tJu0s+iEdbWZK23jhLprkOGEz9oHF9H9tSlIi7PYmAizMH8EdeU/gaIhkGq3GL72Aeu\n\tGt0bxXdtl0fXkXLpr/eVYON1p3W9r/Ocmg9HeyXF3CO+XF0Tc4AqOWYoHvBTF+hNck\n\toeKaGRQuNAh19izo05AQDFS0Cln5wL+27N3ht1V70QEyaJbROnPzPg0BIjQZax9svs\n\tusA/QqwgeO29Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654070792;\n\tbh=MoA1TFNKlt4pdoYuXgpDLV+5K2ln0qh0FB90ze4A4nw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OqAyL/r3g6qDnkW67V04TFZRAWs8zIbhUpsF9LuRiWa1U+x34EvfOmQDk2uL/vtay\n\teBBbW1rzJ91smoG5bK5byiDbLna8f3RWNPIaIYADJUOijLUgsMUKP1kLcEMZG1kf2v\n\tWTwNfR7eKjsJe55wriK4dVdxq884+Oasu6eWfgAY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OqAyL/r3\"; dkim-atps=neutral","Date":"Wed, 1 Jun 2022 11:06:27 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220530230045.5865-1-laurent.pinchart@ideasonboard.com>\n\t<165398321051.2542469.13301667575787546236@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165398321051.2542469.13301667575787546236@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix incorrect toString()\n\tto operator<<() conversions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]