{"id":16113,"url":"https://patchwork.libcamera.org/api/patches/16113/?format=json","web_url":"https://patchwork.libcamera.org/patch/16113/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220530142722.57618-7-tomi.valkeinen@ideasonboard.com>","date":"2022-05-30T14:27:12","name":"[libcamera-devel,v4,06/16] py: Add FrameMetadataPlane","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0b908cf41360e0a0def9b615f9fb13b99770963d","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16113/mbox/","series":[{"id":3149,"url":"https://patchwork.libcamera.org/api/series/3149/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3149","date":"2022-05-30T14:27:06","name":"More misc Python patches","version":4,"mbox":"https://patchwork.libcamera.org/series/3149/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16113/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16113/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 347E0C3271\n\tfor ;\n\tMon, 30 May 2022 14:27:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67DEF65647;\n\tMon, 30 May 2022 16:27:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4640465634\n\tfor ;\n\tMon, 30 May 2022 16:27:42 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B534C11C1;\n\tMon, 30 May 2022 16:27:41 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653920869;\n\tbh=e+fvoGpCQfNdN138CUPcW/BL1DzCs9VA5alM5oMPYTs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=vFwCcTQjmiltU398NL3TCAeMANlhYtSFiQDaY0cQjOhzSe+VIp9oQhhXK03JkIXFa\n\tqD80TZJ95y9dEdmYX5ZQ1rbEjxILncv/4za8bfnE99C3larmeadDH97RjPdYba3YLn\n\tPrBGCgdP3cd1e354mMAC0PAYE5Aydu3MfCzv3ZzaMGtspfE3Gwk2y+6aKx/XrqSXK/\n\tho4VtkXmhoS0yxdQjFmBav1PndhnDyqHQJFGmRHfRzgbP65598G7VmHvwXLQaQqHhu\n\tL9Dw5gjpIGFHzCkoqJ0zC64T6E2onEQ3BT2Ci/trpJQ7UyB9SU0WokIK3Dx/8Ng24r\n\tHd4QOTt2VoCNQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653920862;\n\tbh=e+fvoGpCQfNdN138CUPcW/BL1DzCs9VA5alM5oMPYTs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NlbhS5OT7FvlbvvuZH6Gvk+7Yhgd9MNsZwpEjCpYTeWB+zplMMuhiHxzOAIXhOKYg\n\tkSDcATp0Ux6lYptspTp4sQNp/3oejVPDpAyw+uHBmRcbMMOF/lAVFAAjQXfz0weW6U\n\t5se5y6wjHftnbrxDztMXdpDcswFzogkkmFzBpxEI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NlbhS5OT\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Mon, 30 May 2022 17:27:12 +0300","Message-Id":"<20220530142722.57618-7-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220530142722.57618-1-tomi.valkeinen@ideasonboard.com>","References":"<20220530142722.57618-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 06/16] py: Add FrameMetadataPlane","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add FrameMetadataPlane class and adjust the methods and uses\naccordingly.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n src/py/cam/cam.py | 3 ++-\n src/py/libcamera/py_main.cpp | 13 ++++++++-----\n 2 files changed, 10 insertions(+), 6 deletions(-)","diff":"diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex 677dd680..bf8529d9 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -285,7 +285,8 @@ class CaptureState:\n print('{:.6f} ({:.2f} fps) {}-{}: seq {}, bytes {}, CRCs {}'\n .format(ts / 1000000000, fps,\n ctx.id, stream_name,\n- meta.sequence, meta.bytesused,\n+ meta.sequence,\n+ '/'.join([str(p.bytes_used) for p in meta.planes]),\n crcs))\n \n if ctx.opt_metadata:\ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 9e827845..52f70811 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -163,6 +163,7 @@ PYBIND11_MODULE(_libcamera, m)\n \tauto pyRequestReuse = py::enum_(pyRequest, \"Reuse\");\n \tauto pyFrameMetadata = py::class_(m, \"FrameMetadata\");\n \tauto pyFrameMetadataStatus = py::enum_(pyFrameMetadata, \"Status\");\n+\tauto pyFrameMetadataPlane = py::class_(pyFrameMetadata, \"Plane\");\n \tauto pyTransform = py::class_(m, \"Transform\");\n \tauto pyColorSpace = py::class_(m, \"ColorSpace\");\n \tauto pyColorSpacePrimaries = py::enum_(pyColorSpace, \"Primaries\");\n@@ -512,11 +513,10 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t.def_readonly(\"status\", &FrameMetadata::status)\n \t\t.def_readonly(\"sequence\", &FrameMetadata::sequence)\n \t\t.def_readonly(\"timestamp\", &FrameMetadata::timestamp)\n-\t\t/* \\todo Implement FrameMetadata::Plane properly */\n-\t\t.def_property_readonly(\"bytesused\", [](FrameMetadata &self) {\n-\t\t\tstd::vector v;\n-\t\t\tv.resize(self.planes().size());\n-\t\t\ttransform(self.planes().begin(), self.planes().end(), v.begin(), [](const auto &p) { return p.bytesused; });\n+\t\t.def_property_readonly(\"planes\", [](const FrameMetadata &self) {\n+\t\t\t/* Convert from Span<> to std::vector<> */\n+\t\t\t/* Note: this creates a copy */\n+\t\t\tstd::vector v(self.planes().begin(), self.planes().end());\n \t\t\treturn v;\n \t\t});\n \n@@ -525,6 +525,9 @@ PYBIND11_MODULE(_libcamera, m)\n \t\t.value(\"Error\", FrameMetadata::FrameError)\n \t\t.value(\"Cancelled\", FrameMetadata::FrameCancelled);\n \n+\tpyFrameMetadataPlane\n+\t\t.def_readwrite(\"bytes_used\", &FrameMetadata::Plane::bytesused);\n+\n \tpyTransform\n \t\t.def(py::init([](int rotation, bool hflip, bool vflip, bool transpose) {\n \t\t\tbool ok;\n","prefixes":["libcamera-devel","v4","06/16"]}