[{"id":226,"web_url":"https://patchwork.libcamera.org/comment/226/","msgid":"<7299804.v1B7hq9Wet@avalon>","date":"2019-01-07T16:27:58","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_object: Undef\n\tmajor/minor system macros","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Monday, 7 January 2019 17:54:27 EET Kieran Bingham wrote:\n> GCC 7.3.0 defines conflicting macros within which are\n> deprecated and removed in later versions.\n> \n> To support compilation with this toolchain, ensure that any previous\n> definition is removed before the class definitions.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/include/media_object.h | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/include/media_object.h\n> b/src/libcamera/include/media_object.h index 950a33286690..00772fd11234\n> 100644\n> --- a/src/libcamera/include/media_object.h\n> +++ b/src/libcamera/include/media_object.h\n> @@ -12,6 +12,15 @@\n> \n> #include \n> \n> +/*\n> + * In the GNU C Library, \"major\" and \"minor\" are defined by\n> . + * GCC 7.3.0 also defines this in for\n> historical compatibility. + * To prevent conflicting with the major() and\n> minor() member functions we + * unconditionally undef these here.\n> + */\n> +#undef major\n> +#undef minor\n\nI don't think we should do this, as it would prevent users of media_object.h \nfrom using the glibc macros (or at least interfere with their usage, \npotentially creating more problems). Let's instead rename the two conflicting \nfunctions, to deviceMinor() and deviceMajor() (or other similar names).\n\n> namespace libcamera {\n> \n> class MediaDevice;","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47873600CC\n\tfor ;\n\tMon, 7 Jan 2019 17:26:52 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70CA3E22;\n\tMon, 7 Jan 2019 17:26:51 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546878411;\n\tbh=yoHyLkL9KpGvIAmm8Sibx/7/AIlz6qyB2z1WQLzsusc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=kSb1S3Rhbepqrh9ItSOxPMCUeHxbbeMYXQC175wL8So8R2HTSiH+FyycnhzckcbUc\n\tEbbUMORUnE53hNJXYR1t/Lm3L2R9yn1b1RdBZ/1mStDXvQOX5v8y+Xgcv3qOTO1caL\n\tvtjaZn/W/EhNE5GEMEy/4aToiSyE+LUyy1NRiTbc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 07 Jan 2019 18:27:58 +0200","Message-ID":"<7299804.v1B7hq9Wet@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20190107155427.10124-1-kieran.bingham@ideasonboard.com>","References":"<20190107155427.10124-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_object: Undef\n\tmajor/minor system macros","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 07 Jan 2019 16:26:52 -0000"}},{"id":228,"web_url":"https://patchwork.libcamera.org/comment/228/","msgid":"<088f8281-d1fb-8f85-e7f8-d5449c944d6b@ideasonboard.com>","date":"2019-01-07T17:10:54","subject":"Re: [libcamera-devel] [PATCH] libcamera: media_object: Undef\n\tmajor/minor system macros","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 07/01/2019 16:27, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Monday, 7 January 2019 17:54:27 EET Kieran Bingham wrote:\n>> GCC 7.3.0 defines conflicting macros within which are\n>> deprecated and removed in later versions.\n>>\n>> To support compilation with this toolchain, ensure that any previous\n>> definition is removed before the class definitions.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/include/media_object.h | 9 +++++++++\n>> 1 file changed, 9 insertions(+)\n>>\n>> diff --git a/src/libcamera/include/media_object.h\n>> b/src/libcamera/include/media_object.h index 950a33286690..00772fd11234\n>> 100644\n>> --- a/src/libcamera/include/media_object.h\n>> +++ b/src/libcamera/include/media_object.h\n>> @@ -12,6 +12,15 @@\n>>\n>> #include \n>>\n>> +/*\n>> + * In the GNU C Library, \"major\" and \"minor\" are defined by\n>> . + * GCC 7.3.0 also defines this in for\n>> historical compatibility. + * To prevent conflicting with the major() and\n>> minor() member functions we + * unconditionally undef these here.\n>> + */\n>> +#undef major\n>> +#undef minor\n> \n> I don't think we should do this, as it would prevent users of media_object.h \n> from using the glibc macros (or at least interfere with their usage, \n> potentially creating more problems). Let's instead rename the two conflicting \n> functions, to deviceMinor() and deviceMajor() (or other similar names).\n\nI agree. I've sent an updated patch.\n\n\n\n> \n>> namespace libcamera {\n>>\n>> class MediaDevice;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E880600CC\n\tfor ;\n\tMon, 7 Jan 2019 18:10:58 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01AFFE22;\n\tMon, 7 Jan 2019 18:10:56 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546881057;\n\tbh=F8ut1gb8zYFOoKkNqfWuipPjtdi4NRayV0hgPXXKuF0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Jqx/eSNnlnU8egkKvuog7XFiNMhd9AEj262G2GuqZBokmCgyVs8jLrQeZAfJotxyI\n\thBVpi46hixRHyxO+uMvYCXHBE8JjCbhXFzF4EgZLOlvREcM9b4STyp8XBozCR96pt4\n\t8nrRAifYstUdtYu87LfqZYrCmtgTKqawU0nTYW08=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190107155427.10124-1-kieran.bingham@ideasonboard.com>\n\t<7299804.v1B7hq9Wet@avalon>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<088f8281-d1fb-8f85-e7f8-d5449c944d6b@ideasonboard.com>","Date":"Mon, 7 Jan 2019 17:10:54 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<7299804.v1B7hq9Wet@avalon>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: media_object: Undef\n\tmajor/minor system macros","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 07 Jan 2019 17:10:58 -0000"}}]