[{"id":23233,"web_url":"https://patchwork.libcamera.org/comment/23233/","msgid":"<YpSNBXhZz3paOshw@pendragon.ideasonboard.com>","date":"2022-05-30T09:23:17","subject":"Re: [libcamera-devel] [PATCH v3 25/30] py: MappedFrameBuffer: Add\n\t'fb' property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Fri, May 27, 2022 at 05:44:42PM +0300, Tomi Valkeinen wrote:\n> Add 'fb' property to expose the underlying FrameBuffer.\n> \n> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/py/libcamera/utils/MappedFrameBuffer.py | 4 ++++\n>  1 file changed, 4 insertions(+)\n> \n> diff --git a/src/py/libcamera/utils/MappedFrameBuffer.py b/src/py/libcamera/utils/MappedFrameBuffer.py\n> index 4b20f904..c25371c2 100644\n> --- a/src/py/libcamera/utils/MappedFrameBuffer.py\n> +++ b/src/py/libcamera/utils/MappedFrameBuffer.py\n> @@ -99,3 +99,7 @@ class MappedFrameBuffer:\n>              raise RuntimeError('MappedFrameBuffer not mmapped')\n>  \n>          return self.__planes\n> +\n> +    @property\n> +    def fb(self):\n> +        return self.__fb","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD39BBD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 May 2022 09:23:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93FB065633;\n\tMon, 30 May 2022 11:23:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67CEE6040B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 May 2022 11:23:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(lmontsouris-659-1-41-236.w92-154.abo.wanadoo.fr [92.154.76.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13C876BD;\n\tMon, 30 May 2022 11:23:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653902601;\n\tbh=m7k5kqJnb6Ymm5DqJrWfd3fsaAa7GFfQhrfJ/bfpxkg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=f29TrAnINcTtTzKLVWsh330aoBTAkFZse1ArPWQRV70jPCxQwFvgNazfQykP+8bzd\n\tBQ25jeh26k7KLemKqyUFGa8iQ3PppP/YwWRwZsWqCa8EZ/araJaod8744Jv95PeWW7\n\toQgrVCrEb/HDx+9tmfdiAphW4gjS+/nO5UWbsBoluQ4GInbbDTXHl8C6PlGgLWESZb\n\tZUAjf1Qmr/aB+HfQZCOgQ95JUVsFw4W3QcZOy5qHkIF/D1fdD1QWeK6FOjtPt7xjR7\n\t2Wms5KykmOrWT4BC22BACLXXT3O1aukHK2DD2GgSCmzS6/3rvfvuTCb+fBTAR91rqq\n\tB6UoRe5YtZJ5g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653902600;\n\tbh=m7k5kqJnb6Ymm5DqJrWfd3fsaAa7GFfQhrfJ/bfpxkg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vSXjzjoutElDY3k++HJu2GgCPjpbCDCR1DVPtu9g7ldXSjRWbPKqvYpX+3WfMQZeH\n\tJ12CPqBEY0wYXlsG2zGjSqh81keLNa4buq/ZMZQey3JzBb0Yb8RW/xyC9kBJ1BwUmg\n\tBgc0X2g1maAEWVjrQoPsb5SEyvGzCJtfsF2XcWXI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vSXjzjou\"; dkim-atps=neutral","Date":"Mon, 30 May 2022 12:23:17 +0300","To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Message-ID":"<YpSNBXhZz3paOshw@pendragon.ideasonboard.com>","References":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>\n\t<20220527144447.94891-26-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220527144447.94891-26-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 25/30] py: MappedFrameBuffer: Add\n\t'fb' property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]