[{"id":23220,"web_url":"https://patchwork.libcamera.org/comment/23220/","msgid":"","date":"2022-05-29T16:14:54","subject":"Re: [libcamera-devel] [PATCH v3 22/30] py: Add FrameMetadataPlane","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Fri, May 27, 2022 at 05:44:39PM +0300, Tomi Valkeinen wrote:\n> Add FrameMetadataPlane class and adjust the methods and uses\n> accordingly.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/cam/cam.py | 3 ++-\n> src/py/libcamera/py_main.cpp | 13 ++++++++-----\n> 2 files changed, 10 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\n> index 677dd680..bf8529d9 100755\n> --- a/src/py/cam/cam.py\n> +++ b/src/py/cam/cam.py\n> @@ -285,7 +285,8 @@ class CaptureState:\n> print('{:.6f} ({:.2f} fps) {}-{}: seq {}, bytes {}, CRCs {}'\n> .format(ts / 1000000000, fps,\n> ctx.id, stream_name,\n> - meta.sequence, meta.bytesused,\n> + meta.sequence,\n> + '/'.join([str(p.bytes_used) for p in meta.planes]),\n> crcs))\n> \n> if ctx.opt_metadata:\n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index 9e827845..52f70811 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -163,6 +163,7 @@ PYBIND11_MODULE(_libcamera, m)\n> \tauto pyRequestReuse = py::enum_(pyRequest, \"Reuse\");\n> \tauto pyFrameMetadata = py::class_(m, \"FrameMetadata\");\n> \tauto pyFrameMetadataStatus = py::enum_(pyFrameMetadata, \"Status\");\n> +\tauto pyFrameMetadataPlane = py::class_(pyFrameMetadata, \"Plane\");\n> \tauto pyTransform = py::class_(m, \"Transform\");\n> \tauto pyColorSpace = py::class_(m, \"ColorSpace\");\n> \tauto pyColorSpacePrimaries = py::enum_(pyColorSpace, \"Primaries\");\n> @@ -512,11 +513,10 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t.def_readonly(\"status\", &FrameMetadata::status)\n> \t\t.def_readonly(\"sequence\", &FrameMetadata::sequence)\n> \t\t.def_readonly(\"timestamp\", &FrameMetadata::timestamp)\n> -\t\t/* \\todo Implement FrameMetadata::Plane properly */\n> -\t\t.def_property_readonly(\"bytesused\", [](FrameMetadata &self) {\n> -\t\t\tstd::vector v;\n> -\t\t\tv.resize(self.planes().size());\n> -\t\t\ttransform(self.planes().begin(), self.planes().end(), v.begin(), [](const auto &p) { return p.bytesused; });\n> +\t\t.def_property_readonly(\"planes\", [](const FrameMetadata &self) {\n> +\t\t\t/* Convert from Span<> to std::vector<> */\n> +\t\t\t/* Note: this creates a copy */\n> +\t\t\tstd::vector v(self.planes().begin(), self.planes().end());\n> \t\t\treturn v;\n> \t\t});\n> \n> @@ -525,6 +525,9 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t.value(\"Error\", FrameMetadata::FrameError)\n> \t\t.value(\"Cancelled\", FrameMetadata::FrameCancelled);\n> \n> +\tpyFrameMetadataPlane\n> +\t\t.def_readwrite(\"bytes_used\", &FrameMetadata::Plane::bytesused);\n> +\n> \tpyTransform\n> \t\t.def(py::init([](int rotation, bool hflip, bool vflip, bool transpose) {\n> \t\t\tbool ok;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0404EBD160\n\tfor ;\n\tSun, 29 May 2022 16:15:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A22365633;\n\tSun, 29 May 2022 18:15:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D94F160415\n\tfor ;\n\tSun, 29 May 2022 18:14:58 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(static-5-51-54-220.ftth.abo.bbox.fr [5.51.54.220])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 429175A4;\n\tSun, 29 May 2022 18:14:58 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653840900;\n\tbh=aZZbzfBkcIHQoboViYodJONJn2r8CVBeQe/d9cHNgyA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Xyxaz0A4YADaFm5n2tG1UNPMwQrJacCEhGpFEvh7M9TYm2/YQJNm6tZNmbGBW7OQ9\n\tRz/rhvMLZ5xMnpH9kRxABd387DNDjadrJuYqOj+GMQKsQT00s5gajWNMR5HFKVi7iZ\n\tPnNyLUDGi8CLQHN5E7XITY3YNX+BM9u6Q+A7vRTvFXlUFOzhoV7WITZ2RL+1zrNiTm\n\tLfofDNBAv/t343wAzujT0j3uwMBtK1v+R5kACkVTQK4rS+Qgav2KLdbQVFmfkuYAqK\n\tXSjI55k1v3wUrxXQIjISgYh4pSsnX/XlnFYIfEcn/0fl49ZbPXiW0Ze+Wdn6QXXe1W\n\tVaPDH1AQ8S6ww==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653840898;\n\tbh=aZZbzfBkcIHQoboViYodJONJn2r8CVBeQe/d9cHNgyA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cojoA6m6r90T7WMUZ7bVxDHA9w4h8q0Wct2kb3n9i5lWI4gTtd/XYDb0TJ1Ov8zCZ\n\t8jdMt4bWqEnPLwuSi+8lEO/V/8I/OQgYuFy6m6ldBdmNnBGAVNJ9mcaWLsAMg4LW+/\n\tg5aUP/04prnNItCZrI6UVVGpKV7VapEMPC+/zo7w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cojoA6m6\"; dkim-atps=neutral","Date":"Sun, 29 May 2022 19:14:54 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>\n\t<20220527144447.94891-23-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220527144447.94891-23-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 22/30] py: Add FrameMetadataPlane","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]