[{"id":23219,"web_url":"https://patchwork.libcamera.org/comment/23219/","msgid":"","date":"2022-05-29T16:11:45","subject":"Re: [libcamera-devel] [PATCH v3 21/30] py: Add Request.__str__()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Fri, May 27, 2022 at 05:44:38PM +0300, Tomi Valkeinen wrote:\n> Add Request.__str__() which maps directly to Request::toString().\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/py_main.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index 3220a9e6..9e827845 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -496,7 +496,8 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t * \\todo As we add a keep_alive to the fb in addBuffers(), we\n> \t\t * can only allow reuse with ReuseBuffers.\n> \t\t */\n> -\t\t.def(\"reuse\", [](Request &self) { self.reuse(Request::ReuseFlag::ReuseBuffers); });\n> +\t\t.def(\"reuse\", [](Request &self) { self.reuse(Request::ReuseFlag::ReuseBuffers); })\n> +\t\t.def(\"__str__\", &Request::toString);\n> \n> \tpyRequestStatus\n> \t\t.value(\"Pending\", Request::RequestPending)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33211BD161\n\tfor ;\n\tSun, 29 May 2022 16:11:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B819633A0;\n\tSun, 29 May 2022 18:11:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A645E60415\n\tfor ;\n\tSun, 29 May 2022 18:11:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(static-5-51-54-220.ftth.abo.bbox.fr [5.51.54.220])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04BC65A4;\n\tSun, 29 May 2022 18:11:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653840711;\n\tbh=T88BlWrHkTVQikQeMvoPxImyth6esCt8gyrlt1bnrco=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=u8INlj/wIwXkQ+nZvWDOiYkG2qFdqyiEqpQwROKf5fmq1vuPHyb6qYIY1N3gGKYej\n\tdBdkODWa8QcCBqhhItv0QdVnLvYX80UvkEQ5Y2hY8Nv57Mmzugi3JSkC1OoFph0BDK\n\tBfN5MpbWjC4FEjjt84PVOeY04ik34Nj0IrTVO06vRIiu+sgt4w6s53FAgsbR6UW2xW\n\tX/V9IOyey/AEOI6X37j1PEypO2wvypgMtRIwmgD0Kr9g1P/EQUk3xfzxUz9ylUe4D/\n\tiGHYDv06p2PrREQkcrRTr5acSSCnq9bwBhjDEae4QZ/ECXWScYXhAAZj5T4Ulq+2Fo\n\ty8Z5jEN3DcAZw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653840709;\n\tbh=T88BlWrHkTVQikQeMvoPxImyth6esCt8gyrlt1bnrco=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OTOp3xWOMWGJPTAuByHIGTJfyNsUuEAT4ukufrG31s8R3il+S12z89XkgmAfMmifP\n\trEtzMCkvyWLtTqqPoCTW90axg9H6h6Jat04PyGRs8/yq1aeagIUXsY6BxbPCg+/6IC\n\t3h6Qn7a2pp0ZQS+/IKu6MmJ8ErdMhOr0K9vlrQRg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OTOp3xWO\"; dkim-atps=neutral","Date":"Sun, 29 May 2022 19:11:45 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>\n\t<20220527144447.94891-22-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220527144447.94891-22-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 21/30] py: Add Request.__str__()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]