{"id":16080,"url":"https://patchwork.libcamera.org/api/patches/16080/?format=json","web_url":"https://patchwork.libcamera.org/patch/16080/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220527144447.94891-10-tomi.valkeinen@ideasonboard.com>","date":"2022-05-27T14:44:26","name":"[libcamera-devel,v3,09/30] py: cam: Drop WA_ShowWithoutActivating","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3683a766a3a03a87f8027dae8ffe7ffe6f19aea6","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16080/mbox/","series":[{"id":3146,"url":"https://patchwork.libcamera.org/api/series/3146/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3146","date":"2022-05-27T14:44:17","name":"More misc Python patches","version":3,"mbox":"https://patchwork.libcamera.org/series/3146/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16080/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16080/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EB66C326E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 May 2022 14:45:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B13FD65655;\n\tFri, 27 May 2022 16:45:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 314AC6563D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 May 2022 16:45:09 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 940D811CD;\n\tFri, 27 May 2022 16:45:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662717;\n\tbh=mRI4K8BM6gjIEgTrzyaBiW5fZ9Mcb7eDb1PdyXPd77Y=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QGMSTlUO8wzWQ71c7ckJDk7AgZZMHIvUqMuW0iYRg7+8Uetnjkd10aOwqJ9zgZ668\n\t/fOF2iE8djwcBgs9bWuANPg4cFxrIA2dRMY0t9c7iUM2SNI4AlrnZ0plsm2clrztwQ\n\tRQGfjOfgKDvbwyN52BQPihcNOMGS/1TSdRAu94Wqct0QK+yr7I94J39Wq4HwziamSv\n\tLles7oNV7L/7WDY9orFXpcfAX8btJ1sYsHyStM7q+uEiQhEs/GN1gq6g3nfeDe11Tk\n\t5gi99GWNdblG12HOoif8xSAHuCswOAe1T4aaxC7byce76akP7Q3HnnC/C9tG9VLIHO\n\tzY7TrSeYSlrAg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662708;\n\tbh=mRI4K8BM6gjIEgTrzyaBiW5fZ9Mcb7eDb1PdyXPd77Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PitKxECeBu4NZ0reWrhzxZwAAs56ZYkvipR177CzZHCEnhhVjt98uiXtIP/OG5cfo\n\tfzxwFXQylmf7r82m8X5PwYc6rItXF9iXUCARoAgX55qTeiQmBYd+qD+1lzCF9l6CuR\n\tNCqu/KAU1Ab4xEp5FSgCjikkvS/qvcTSABggMDrU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PitKxECe\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>","Date":"Fri, 27 May 2022 17:44:26 +0300","Message-Id":"<20220527144447.94891-10-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>","References":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 09/30] py: cam: Drop\n\tWA_ShowWithoutActivating","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Drop WA_ShowWithoutActivating from the Qt renderers. I added the flag\nduring development phase as I didn't want the window to take the focus,\nbut it should be removed now.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/cam/cam_qt.py   | 1 -\n src/py/cam/cam_qtgl.py | 1 -\n 2 files changed, 2 deletions(-)","diff":"diff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py\nindex 70bdb7bb..03096920 100644\n--- a/src/py/cam/cam_qt.py\n+++ b/src/py/cam/cam_qt.py\n@@ -187,7 +187,6 @@ class QtRenderer:\n         for ctx in self.contexts:\n             for stream in ctx['streams']:\n                 window = MainWindow(ctx, stream)\n-                window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)\n                 window.show()\n                 windows.append(window)\n \ndiff --git a/src/py/cam/cam_qtgl.py b/src/py/cam/cam_qtgl.py\nindex 3fb7dde3..c9e367a2 100644\n--- a/src/py/cam/cam_qtgl.py\n+++ b/src/py/cam/cam_qtgl.py\n@@ -137,7 +137,6 @@ class QtRenderer:\n         self.app = QtWidgets.QApplication([])\n \n         window = MainWindow(self.state)\n-        window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)\n         window.show()\n \n         self.window = window\n","prefixes":["libcamera-devel","v3","09/30"]}