[{"id":23199,"web_url":"https://patchwork.libcamera.org/comment/23199/","msgid":"","date":"2022-05-27T18:14:15","subject":"Re: [libcamera-devel] [PATCH v3 06/30] py: Add\n\tCameraManager.read_event()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Fri, May 27, 2022 at 05:44:23PM +0300, Tomi Valkeinen wrote:\n> Add CameraManager.read_event() so that the user does not need to call\n> os.read().\n> \n> We use eventfd, and we must always read 8 bytes. Hiding that inside\n> read_event() makes sense.\n> \n> Signed-off-by: Tomi Valkeinen \n\nI would still like to make this nicer, but it can be done later.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/cam/cam.py | 3 +--\n> src/py/libcamera/py_main.cpp | 8 ++++++++\n> test/py/unittests.py | 3 +--\n> 3 files changed, 10 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\n> index e2bc78da..66df18bf 100755\n> --- a/src/py/cam/cam.py\n> +++ b/src/py/cam/cam.py\n> @@ -9,7 +9,6 @@\n> import argparse\n> import binascii\n> import libcamera as libcam\n> -import os\n> import sys\n> import traceback\n> \n> @@ -294,7 +293,7 @@ def event_handler(state):\n> cm = state['cm']\n> contexts = state['contexts']\n> \n> - os.read(cm.efd, 8)\n> + cm.read_event()\n> \n> reqs = cm.get_ready_requests()\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index e7066841..5d389942 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -212,6 +212,14 @@ PYBIND11_MODULE(_libcamera, m)\n> \t\t\treturn gEventfd;\n> \t\t})\n> \n> +\t\t.def(\"read_event\", [](CameraManager &) {\n> +\t\t\tuint8_t buf[8];\n> +\n> +\t\t\tint ret = read(gEventfd, buf, 8);\n> +\t\t\tif (ret != 8)\n> +\t\t\t\tthrow std::system_error(errno, std::generic_category());\n> +\t\t})\n> +\n> \t\t.def(\"get_ready_requests\", [](CameraManager &) {\n> \t\t\tstd::vector v;\n> \n> diff --git a/test/py/unittests.py b/test/py/unittests.py\n> index 7dede33b..8c445bc9 100755\n> --- a/test/py/unittests.py\n> +++ b/test/py/unittests.py\n> @@ -7,7 +7,6 @@ from collections import defaultdict\n> import errno\n> import gc\n> import libcamera as libcam\n> -import os\n> import selectors\n> import time\n> import typing\n> @@ -278,7 +277,7 @@ class SimpleCaptureMethods(CameraTesterBase):\n> while running:\n> events = sel.select()\n> for key, _ in events:\n> - os.read(key.fd, 8)\n> + cm.read_event()\n> \n> ready_reqs = cm.get_ready_requests()\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3DFCBD160\n\tfor ;\n\tFri, 27 May 2022 18:14:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFE0A633A5;\n\tFri, 27 May 2022 20:14:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 02ECF633A2\n\tfor ;\n\tFri, 27 May 2022 20:14:21 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [46.183.103.8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB41632A;\n\tFri, 27 May 2022 20:14:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653675263;\n\tbh=Cec4kQaZ0gzEhe8AlCMmzPv1dIKJDcLl1MMPCN3nU8Y=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TVKUEUehSC5nsws253KZbdpEKk/mMkCwrY0SlN3HVBCe2/ar0X1rlDW5PyXsLi9Qd\n\tzfO3dF4QdGkESI1USyPk+72y8hySrGTVg72P2KxHemCRdW38yRmWiUlSW7VJ3txyFJ\n\txswiCE7W9xjA2ayJPqiWvolal1vRBYL/1bkIdmvnPzmMCGbeKFYL9LaBnGOLgW4a+7\n\togwc+QqglcXuSobjJ0/b5+rpK/Gd99bF+Jb2CoblMyFDiipzdbC/ZZ9CfwoLn0jpbp\n\tJUZM9fDEHSiphmKwN+Wc4kmrEqUEo3wE6idezb7UuANqMt6ZhOEqNeIcrdzpcMS9Kj\n\tFnYoaDGiorEYQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653675261;\n\tbh=Cec4kQaZ0gzEhe8AlCMmzPv1dIKJDcLl1MMPCN3nU8Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ImpBE+lEvk0dBR9VdTm3xY7tL9cJpBXYrxem6ZQ68ZVByeMVMkPkuufoEbLTfLTUm\n\tgM3gxLX216ROvSWmPdolOH30tcXrtmBXJmps2quh4XaKuer9Ec0sDFWOaiQ5+KDANT\n\tH5CH0vAdqmKANqdmc3rrZwUW0qiPlUA/F2Dctqj4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ImpBE+lE\"; dkim-atps=neutral","Date":"Fri, 27 May 2022 21:14:15 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>\n\t<20220527144447.94891-7-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220527144447.94891-7-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 06/30] py: Add\n\tCameraManager.read_event()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]