{"id":16072,"url":"https://patchwork.libcamera.org/api/patches/16072/?format=json","web_url":"https://patchwork.libcamera.org/patch/16072/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220527144447.94891-2-tomi.valkeinen@ideasonboard.com>","date":"2022-05-27T14:44:18","name":"[libcamera-devel,v3,01/30] py: Generate pixel formats list","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ce861a5a876cb51ed0c9457007b209f621b46f01","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16072/mbox/","series":[{"id":3146,"url":"https://patchwork.libcamera.org/api/series/3146/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3146","date":"2022-05-27T14:44:17","name":"More misc Python patches","version":3,"mbox":"https://patchwork.libcamera.org/series/3146/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16072/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16072/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E852BD161\n\tfor ;\n\tFri, 27 May 2022 14:45:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0B5965631;\n\tFri, 27 May 2022 16:45:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62AC0633A2\n\tfor ;\n\tFri, 27 May 2022 16:45:05 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E1F0A58;\n\tFri, 27 May 2022 16:45:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662708;\n\tbh=upYDWDJdApqmzorAWn3YLVaQA6aoQJaTCnP3PF5ggoU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=p98A9eGonr20qoPxbhB8F0CXh7PYJiHHz+yBkp2g+ega/xL2a53UNEpsuuw8xba+q\n\tbvHYIntzVZGinM5jwPBXE/2kGm/9JFs+9eH1OdHxvf+8Y0IRuoRSV6CK/8aTezEQwo\n\tUR1MCvADWpJUYNlqYQlOqa/ygNOXBCsbaPRYrAAAL9kcoSOpfuPNPl/04+KUSb0BD9\n\tsNHWBnnAXz72prPLZ2y1ui8wH3V71Go21MCUb43M3ZwaA2UHztKW/YSXlX+roPpGsv\n\thcwqFLNm7Gx7LTHpWfrjMMFdlW8dxrG6H9CRxHoo6F0BDkPV/QovNEMTSgIQt1aXSB\n\tY5qtclG4J4IMw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662704;\n\tbh=upYDWDJdApqmzorAWn3YLVaQA6aoQJaTCnP3PF5ggoU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=k3ktjZrxHHp4B9CrK6+IikLvvY9rvFTra2+QoE60lRHeUfcAhqgWpcrijqF8KAmIc\n\tcvyFTr8Zrd/VkMZL0d1itR/z00foeZSrN2+XnLP7FPF6lsEvqOvpF2wwRKLeAk0tdT\n\tLGkjuw3aDF26m6zNAH6k8IzZJ2gQxybj7wVApTj0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"k3ktjZrx\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Fri, 27 May 2022 17:44:18 +0300","Message-Id":"<20220527144447.94891-2-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>","References":"<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 01/30] py: Generate pixel formats list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Generate a list of pixel formats under 'libcamera.formats'.\n\nThe 'formats' is a \"dummy\" container class, the only purpose of which is\nto contain the read-only pixel format properties.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n src/py/libcamera/gen-py-formats.py | 56 ++++++++++++++++++++\n src/py/libcamera/meson.build | 12 +++++\n src/py/libcamera/py_formats_generated.cpp.in | 25 +++++++++\n src/py/libcamera/py_main.cpp | 3 ++\n 4 files changed, 96 insertions(+)\n create mode 100755 src/py/libcamera/gen-py-formats.py\n create mode 100644 src/py/libcamera/py_formats_generated.cpp.in","diff":"diff --git a/src/py/libcamera/gen-py-formats.py b/src/py/libcamera/gen-py-formats.py\nnew file mode 100755\nindex 00000000..0ff1d12a\n--- /dev/null\n+++ b/src/py/libcamera/gen-py-formats.py\n@@ -0,0 +1,56 @@\n+#!/usr/bin/env python3\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+#\n+# Generate Python format definitions from YAML\n+\n+import argparse\n+import string\n+import sys\n+import yaml\n+\n+\n+def generate(formats):\n+ fmts = []\n+\n+ for format in formats:\n+ name, format = format.popitem()\n+ fmts.append(f'\\t\\t.def_readonly_static(\"{name}\", &libcamera::formats::{name})')\n+\n+ return {'formats': '\\n'.join(fmts)}\n+\n+\n+def fill_template(template, data):\n+ with open(template, encoding='utf-8') as f:\n+ template = f.read()\n+\n+ template = string.Template(template)\n+ return template.substitute(data)\n+\n+\n+def main(argv):\n+ parser = argparse.ArgumentParser()\n+ parser.add_argument('-o', dest='output', metavar='file', type=str,\n+ help='Output file name. Defaults to standard output if not specified.')\n+ parser.add_argument('input', type=str,\n+ help='Input file name.')\n+ parser.add_argument('template', type=str,\n+ help='Template file name.')\n+ args = parser.parse_args(argv[1:])\n+\n+ with open(args.input, encoding='utf-8') as f:\n+ formats = yaml.safe_load(f)['formats']\n+\n+ data = generate(formats)\n+ data = fill_template(args.template, data)\n+\n+ if args.output:\n+ with open(args.output, 'w', encoding='utf-8') as f:\n+ f.write(data)\n+ else:\n+ sys.stdout.write(data)\n+\n+ return 0\n+\n+\n+if __name__ == '__main__':\n+ sys.exit(main(sys.argv))\ndiff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex a3388c63..0a7b65f3 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -30,6 +30,18 @@ pycamera_sources += custom_target('py_gen_controls',\n output : ['py_control_enums_generated.cpp'],\n command : [gen_py_control_enums, '-o', '@OUTPUT@', '@INPUT@'])\n \n+gen_py_formats_input_files = files([\n+ '../../libcamera/formats.yaml',\n+ 'py_formats_generated.cpp.in',\n+])\n+\n+gen_py_formats = files('gen-py-formats.py')\n+\n+pycamera_sources += custom_target('py_gen_formats',\n+ input : gen_py_formats_input_files,\n+ output : ['py_formats_generated.cpp'],\n+ command : [gen_py_formats, '-o', '@OUTPUT@', '@INPUT@'])\n+\n pycamera_deps = [\n libcamera_public,\n py3_dep,\ndiff --git a/src/py/libcamera/py_formats_generated.cpp.in b/src/py/libcamera/py_formats_generated.cpp.in\nnew file mode 100644\nindex 00000000..b88807f3\n--- /dev/null\n+++ b/src/py/libcamera/py_formats_generated.cpp.in\n@@ -0,0 +1,25 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2022, Tomi Valkeinen \n+ *\n+ * Python bindings - Auto-generated formats\n+ *\n+ * This file is auto-generated. Do not edit.\n+ */\n+\n+#include \n+\n+#include \n+\n+namespace py = pybind11;\n+\n+class PyFormats\n+{\n+};\n+\n+void init_py_formats_generated(py::module& m)\n+{\n+\tpy::class_(m, \"formats\")\n+${formats}\n+\t;\n+}\ndiff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 1d941160..e7066841 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -132,6 +132,7 @@ static void handleRequestCompleted(Request *req)\n \n void init_py_enums(py::module &m);\n void init_py_control_enums_generated(py::module &m);\n+void init_py_formats_generated(py::module &m);\n void init_py_geometry(py::module &m);\n \n PYBIND11_MODULE(_libcamera, m)\n@@ -171,6 +172,8 @@ PYBIND11_MODULE(_libcamera, m)\n \tauto pyColorSpaceRange = py::enum_(pyColorSpace, \"Range\");\n \tauto pyPixelFormat = py::class_(m, \"PixelFormat\");\n \n+\tinit_py_formats_generated(m);\n+\n \t/* Global functions */\n \tm.def(\"log_set_level\", &logSetLevel);\n \n","prefixes":["libcamera-devel","v3","01/30"]}