[{"id":23211,"web_url":"https://patchwork.libcamera.org/comment/23211/","msgid":"<37f6935b-20c6-4ed1-3c73-951dec38b5fe@ideasonboard.com>","date":"2022-05-29T10:15:10","subject":"Re: [libcamera-devel] [PATCH v2 5/5] android: camera_device: Print\n\tthe correct number of completed streams","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul / Jacopo,\n\nThank you for the patch.\n\nOn 5/27/22 11:34, Paul Elder via libcamera-devel wrote:\n> From: Jacopo Mondi \n>\n> When a request completes, a debug message is generated to help\n> identify the request and the number of streams it contains.\n>\n> The printed number of streams is however the number of output buffers\n> requested by the camera framework, not the number of streams generated\n> by libcamera. In facts, some output buffers are generated by\n> post-processing, and not directly from the camera.\n>\n> As the debug message prints the libcamera identifier for the Request, it\n> is more logical to print the number of streams generated by the camera\n> instead of the total number of streams.\n>\n> Reviewed-by: Hirokazu Honda \n> Reviewed-by: Paul Elder \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Paul Elder \n\n\nReviewed-by: Umang Jain \n\n>\n> ---\n> Changes in v2:\n> - fix typo in commit message\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 9ee34b93..dfff8ec4 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1194,7 +1194,7 @@ void CameraDevice::requestComplete(Request *request)\n> \tnotifyShutter(descriptor->frameNumber_, sensorTimestamp);\n> \n> \tLOG(HAL, Debug) << \"Request \" << request->cookie() << \" completed with \"\n> -\t\t\t<< descriptor->buffers_.size() << \" streams\";\n> +\t\t\t<< descriptor->request_->buffers().size() << \" streams\";\n> \n> \t/*\n> \t * Generate the metadata associated with the captured buffers.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BBCCBD160\n\tfor ;\n\tSun, 29 May 2022 10:15:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE0B060415;\n\tSun, 29 May 2022 12:15:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0124960415\n\tfor ;\n\tSun, 29 May 2022 12:15:14 +0200 (CEST)","from [192.168.1.68] (235.red-81-36-186.dynamicip.rima-tde.net\n\t[81.36.186.235])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D8BF6DC;\n\tSun, 29 May 2022 12:15:13 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653819316;\n\tbh=op1j5yh6FgSnrkZf5kjjXcl8LmpvUqM5hBV1w0ABnsY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=p69hB07uypdzf11U728mi7NizxPQRoG1EXQ7G+OPm8oA/vtGYf8/kQydIbvnczV3U\n\t1nRA2zIfs9rZugWgO5EEBnFeNWL0juy/eIldUmzbWKBHwukNPQpTwmMlkf9e33pc7y\n\tX6XrKMJzUGZ0QzgvO5jMopDKr/7HHqUcKsPsEz/eCkUb9jsXBW9QlmAky/87oAmVnt\n\tDDA38A5/izmpkxVaSNqEZnObR79WVuN24HI7tt0K4r8a0R+0Rh8uWls8g2W8EXTeUY\n\tRpHRLo6i+Ew9MkoXB0u4aq2rAUvq8iKooUwEq1mJ3xWxD/9Teig6wfuo0s9zce6lRD\n\taYvsEi8f3SrkA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653819313;\n\tbh=op1j5yh6FgSnrkZf5kjjXcl8LmpvUqM5hBV1w0ABnsY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=UTAsca693rtkLZXEgK5l0BBAzKQyG583mU/eeYrNL1AqXk/WYr1ObfBDoCCZ/0URx\n\tA06O1CoVJpvVXxx0MB42ksG7JYDPoTCSeE2woZcNyTVq8BrgKuuy3SYGDz1RFWIYOZ\n\tygPBGfyvZAyWZhAY8ZxYYeppWs1meGGLz/QAdd/o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UTAsca69\"; dkim-atps=neutral","Message-ID":"<37f6935b-20c6-4ed1-3c73-951dec38b5fe@ideasonboard.com>","Date":"Sun, 29 May 2022 12:15:10 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220527093440.953377-1-paul.elder@ideasonboard.com>\n\t<20220527093440.953377-6-paul.elder@ideasonboard.com>","In-Reply-To":"<20220527093440.953377-6-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 5/5] android: camera_device: Print\n\tthe correct number of completed streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23293,"web_url":"https://patchwork.libcamera.org/comment/23293/","msgid":"","date":"2022-06-02T08:47:25","subject":"Re: [libcamera-devel] [PATCH v2 5/5] android: camera_device: Print\n\tthe correct number of completed streams","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul and Jacopo,\n\nThank you for the patch.\n\nOn Fri, May 27, 2022 at 06:34:40PM +0900, Paul Elder via libcamera-devel wrote:\n> From: Jacopo Mondi \n> \ne When a request completes, a debug message is generated to help\n> identify the request and the number of streams it contains.\n> \n> The printed number of streams is however the number of output buffers\n> requested by the camera framework, not the number of streams generated\n> by libcamera. In facts, some output buffers are generated by\n> post-processing, and not directly from the camera.\n> \n> As the debug message prints the libcamera identifier for the Request, it\n> is more logical to print the number of streams generated by the camera\n> instead of the total number of streams.\n> \n> Reviewed-by: Hirokazu Honda \n> Reviewed-by: Paul Elder \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Paul Elder \n> \n> ---\n> Changes in v2:\n> - fix typo in commit message\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 9ee34b93..dfff8ec4 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1194,7 +1194,7 @@ void CameraDevice::requestComplete(Request *request)\n> \tnotifyShutter(descriptor->frameNumber_, sensorTimestamp);\n> \n> \tLOG(HAL, Debug) << \"Request \" << request->cookie() << \" completed with \"\n> -\t\t\t<< descriptor->buffers_.size() << \" streams\";\n> +\t\t\t<< descriptor->request_->buffers().size() << \" streams\";\n\nWould it make sense to instead print\n\n\tLOG(HAL, Debug) << *descriptor->request_ << \" completed\";\n\n? Either way,\n\nReviewed-by: Laurent Pinchart \n\n> \n> \t/*\n> \t * Generate the metadata associated with the captured buffers.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D66CBD161\n\tfor ;\n\tThu, 2 Jun 2022 08:47:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5AA4765636;\n\tThu, 2 Jun 2022 10:47:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B163265633\n\tfor ;\n\tThu, 2 Jun 2022 10:47:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(lmontsouris-659-1-41-236.w92-154.abo.wanadoo.fr [92.154.76.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F3116BD;\n\tThu, 2 Jun 2022 10:47:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654159651;\n\tbh=I2PR9shnFuGC2mAFpxOQmAtXj0OIsL+7DJE0lgx4GJc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=n5tpCGaf9tOotVYmb2aAtDAykmi9W6vZXNJYuxRt0sJN73bofIztrY43+zXv2zsYH\n\tv5pLwjylnSfFTJxTgrfZtW7N37GNr38gHmvqPJihBnY/BMJC87NkYC7Cf3KQs4ozcH\n\t9vk3PpPYhcTa+kKmG70qhRdAb4xtHYst0pLFcuEaD+6TU/MA+sEQg3dC1TzvQJ5lMQ\n\tQGeHOpZv7JszR1JxWttO8KUp//9zUI2sStrpIjLYugpzkKGwgHppkFbd83O8iCqAyk\n\tSdjF5mRMn5wt2VRzQUUpcMPXRXqiQFSfdm7Ic0Dj8bro/V/tBLXPtSUQDCKqMaRK4k\n\tx6U8WdQAtYGUQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654159649;\n\tbh=I2PR9shnFuGC2mAFpxOQmAtXj0OIsL+7DJE0lgx4GJc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qZwLXDvh6ZS1jczDCUrOLdfxk0vVCMeW06yv+WBQatfT106hCJyKNaZVgttVRk9Xo\n\tPZxf3QabuXs5D6v3Hl78LxmPh3yi+eXZBDhiUpgOWM9+4csgTHgtWqCs5saCsmd5Rs\n\tfj95HZ68iRvpYl2EUoHTEYaxaal8fyBrIGDafCeo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qZwLXDvh\"; dkim-atps=neutral","Date":"Thu, 2 Jun 2022 11:47:25 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220527093440.953377-1-paul.elder@ideasonboard.com>\n\t<20220527093440.953377-6-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220527093440.953377-6-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 5/5] android: camera_device: Print\n\tthe correct number of completed streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]