[{"id":23186,"web_url":"https://patchwork.libcamera.org/comment/23186/","msgid":"<6deed62f-7693-8b7f-70d4-9fa0f36329bd@ideasonboard.com>","date":"2022-05-27T09:50:34","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Use \"...\" instead of\n\t<...> consistently for internal headers","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 5/26/22 13:00, Laurent Pinchart via libcamera-devel wrote:\n> libcamera uses double quotes for #include directives for internal\n> headers. A few <...> have found their way in the code base over time.\n> Fix them.\n>\n> While at it, move an Android header include to the right location.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/android/camera_hal_config.cpp | 6 +++---\n> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> test/yaml-parser.cpp | 2 +-\n> 3 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index 28072cb86285..8ba8738cc6b6 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -10,11 +10,11 @@\n> #include \n> #include \n> \n> -#include \n> -\n> #include \n> \n> -#include \n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +#include \n> \n> using namespace libcamera;\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index c818a6d71afc..7d6f0b39bb78 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -23,7 +23,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \"libcamera/internal/mapped_framebuffer.h\"\n> \n> #include \"algorithms/agc.h\"\n> #include \"algorithms/algorithm.h\"\n> diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\n> index 652adf53d0cc..5315d99fae5d 100644\n> --- a/test/yaml-parser.cpp\n> +++ b/test/yaml-parser.cpp\n> @@ -9,7 +9,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \"libcamera/internal/yaml_parser.h\"\n> \n> #include \"test.h\"\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09925BD161\n\tfor ;\n\tFri, 27 May 2022 09:50:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E282633A3;\n\tFri, 27 May 2022 11:50:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75A9860415\n\tfor ;\n\tFri, 27 May 2022 11:50:37 +0200 (CEST)","from [192.168.1.101] (unknown [90.164.63.43])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBA9B31A;\n\tFri, 27 May 2022 11:50:36 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653645038;\n\tbh=tOE0qRJ0NxbB23j+d/wxYhWGuTlYS0SyFurLtggDmtI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=gg9SC59qnYc+D1fCUnEpFnziSNYNhY3ye4pcfk+c5pf9lC5cbRkfdkSGxBIABWX3d\n\tUhxW34LKXvDmu8zqOi4gOa8CL1rldo4tnJi1rhQGpWDLWlCMMNwlgvhWoxyNnwFr3Q\n\tnmQ5YeVIXZJLcXM62CxHNVw6eYtelRKVlHHdzDM/BdDTfZjMYUqgcJekqlBoBg/qKh\n\tuhfDR8oLx8KGNHQbXJyqo+KCNRujVDs9UeVRj/aUQB2VVOjzCGplhnc096d5i4/GGn\n\tLgFmbD628WXyD55YZRFtioNds5Wrs1DD9334WVdSjRnqf1Hl4BkgfE/bFYQCBs7D/w\n\tj7fO+0Mgyjvtw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653645037;\n\tbh=tOE0qRJ0NxbB23j+d/wxYhWGuTlYS0SyFurLtggDmtI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=L0yLHnteNZYU5HyK6IoYGJFacFIuta2mzG01AjXp0RyGMX2VUB0GB/l/xqFSeRjVS\n\t567UKNjgoLc3aBXD6Sj1ER90AnBvFArszm5K8dl2HKeEpj2z6jpDDS8b3PGvegvTfI\n\tBgevQ/+sRll6f1UcuZuw5cFtc5AoKYAq/N0g7vuc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"L0yLHnte\"; dkim-atps=neutral","Message-ID":"<6deed62f-7693-8b7f-70d4-9fa0f36329bd@ideasonboard.com>","Date":"Fri, 27 May 2022 11:50:34 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220526110009.13874-1-laurent.pinchart@ideasonboard.com>\n\t<20220526110009.13874-4-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220526110009.13874-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Use \"...\" instead of\n\t<...> consistently for internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23190,"web_url":"https://patchwork.libcamera.org/comment/23190/","msgid":"<20220527104613.GJ4117012@pyrite.rasen.tech>","date":"2022-05-27T10:46:13","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Use \"...\" instead of\n\t<...> consistently for internal headers","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, May 26, 2022 at 02:00:09PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> libcamera uses double quotes for #include directives for internal\n> headers. A few <...> have found their way in the code base over time.\n> Fix them.\n> \n> While at it, move an Android header include to the right location.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_hal_config.cpp | 6 +++---\n> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> test/yaml-parser.cpp | 2 +-\n> 3 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index 28072cb86285..8ba8738cc6b6 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -10,11 +10,11 @@\n> #include \n> #include \n> \n> -#include \n> -\n> #include \n> \n> -#include \n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +#include \n> \n> using namespace libcamera;\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index c818a6d71afc..7d6f0b39bb78 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -23,7 +23,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \"libcamera/internal/mapped_framebuffer.h\"\n> \n> #include \"algorithms/agc.h\"\n> #include \"algorithms/algorithm.h\"\n> diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\n> index 652adf53d0cc..5315d99fae5d 100644\n> --- a/test/yaml-parser.cpp\n> +++ b/test/yaml-parser.cpp\n> @@ -9,7 +9,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \"libcamera/internal/yaml_parser.h\"\n> \n> #include \"test.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D512DBD160\n\tfor ;\n\tFri, 27 May 2022 10:46:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C306633A5;\n\tFri, 27 May 2022 12:46:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4CB8633A2\n\tfor ;\n\tFri, 27 May 2022 12:46:20 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B9AB31A;\n\tFri, 27 May 2022 12:46:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653648383;\n\tbh=HKKTWrHTm00BqQj92vNLYjyZCg4iiYmkmqBBJR253hE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1/Mv93nzr+dInnzebiXRLCiF7XZ/0l82PNbgDnUGm+adttlQgZvmA7aF5DjoxMZef\n\tD5VQ3Z4ue3E6lGxIxDzdo07zG+P3/4wkZ5fi+Ft8IlXcGKEuvpsLa9yL8gZoeLoGWj\n\tq3WQrekjGimnKXLY6zjsUKBNiNaADmyqNycO0g1wF2UCc5F94SXg1OK8CKEe6ln38V\n\tBQtCv+d2pfknLS+TlFH5K2AgPjIDkh+jm0pDhFoKutxv9sv8xpzCquVJxnFdkUu0pX\n\tbjsqaFflofdqgXXmceM4+J9BKFOTb0E/8N8qXMcq20u5KV8k1XXORqOCeY9R/GjeL5\n\ttsGPP5admRXJg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653648380;\n\tbh=HKKTWrHTm00BqQj92vNLYjyZCg4iiYmkmqBBJR253hE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ye+3cP/J6/oYF6W4yx/DiX2CdWKKln83YRF+hKhqckdwWXBapBsLI8j9u80H3CZA4\n\tF7E+bgFkh8WT+WcSkRZYGX80se1KWtze3xI4RbKucnf+3b6NasZfaa9Eg/r44Z2sOi\n\tcxb7sS5KTKYadw3ZedoXNHE+8XGeccHjdW9L+uKY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ye+3cP/J\"; dkim-atps=neutral","Date":"Fri, 27 May 2022 19:46:13 +0900","To":"Laurent Pinchart ","Message-ID":"<20220527104613.GJ4117012@pyrite.rasen.tech>","References":"<20220526110009.13874-1-laurent.pinchart@ideasonboard.com>\n\t<20220526110009.13874-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220526110009.13874-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Use \"...\" instead of\n\t<...> consistently for internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]