{"id":16062,"url":"https://patchwork.libcamera.org/api/patches/16062/?format=json","web_url":"https://patchwork.libcamera.org/patch/16062/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220526110009.13874-4-laurent.pinchart@ideasonboard.com>","date":"2022-05-26T11:00:09","name":"[libcamera-devel,3/3] libcamera: Use \"...\" instead of <...> consistently for internal headers","commit_ref":"5517ffbff68709c54aea17b938aa3415b1f63b0b","pull_url":null,"state":"accepted","archived":false,"hash":"4a72392c83e23f447d0164749f23416501699404","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16062/mbox/","series":[{"id":3142,"url":"https://patchwork.libcamera.org/api/series/3142/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3142","date":"2022-05-26T11:00:06","name":"libcamera: checkstyle: Improve header formatter","version":1,"mbox":"https://patchwork.libcamera.org/series/3142/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16062/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16062/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F17BC326E\n\tfor ;\n\tThu, 26 May 2022 11:00:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B8AA6566E;\n\tThu, 26 May 2022 13:00:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C143A65665\n\tfor ;\n\tThu, 26 May 2022 13:00:20 +0200 (CEST)","from pendragon.lan (unknown [37.120.212.14])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 104736D4\n\tfor ;\n\tThu, 26 May 2022 13:00:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653562823;\n\tbh=GRDxw18Eyf3vesUTXpjTRHMLyh41ytFc26qgoqRoYBA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=n1ahQzYqsKtxwWAfV1g+mKataR0RNS5tJwdJxdA8NjuVisigLyZKAwAHECQlemhlk\n\tFrq/SdlkIzE7OsoL1GtUsZfnwkX6vc78pRVzuRyEmoho0VYg/VCxi5Dd30t25ZiY7/\n\tXdfiaTlHCzCwbcTdg+uWrnrAiH/pJedyogYk+Hnff021bptfvCtrSdRGIL9o/wON8m\n\tJuHRJCeIzOLHam0F8eCmn665VMId0+uWJrittq0FwDBFK2eJkGvsZtTD6UpMSn45cs\n\txAIEsHzqsKlom4wwX0RhD0Zsk1201CUAlmi/cdRYdH+dpXgCwx7COLl9kP3jKpGu3h\n\tiJNT3USC2fZ0Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653562820;\n\tbh=GRDxw18Eyf3vesUTXpjTRHMLyh41ytFc26qgoqRoYBA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=FxzDCDDjuM76fEp90qPGccnUkmVrdMzVe+cz8IUJCS8fjVscmBxfJDEb8zCG2gZck\n\txkW+QZW0oPCW3o3g19RmcLq551e+ZTDqBv0303IhqOqf58Q/g78xs37RbZlDKP6EV2\n\t1MeQrH1CAbzxEOWYYfeuNOmLpaUQkI0uNkrKJJE0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FxzDCDDj\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 26 May 2022 14:00:09 +0300","Message-Id":"<20220526110009.13874-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220526110009.13874-1-laurent.pinchart@ideasonboard.com>","References":"<20220526110009.13874-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/3] libcamera: Use \"...\" instead of <...>\n\tconsistently for internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libcamera uses double quotes for #include directives for internal\nheaders. A few <...> have found their way in the code base over time.\nFix them.\n\nWhile at it, move an Android header include to the right location.\n\nSigned-off-by: Laurent Pinchart \n---\n src/android/camera_hal_config.cpp | 6 +++---\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n test/yaml-parser.cpp | 2 +-\n 3 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex 28072cb86285..8ba8738cc6b6 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -10,11 +10,11 @@\n #include \n #include \n \n-#include \n-\n #include \n \n-#include \n+#include \"libcamera/internal/yaml_parser.h\"\n+\n+#include \n \n using namespace libcamera;\n \ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex c818a6d71afc..7d6f0b39bb78 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -23,7 +23,7 @@\n #include \n #include \n \n-#include \n+#include \"libcamera/internal/mapped_framebuffer.h\"\n \n #include \"algorithms/agc.h\"\n #include \"algorithms/algorithm.h\"\ndiff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\nindex 652adf53d0cc..5315d99fae5d 100644\n--- a/test/yaml-parser.cpp\n+++ b/test/yaml-parser.cpp\n@@ -9,7 +9,7 @@\n #include \n #include \n \n-#include \n+#include \"libcamera/internal/yaml_parser.h\"\n \n #include \"test.h\"\n \n","prefixes":["libcamera-devel","3/3"]}