[{"id":23213,"web_url":"https://patchwork.libcamera.org/comment/23213/","msgid":"<1ec58ff9-9d82-5f8b-d588-1eb95a10282e@ideasonboard.com>","date":"2022-05-29T11:23:16","subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: base: log: Replace\n\tstderr with std::cerr in documentation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello,\n\nThank you for the patch,\n\nOn 5/26/22 00:25, Laurent Pinchart via libcamera-devel wrote:\n> While std::cerr and stderr both target the same file by default, this\n> may be overridden by applications. Update the documentation to use\n> std::cerr instead of stderr to be accurate.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/base/log.cpp | 11 ++++++-----\n> 1 file changed, 6 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index df84ba4e8328..9ae62368a54d 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -46,11 +46,11 @@\n> * their category are output to the log, while other messages are silently\n> * discarded.\n> *\n> - * By default log messages are output to stderr. They can be redirected to a log\n> - * file by setting the LIBCAMERA_LOG_FILE environment variable to the name of\n> - * the file. The file must be writable and is truncated if it exists. If any\n> + * By default log messages are output to std::cerr. They can be redirected to a\n> + * log file by setting the LIBCAMERA_LOG_FILE environment variable to the name\n> + * of the file. The file must be writable and is truncated if it exists. If any\n> * error occurs when opening the file, the file is ignored and the log is output\n> - * to stderr.\n> + * to std::cerr.\n> */\n> \n> /**\n> @@ -527,7 +527,8 @@ Logger::Logger()\n> * If the LIBCAMERA_LOG_FILE environment variable is set, open the file it\n> * points to and redirect the logger output to it. If the environment variable\n> * is set to \"syslog\", then the logger output will be directed to syslog. Errors\n> - * are silently ignored and don't affect the logger output (set to stderr).\n> + * are silently ignored and don't affect the logger output (set to std::cerr by\n> + * default).\n> */\n> void Logger::parseLogFile()\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7EC76BD160\n\tfor ;\n\tSun, 29 May 2022 11:23:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8FA4633A0;\n\tSun, 29 May 2022 13:23:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BFA860415\n\tfor ;\n\tSun, 29 May 2022 13:23:19 +0200 (CEST)","from [192.168.1.68] (235.red-81-36-186.dynamicip.rima-tde.net\n\t[81.36.186.235])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFC136DC;\n\tSun, 29 May 2022 13:23:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653823400;\n\tbh=pyHiaQ3k1yZOlfoqyNxc4vigzc8pCEwiGA3n7hzT8mg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qInqDQxI5CtXBVUBLxXrlOEBIDCSZD1H9ezwpWTKQ4Kd2h7mJyxrNfvJ9/CnrFgHj\n\t9HnBd0s3fRLiZvcBWs6PV9mtEJA8y6Ii7TPnl3HH/7r1C9I6/mMV31okCVT2Dpb3po\n\tuaNbdPuj/orrgDGd/Eg9ENLw7dnyVETB6CnpMmGohJ7qAf2450wCqQs5UwziFwnDZS\n\tEY5/l917ZI5YaIUJrCAWIaOA+tT1JqsRvqFj//V07H28z+jEjGxlDRLspuBvuwvMXF\n\tD1UJvcbYY8JYrIbQcfEh4KcHJ8sa+hKOJGRISywIrkgW3+/OC5gHeMXWFlAIRXPfXZ\n\tYlO9lBrBgECkQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653823399;\n\tbh=pyHiaQ3k1yZOlfoqyNxc4vigzc8pCEwiGA3n7hzT8mg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=iLks14qyfbxAYcgxwpTQ4fZ09kTfsOzZfIyFg8cBzTBzAlHGaRwrb7qsqtFEIpCSP\n\tAgVxhb/A8Qmh5t/aFOqU0B4ipJlfnRPNWlblWINe55ObMjChwH05un+0XNln3KLclB\n\tIBydaHrmSiCE2TDQF1IS28Dc7/VPZPZGsa1kpq/k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"iLks14qy\"; dkim-atps=neutral","Message-ID":"<1ec58ff9-9d82-5f8b-d588-1eb95a10282e@ideasonboard.com>","Date":"Sun, 29 May 2022 13:23:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220525222503.6460-1-laurent.pinchart@ideasonboard.com>\n\t<20220525222503.6460-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220525222503.6460-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: base: log: Replace\n\tstderr with std::cerr in documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23258,"web_url":"https://patchwork.libcamera.org/comment/23258/","msgid":"<20220531032029.GE2630765@pyrite.rasen.tech>","date":"2022-05-31T03:20:29","subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: base: log: Replace\n\tstderr with std::cerr in documentation","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Thu, May 26, 2022 at 01:25:00AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> While std::cerr and stderr both target the same file by default, this\n> may be overridden by applications. Update the documentation to use\n> std::cerr instead of stderr to be accurate.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/base/log.cpp | 11 ++++++-----\n> 1 file changed, 6 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index df84ba4e8328..9ae62368a54d 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -46,11 +46,11 @@\n> * their category are output to the log, while other messages are silently\n> * discarded.\n> *\n> - * By default log messages are output to stderr. They can be redirected to a log\n> - * file by setting the LIBCAMERA_LOG_FILE environment variable to the name of\n> - * the file. The file must be writable and is truncated if it exists. If any\n> + * By default log messages are output to std::cerr. They can be redirected to a\n> + * log file by setting the LIBCAMERA_LOG_FILE environment variable to the name\n> + * of the file. The file must be writable and is truncated if it exists. If any\n> * error occurs when opening the file, the file is ignored and the log is output\n> - * to stderr.\n> + * to std::cerr.\n> */\n> \n> /**\n> @@ -527,7 +527,8 @@ Logger::Logger()\n> * If the LIBCAMERA_LOG_FILE environment variable is set, open the file it\n> * points to and redirect the logger output to it. If the environment variable\n> * is set to \"syslog\", then the logger output will be directed to syslog. Errors\n> - * are silently ignored and don't affect the logger output (set to stderr).\n> + * are silently ignored and don't affect the logger output (set to std::cerr by\n> + * default).\n> */\n> void Logger::parseLogFile()\n> {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AAA9BD160\n\tfor ;\n\tTue, 31 May 2022 03:20:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E106965633;\n\tTue, 31 May 2022 05:20:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2734F6040A\n\tfor ;\n\tTue, 31 May 2022 05:20:37 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D187E6F0;\n\tTue, 31 May 2022 05:20:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653967238;\n\tbh=PzR+raSkFuDIOf+vwxXS5YVI0C3ieAek2tSBi3t0y1o=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1qa+oMRDAmrIcFADZwNhMJUfbDHnlp4B/xiQeFCeT3Uz0etlTRUFUHHvAfDRqCTwc\n\tCD9Pn151wyS5PfjbQzsoMxfEroRriVfFZhuu1t+pgJyRsM/RvO/kVZAoGa0HdyPIM3\n\t/r1+e5nKClTZuvJAQanqj9DWv9z+O2/qu+wEGmiMa6aMr3tTC0kg3uY0xiISCqhby9\n\thHCLvZX40C2KWNox8IBsGbZIQgJvcVehn3nT+2ytoy1+/Ea39iK1CeiFvDYdvOzJ1E\n\tKFEZQmavYm9LUdHr2oLMF2hAX/fuMP9/v7XDyABoV0CzIC3Uo02+kYe3Vxbv5LYwqY\n\tQCFaEyUIWd8cg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653967236;\n\tbh=PzR+raSkFuDIOf+vwxXS5YVI0C3ieAek2tSBi3t0y1o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=no3fQzkn+BqE14pRcECw/mzpxbsbO9jOZdO8k6OkohU3l1G4ZNgMEd3404h3D/TtX\n\tb5LFDIoRArP7KCS0+REcAqaN4voOx0j8OTKqBKarLWIdFllTjiTvp/L5IbYzdmFCzs\n\tfwh7B59m3hp67SU315/YzpXoSLauwTVommyPmP0Q="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"no3fQzkn\"; dkim-atps=neutral","Date":"Tue, 31 May 2022 12:20:29 +0900","To":"Laurent Pinchart ","Message-ID":"<20220531032029.GE2630765@pyrite.rasen.tech>","References":"<20220525222503.6460-1-laurent.pinchart@ideasonboard.com>\n\t<20220525222503.6460-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220525222503.6460-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/5] libcamera: base: log: Replace\n\tstderr with std::cerr in documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]