[{"id":23212,"web_url":"https://patchwork.libcamera.org/comment/23212/","msgid":"","date":"2022-05-29T11:17:51","subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: base: log: Remove\n\tunnecessary local variable","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 5/26/22 00:24, Laurent Pinchart via libcamera-devel wrote:\n> The output local variable in Logger::logSetTarget() isn't necessary.\n> Remove it.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/base/log.cpp | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n>\n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index 64813b6607c5..df84ba4e8328 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -477,15 +477,11 @@ int Logger::logSetStream(std::ostream *stream)\n> */\n> int Logger::logSetTarget(enum LoggingTarget target)\n> {\n> -\tstd::shared_ptr output;\n> -\n> \tswitch (target) {\n> \tcase LoggingTargetSyslog:\n> -\t\toutput = std::make_shared();\n> -\t\tstd::atomic_store(&output_, output);\n> +\t\tstd::atomic_store(&output_, std::make_shared());\n> \t\tbreak;\n> \tcase LoggingTargetNone:\n> -\t\toutput = nullptr;\n> \t\tstd::atomic_store(&output_, std::shared_ptr());\n> \t\tbreak;\n> \tdefault:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3C0EBD161\n\tfor ;\n\tSun, 29 May 2022 11:18:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA55C65633;\n\tSun, 29 May 2022 13:17:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A102760415\n\tfor ;\n\tSun, 29 May 2022 13:17:55 +0200 (CEST)","from [192.168.1.68] (235.red-81-36-186.dynamicip.rima-tde.net\n\t[81.36.186.235])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD3386DC;\n\tSun, 29 May 2022 13:17:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653823079;\n\tbh=XJlmxN17O4f0WwugUe0IwTZMX11nNuTvBrUHipp+d9U=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dAyI+a9dIfdrqgjFvBf5hqvgw5FQP8AuMHEF5cSCyks4oH9u/4QeMkwZ0BHYF873q\n\tGWa8USoJNK4wHpDVzi2vgaXuMH8mjma5VrRFEBiEmJBwElwb49rlu9dmQTjZCDyUWm\n\t3lzS6n3ofg4PAx6IEaYOkBMY7ToeOB1V0keqIXS7xUZSt3nkBoqE/E+INbXhxFkSaT\n\tHTJMrmd4wbu6gFPBSCcTD+anAb5G/94Gr0g3ahKK4F6A5f3BkN0PvtBrHAQo91gzKI\n\tDbWfgd+SitcGHo6QgzMED8aAkz+Ph1OkH3sLAPXrtc+rOt1/giF7O5RacQZrNV8swg\n\tDNnEgkJfTDrdQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653823075;\n\tbh=XJlmxN17O4f0WwugUe0IwTZMX11nNuTvBrUHipp+d9U=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=XIaCi3r6tjjmw57azqK+WHO+KgWnLOWpY5X9e/qqxo4djMt4mmRCUd/mQPQcxuSCp\n\tPKtednFFQjmoghoEChO68K+C/nlzsIltGNhkJdFhImPB2YNLi47c00oPAc8+0x+MP4\n\tUUMfObh1EIquyFztn01MKETDG+LOjFJL085WMR4w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XIaCi3r6\"; dkim-atps=neutral","Message-ID":"","Date":"Sun, 29 May 2022 13:17:51 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220525222503.6460-1-laurent.pinchart@ideasonboard.com>\n\t<20220525222503.6460-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220525222503.6460-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: base: log: Remove\n\tunnecessary local variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23257,"web_url":"https://patchwork.libcamera.org/comment/23257/","msgid":"<20220531031905.GD2630765@pyrite.rasen.tech>","date":"2022-05-31T03:19:05","subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: base: log: Remove\n\tunnecessary local variable","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Thu, May 26, 2022 at 01:24:59AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The output local variable in Logger::logSetTarget() isn't necessary.\n> Remove it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/base/log.cpp | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index 64813b6607c5..df84ba4e8328 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -477,15 +477,11 @@ int Logger::logSetStream(std::ostream *stream)\n> */\n> int Logger::logSetTarget(enum LoggingTarget target)\n> {\n> -\tstd::shared_ptr output;\n> -\n> \tswitch (target) {\n> \tcase LoggingTargetSyslog:\n> -\t\toutput = std::make_shared();\n> -\t\tstd::atomic_store(&output_, output);\n> +\t\tstd::atomic_store(&output_, std::make_shared());\n> \t\tbreak;\n> \tcase LoggingTargetNone:\n> -\t\toutput = nullptr;\n> \t\tstd::atomic_store(&output_, std::shared_ptr());\n> \t\tbreak;\n> \tdefault:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C2A3BD161\n\tfor ;\n\tTue, 31 May 2022 03:19:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D496465633;\n\tTue, 31 May 2022 05:19:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E406D6040A\n\tfor ;\n\tTue, 31 May 2022 05:19:14 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 584B36F0;\n\tTue, 31 May 2022 05:19:13 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653967156;\n\tbh=bUMs1ziJKxLsTk4ZP+u7X38/XHvWgNuyqMWHu5Y/rVs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=frQO5myc1HRJBIWBwkTcIGWsIbpLJQJolccjnfjSy8/4VXwIzVjGFsQPZH1pjgaAi\n\twO9hWfZVuvPAUYZpBPwy2ltjUMvcMTDgpnJltDc5IR/AZCPkDBtOmSvpp+jCL2Q039\n\tOfK14sL6uCt2uA1MQe+ncC/d5nyFFoxtDh7D+kSRx58ve4vjxmLDEAExdFescuxxv6\n\tixRh3f5D7KrsMBbiiofLOCCxFRRYWa51fuZqNOrOjeWhiLJUqGDfhREEPGNoi/4tjE\n\tOG/kQYKG5SEqwOPO/Fnmkh/S7LHHUY3r7pka3cqi6oASBfHu1G2M8KSG4ZHqkNxV4x\n\tGlkMR2l2gjH1w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653967154;\n\tbh=bUMs1ziJKxLsTk4ZP+u7X38/XHvWgNuyqMWHu5Y/rVs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MMtVqRT6qUq8Njq8flBuJ0SBWnlQKg4eMGDo91qnzEB6qkUZPKYm5P697hR9j7PJE\n\twZFsLCIzMdQk4F450gg+uvqncu6OxagEqC1crrrsyEo1CN8mjJyx0ihGDWV9Kmsrtd\n\tQGDO7/8P3kZebmp2rtIyfxNYrXUknM8kMbH2AR/U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MMtVqRT6\"; dkim-atps=neutral","Date":"Tue, 31 May 2022 12:19:05 +0900","To":"Laurent Pinchart ","Message-ID":"<20220531031905.GD2630765@pyrite.rasen.tech>","References":"<20220525222503.6460-1-laurent.pinchart@ideasonboard.com>\n\t<20220525222503.6460-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220525222503.6460-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: base: log: Remove\n\tunnecessary local variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]