[{"id":23147,"web_url":"https://patchwork.libcamera.org/comment/23147/","msgid":"","date":"2022-05-25T12:39:57","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tSony IMX477 helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, May 25, 2022 at 01:27:35PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Add suport for the Sony IMX477 sensor in the cameara helper database.\n\ns/suport/support/\n\nI'll fix that when applying.\n\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\nIt would be nice to use the CameraSensorHelper in the Raspberry Pi IPA\nat some point :-) We're missing support for integration time\ncalculation, delays and embedded data parsing. I'll try to implement at\nleast the first two at some point, and may then send a patch series to\nswitch.\n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 0f1561370c9c..2ddbf01cdeac 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -396,6 +396,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n> \n> +class CameraSensorHelperImx477 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx477()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 0, 1024, -1, 1024 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> +\n> class CameraSensorHelperOv2740 : public CameraSensorHelper\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13ACEBD160\n\tfor ;\n\tWed, 25 May 2022 12:40:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 436FE65663;\n\tWed, 25 May 2022 14:40:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5054A60429\n\tfor ;\n\tWed, 25 May 2022 14:40:02 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [141.113.67.45])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CEE10563;\n\tWed, 25 May 2022 14:40:01 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653482403;\n\tbh=TLtKUa/vjX6YSFbUsxvw8OXjBuIA1Mwss77L9j9YIww=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=llP3Cw68N5nylVMqBfFEaRy+GRdO2echX4GIzUNEclFo8Um1YgJvjn/D5W6tmBesA\n\tQ8/uUho64vjbfxGT2Io2srGXSWJjz41Kp43JfL50/Ov3JUZtOR5bOxHypHoDoR0MIL\n\tdAQk2mNcHVi3Mn/pVgyjsmyoYVZ6RaLQuQtavB0G3qRiHgnPME1Mxe4EDKkprCZ4wu\n\t6dY3M+JvhBm5Qbq09iWu3C0yhLAIHOSJstrm8MlRPIUmzP1qv/vyA3VoiiDUz58Dck\n\tU3Y7NV5I3UL+KTn6G8hIRhsHDhQnyienkopeIbNgAzpEEJ4nEf4tTovEaVpnLCwA/b\n\tnTWEN95fb/SOg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653482402;\n\tbh=TLtKUa/vjX6YSFbUsxvw8OXjBuIA1Mwss77L9j9YIww=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ID7ZxbRiTHCabHaZmt2ayqz1JzCvk7ZKgI8ana0QFivy0XcmEppR5sgw8le8/AsVs\n\tKjrJ1Z66EYMRxuu89vB6DQ9dZ7S74M5pvMKt2hC+HHnnbbE1lRuSNF8pv+ucmnpYa4\n\tlz52OdaRT3ukrAE7N3550pH/Eo1zlyGfXZohocmk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ID7ZxbRi\"; dkim-atps=neutral","Date":"Wed, 25 May 2022 15:39:57 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220525122735.3771958-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220525122735.3771958-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tSony IMX477 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23170,"web_url":"https://patchwork.libcamera.org/comment/23170/","msgid":"<20220527030553.GC4117012@pyrite.rasen.tech>","date":"2022-05-27T03:05:53","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tSony IMX477 helper","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Naush,\n\nOn Wed, May 25, 2022 at 01:27:35PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Add suport for the Sony IMX477 sensor in the cameara helper database.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 0f1561370c9c..2ddbf01cdeac 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -396,6 +396,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n> \n> +class CameraSensorHelperImx477 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx477()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 0, 1024, -1, 1024 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> +\n> class CameraSensorHelperOv2740 : public CameraSensorHelper\n> {\n> public:\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46CCBBD160\n\tfor ;\n\tFri, 27 May 2022 03:06:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A392F633A1;\n\tFri, 27 May 2022 05:06:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E437A61FB6\n\tfor ;\n\tFri, 27 May 2022 05:06:01 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C4832A5;\n\tFri, 27 May 2022 05:06:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653620763;\n\tbh=9c8Gj7+y4vheReOB1rz2ZgzECJ0L7MOLW4yxq18n3Xk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VC2FJOGhhyeFSZrfpjsBrpRvOHGvkBwK6kjUxxXyLWCKPxf7h5XEiiHnhMsN/vHHI\n\t4CPmTVWpEsBBwMaDtcPh25S9c1ETgyGzlTAlDAqXhJKx1d+x+E/kyi5noHs+vvjWBd\n\tUG/rt18bGzBXhuPsHcBb/5oggw/HvrRKAn2zVs6SadKgglRAMEJtlm2tGR4I0owbkb\n\ticrh6mRexPUHfJcbtZ/tztMBjJ9N+Tbjfb8rXDqmdz8vaIXnIt8XLxwfW24x+DmoHQ\n\tCTahSYXaPrXJEOnjaWQ1kQeH/MEtXPMKHbgAK8fl+OoMwh5qU/8W3rWz/L+Pqo0DYP\n\twqgu27k1Xmf3A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653620761;\n\tbh=9c8Gj7+y4vheReOB1rz2ZgzECJ0L7MOLW4yxq18n3Xk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fe++HYAC34SkKBwUSG2vhl7i/1y1hd/KzQ861rNEFqjHsMN6Jhy2k59rEdyoKSVic\n\tL+UI0k3JRHZLcS2oiS1nE85WnZmsWUL/ftcmUIvfmkrSsIjKbm7hWEa9nit4/SGSLA\n\tb70wtGIHKr6cygHdc0kBAXtEBIarGKVskRIlKXow="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fe++HYAC\"; dkim-atps=neutral","Date":"Fri, 27 May 2022 12:05:53 +0900","To":"Naushir Patuck ","Message-ID":"<20220527030553.GC4117012@pyrite.rasen.tech>","References":"<20220525122735.3771958-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220525122735.3771958-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tSony IMX477 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]