[{"id":23144,"web_url":"https://patchwork.libcamera.org/comment/23144/","msgid":"","date":"2022-05-25T12:13:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX477\n\tsensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, May 25, 2022 at 12:41:07PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Add an entry to the sensor properties for Sony IMX477. Currently\n> no test pattern modes are supported by the device driver.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\nCould you however also add support for the sensor to the\nCameraSensorHelper in src/ipa/libipa/ ?\n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 235edca190ce..e5f27f06eb1d 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -98,6 +98,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t.unitCellSize = { 3450, 3450 },\n> \t\t\t.testPatternModes = {},\n> \t\t} },\n> +\t\t{ \"imx477\", {\n> +\t\t\t.unitCellSize = { 1550, 1550 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n> \t\t{ \"ov2740\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50882BD160\n\tfor ;\n\tWed, 25 May 2022 12:13:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F2DB65663;\n\tWed, 25 May 2022 14:13:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 071BA60429\n\tfor ;\n\tWed, 25 May 2022 14:13:29 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [141.113.67.45])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F99712F3;\n\tWed, 25 May 2022 14:13:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653480810;\n\tbh=at97gVzAvUzEKDwrN87QabY+AOqCHxdCoG4J/bGy9GA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=dcwzA/Y4uPANXYzielJYkxLgQwSBCoKT55ctRFJBQw4xELvNT7Ob5CBbyh3KzOmAh\n\tJ49CSFQLz3i5dy/iOVFnokE9ANoEXTInv0dFm/a8LkZqcpmkKEjSM9DrShrmdOLJuk\n\tnDw3Xj9Gls3Ab4QohDTm0IHQY1vn0m1g5gwae7nCYGnze1uCDBxWrXVtYep7phURaI\n\tVfPyhJlKzuVWlgzb/bvPwYhiR/67lmHKwLSf+i4P1uJH8r/RQ0UqU1HEZA9V0g/Ks8\n\tObrapKGm+adHvRiQSOMG5dO1RppHjz5HWz7TqiO+giaDZ5LeMhJzspzrvWXvNhQ0Yu\n\ttSWnzSZgR3yjw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653480808;\n\tbh=at97gVzAvUzEKDwrN87QabY+AOqCHxdCoG4J/bGy9GA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eBTRhhLY2rWzO+9NXg0yVfXhrMHLZnW3URTupC0PjwSKJRXUqv/NgnKGIG90pY3ft\n\t7BAJXlCy2JIqNlFPKXay4nQ5Qp7U01IKnbTDfnd8WmHq9LhvI9TrbkAnSnooOragE0\n\tMTCoYSxhPpy30gi68zEG35qqpX6Y/MJhcyZbyvNA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eBTRhhLY\"; dkim-atps=neutral","Date":"Wed, 25 May 2022 15:13:22 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220525114107.3764033-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220525114107.3764033-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX477\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23169,"web_url":"https://patchwork.libcamera.org/comment/23169/","msgid":"<20220527024821.GB4117012@pyrite.rasen.tech>","date":"2022-05-27T02:48:21","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX477\n\tsensor properties","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Naush,\n\nOn Wed, May 25, 2022 at 12:41:07PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Add an entry to the sensor properties for Sony IMX477. Currently\n> no test pattern modes are supported by the device driver.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 235edca190ce..e5f27f06eb1d 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -98,6 +98,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t.unitCellSize = { 3450, 3450 },\n> \t\t\t.testPatternModes = {},\n> \t\t} },\n> +\t\t{ \"imx477\", {\n> +\t\t\t.unitCellSize = { 1550, 1550 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n> \t\t{ \"ov2740\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 628F9BD161\n\tfor ;\n\tFri, 27 May 2022 02:48:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FCD6633A1;\n\tFri, 27 May 2022 04:48:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C0C561FB6\n\tfor ;\n\tFri, 27 May 2022 04:48:29 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CD8132A;\n\tFri, 27 May 2022 04:48:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653619711;\n\tbh=wDJ6LP2tqtRFUQL0ADiXiXc23oEEeuNYXcMDoDTbFOM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jsSHQRfFRkBtbMeU72ECkMZYqhqCXt/Uq23nfApOPJs/xmOo31CrHprYbyqDXQDS9\n\t8ib6LMEDaDXB358V9xYYsoGhkPfGbb1FfovVMv1VoQ+FkVBfP7lNuHYcaDPWan0/JH\n\t6c8VqN9a4EylcS3ayvYuFP+h03axsEdFj9hvS/1rl/FKy77EiahCN3edBLsn2RS3Ez\n\tZUj65Z7Ric098iI7Zq4SVJnt27+XmS6JBCFTKncYXNX4QuTVdRMHQ9BLhDU6TAIHdw\n\tBVy/F5DApqpdJ2LwT17TrskEsICT2daCPLTl4/iiVmOBX3xZdACSBxRdKRRHtc3HfM\n\tBwUBZRosRU3OA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653619709;\n\tbh=wDJ6LP2tqtRFUQL0ADiXiXc23oEEeuNYXcMDoDTbFOM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WsF+1A3L4DcKgXrYbY/z6ki4N6qE6aBiMBn+iOSb2e9JJao0xInVPJ1hBoxBsQcLz\n\tGujU66VoD7aOihnCfkrck4mi6GcAjI2jzprhk/kFgUCkI9k5nJdSJxJfrmi2VKg8OS\n\tM0FmGs0Wj6rpqkrfByuNoeMdP8dr6n1WnRXf3l7M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WsF+1A3L\"; dkim-atps=neutral","Date":"Fri, 27 May 2022 11:48:21 +0900","To":"Naushir Patuck ","Message-ID":"<20220527024821.GB4117012@pyrite.rasen.tech>","References":"<20220525114107.3764033-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220525114107.3764033-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX477\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]