[{"id":23148,"web_url":"https://patchwork.libcamera.org/comment/23148/","msgid":"<7fadf3a3-09e0-a5b9-1e21-dacc1600427e@ideasonboard.com>","date":"2022-05-25T15:34:26","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa: Move IPA control\n\tserialization structures to libcamera namespace","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 5/25/22 12:25, Laurent Pinchart via libcamera-devel wrote:\n> The C structures used to serialize controls are currently defined in the\n> root namespace, which places them at the root level in the class list\n> generated by Doxygen. Move them to the libcamera namespace to fix that.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/ipa/ipa_controls.h | 4 ++++\n> src/libcamera/ipa_controls.cpp | 4 ++++\n> 2 files changed, 8 insertions(+)\n>\n> diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\n> index da1a759618e0..e5da1946ce1d 100644\n> --- a/include/libcamera/ipa/ipa_controls.h\n> +++ b/include/libcamera/ipa/ipa_controls.h\n> @@ -10,6 +10,8 @@\n> #include \n> \n> #ifdef __cplusplus\n> +namespace libcamera {\n> +\n> extern \"C\" {\n> #endif\n> \n> @@ -48,5 +50,7 @@ struct ipa_control_info_entry {\n> };\n> \n> #ifdef __cplusplus\n> +} /* namespace libcamera */\n> +\n> }\n> #endif\n> diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n> index c3489bbff646..870a443b0f38 100644\n> --- a/src/libcamera/ipa_controls.cpp\n> +++ b/src/libcamera/ipa_controls.cpp\n> @@ -131,6 +131,8 @@\n> * shall be ignored when parsing the packet.\n> */\n> \n> +namespace libcamera {\n> +\n> /**\n> * \\def IPA_CONTROLS_FORMAT_VERSION\n> * \\brief The current control serialization format version\n> @@ -224,3 +226,5 @@ static_assert(sizeof(ipa_control_value_entry) == 16,\n> \n> static_assert(sizeof(ipa_control_info_entry) == 16,\n> \t \"Invalid ABI size change for struct ipa_control_info_entry\");\n> +\n> +} /* namespace libcamera */\n>\n> base-commit: 3e7f54a3128d8143afb200d626d3b208d493623a","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B163CBD161\n\tfor ;\n\tWed, 25 May 2022 15:34:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC35965663;\n\tWed, 25 May 2022 17:34:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2C7160429\n\tfor ;\n\tWed, 25 May 2022 17:34:29 +0200 (CEST)","from [192.168.1.101] (unknown [90.164.63.43])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1ABA712F3;\n\tWed, 25 May 2022 17:34:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653492870;\n\tbh=gSrRgWGF/82rOrNXIZFvqA/i8QP5l1v9ihX43kVj7e8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=skkwffdftVTwbwKiAbimxI0bKCYACbXtcvU2B+TtKyyBppgShIp2J8ZrtqlO1RAQX\n\tm8UMWk3OaHtbF/7mGLXhp0YTOszh5BFd8UfmMon32y10KTXkj3c3XhkAKafil7adk5\n\tqrA+VQVftQOs0SkVqVxelzWio+T6gVl1XWKq/ixEdhaUbf5OzUXbWXsn1axp47gbHp\n\tH44stFaq15EWQ/Nh3PUIZiHbNOImpuV+haV/JsiRPmZlFKkUanCESsmj7hnja66+t/\n\tUOYD3e2I2BUT4sTeE6XHxtdzUvrBc4lh3MdA8HWeKIvrCuqJp84pTdGkBPUVSTbpAm\n\tuemqtT5Grxn6A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653492869;\n\tbh=gSrRgWGF/82rOrNXIZFvqA/i8QP5l1v9ihX43kVj7e8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=StxB/WDFdJnZ/tjmvq7eqgtSCzG1Wr5saI9AeGAAmjTqnQse1EfOD0nzW4A8togYB\n\t7fmBhksg+usQGG+WHIXVCWh5U/Onp1hjxUGyuQfSk8gr3xPuP3oZyudrzqXSjzUiwZ\n\tUwkW4QhDgcG29KsjyZK4W4EUPKVY2X4GLclau7bM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"StxB/WDF\"; dkim-atps=neutral","Message-ID":"<7fadf3a3-09e0-a5b9-1e21-dacc1600427e@ideasonboard.com>","Date":"Wed, 25 May 2022 17:34:26 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220525102533.32052-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220525102533.32052-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa: Move IPA control\n\tserialization structures to libcamera namespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23197,"web_url":"https://patchwork.libcamera.org/comment/23197/","msgid":"<20220527121108.GA1504632@pyrite.rasen.tech>","date":"2022-05-27T12:11:08","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa: Move IPA control\n\tserialization structures to libcamera namespace","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Wed, May 25, 2022 at 01:25:33PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The C structures used to serialize controls are currently defined in the\n> root namespace, which places them at the root level in the class list\n> generated by Doxygen. Move them to the libcamera namespace to fix that.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/ipa/ipa_controls.h | 4 ++++\n> src/libcamera/ipa_controls.cpp | 4 ++++\n> 2 files changed, 8 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\n> index da1a759618e0..e5da1946ce1d 100644\n> --- a/include/libcamera/ipa/ipa_controls.h\n> +++ b/include/libcamera/ipa/ipa_controls.h\n> @@ -10,6 +10,8 @@\n> #include \n> \n> #ifdef __cplusplus\n> +namespace libcamera {\n> +\n> extern \"C\" {\n> #endif\n> \n> @@ -48,5 +50,7 @@ struct ipa_control_info_entry {\n> };\n> \n> #ifdef __cplusplus\n> +} /* namespace libcamera */\n> +\n> }\n> #endif\n> diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n> index c3489bbff646..870a443b0f38 100644\n> --- a/src/libcamera/ipa_controls.cpp\n> +++ b/src/libcamera/ipa_controls.cpp\n> @@ -131,6 +131,8 @@\n> * shall be ignored when parsing the packet.\n> */\n> \n> +namespace libcamera {\n> +\n> /**\n> * \\def IPA_CONTROLS_FORMAT_VERSION\n> * \\brief The current control serialization format version\n> @@ -224,3 +226,5 @@ static_assert(sizeof(ipa_control_value_entry) == 16,\n> \n> static_assert(sizeof(ipa_control_info_entry) == 16,\n> \t \"Invalid ABI size change for struct ipa_control_info_entry\");\n> +\n> +} /* namespace libcamera */\n> \n> base-commit: 3e7f54a3128d8143afb200d626d3b208d493623a","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24B26BD161\n\tfor ;\n\tFri, 27 May 2022 12:11:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67697633A5;\n\tFri, 27 May 2022 14:11:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4453633A2\n\tfor ;\n\tFri, 27 May 2022 14:11:16 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB630305;\n\tFri, 27 May 2022 14:11:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653653478;\n\tbh=B2QefBBKX/b58tGLhK4UbTsWYymagcTuPxOGuGQL3SU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=veW7hlntnBQwojb2xcCxHLSMpgqTHHxR0FI703hBhKaZ33VYsZ1DQdpM5ypI76dQ6\n\tzPAS3bi+UCPcQCAePIlLirmM/F5vSOG+bbq2RAHje8VUevXAL2KR1kP3j6Cn2Kpnuo\n\tIpPEXCGIcN5R6S3akSKRddxpsrBMYwNazTN7W7Ab9pweAdzbcRN4xTXoPhhs8pyq7c\n\t2PxuEdHQXixi4+oPdvxsdi3BTu1CQFxPWoG/xGAD1SHV/xMo+7Phnja87Aq9NVfpmz\n\tds7hhjpM64m+T34Qe+gOEr3MrHe4q4ws8BqynjrPwoIYwozgY78pS1hDpL+pr3acE7\n\t+PVmAp9AqeSaA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653653476;\n\tbh=B2QefBBKX/b58tGLhK4UbTsWYymagcTuPxOGuGQL3SU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DPHBcVPWcqArT9YWW/U/1iCDzkJC1X8oeV+pMF8JeN+0/DlZMkTrEiRQFwAeEoXsP\n\tWvrbjyc1ZOlFBAPyfv1r1JYbhZgE1vY3rtUVTcI9G0JqjyxNSehv4TLhmM9iDv7Qan\n\taw3pXJeYJgFr9A8Lc9YpKBMuYjkkSGRFC6dtNcuw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DPHBcVPW\"; dkim-atps=neutral","Date":"Fri, 27 May 2022 21:11:08 +0900","To":"Laurent Pinchart ","Message-ID":"<20220527121108.GA1504632@pyrite.rasen.tech>","References":"<20220525102533.32052-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220525102533.32052-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa: Move IPA control\n\tserialization structures to libcamera namespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]