[{"id":23149,"web_url":"https://patchwork.libcamera.org/comment/23149/","msgid":"<9ba91340-114b-e9d1-8e87-77d4a2478811@ideasonboard.com>","date":"2022-05-25T15:34:57","subject":"Re: [libcamera-devel] [PATCH] ipa: camera_sensor_helper: Fix\n\tequation in exponential gain documentation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the atpch\n\nOn 5/25/22 10:32, Laurent Pinchart via libcamera-devel wrote:\n> The exponential gain documentation is missing a '\\' in the equation. Fix\n> t.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 0f1561370c9c..d94147a8b1ac 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -154,7 +154,7 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n> * through the 'm' coefficient.\n> *\n> * When the gain is expressed in dB, 'a' is equal to 1 and 'm' to\n> - * \\f$log_{2}{10^{frac{1}{20}}}\\f$.\n> + * \\f$log_{2}{10^{\\frac{1}{20}}}\\f$.\n> */\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FDA6BD161\n\tfor ;\n\tWed, 25 May 2022 15:35:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B34B865664;\n\tWed, 25 May 2022 17:35:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41CA965661\n\tfor ;\n\tWed, 25 May 2022 17:35:00 +0200 (CEST)","from [192.168.1.101] (unknown [90.164.63.43])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB72C59D;\n\tWed, 25 May 2022 17:34:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653492901;\n\tbh=DiRgJ1rocrXV2i6MzEMKXV+d2IEgx9Xn0bqj71t/C1w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=4DI10vtbNbH/ZwUIkx5Qqjh/Nfk+v8K9yWbBvkTmzpHVW3U+f8X2CeQQFH8BDCnX9\n\tNcJm562cw3Qsrw8uDgpX9Ly5AhiEQdns1GDy3qtNvmg/w51/uaOZM/DkKyfHtDeJ53\n\t9tY0cnQlhvrXrKra9hmsrin9bWGapbN/8ILx7VOIkmHlHiysG93UkfP7JfdYhhdn9V\n\tmNHu250c8IFKve4X1F6xKoeJXTO54nefeEU3gOhICqVNS1m26jRFtr326Ui5MDFb22\n\tuvYFAVxVXFcgvnrXASoU/PfTE84neVZf3rILVxI//DE3xxn71P6fsC0ou8mNJ1VG6E\n\tr1orMuw1tznJA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653492900;\n\tbh=DiRgJ1rocrXV2i6MzEMKXV+d2IEgx9Xn0bqj71t/C1w=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=XQ9wiFgHAdkZ8jKGNdgZwWd6V8mEgOrHRL6r4empgAC7azxZj8kC5QL9thD0wxI0T\n\tmECAl9U730seltAuAKF8ams85Ny0aeFkMoTXIoaLsoTliZGblnN/S4GVdQEABkWVvD\n\tHH/9tLENuqrYFLtxa3NPUQu0jbxtTuv6h+HKU4iI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XQ9wiFgH\"; dkim-atps=neutral","Message-ID":"<9ba91340-114b-e9d1-8e87-77d4a2478811@ideasonboard.com>","Date":"Wed, 25 May 2022 17:34:57 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220525083229.16880-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220525083229.16880-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] ipa: camera_sensor_helper: Fix\n\tequation in exponential gain documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23154,"web_url":"https://patchwork.libcamera.org/comment/23154/","msgid":"<165352117308.141902.6002891151187883077@Monstersaurus>","date":"2022-05-25T23:26:13","subject":"Re: [libcamera-devel] [PATCH] ipa: camera_sensor_helper: Fix\n\tequation in exponential gain documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-05-25 09:32:29)\n> The exponential gain documentation is missing a '\\' in the equation. Fix\n> t.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 0f1561370c9c..d94147a8b1ac 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -154,7 +154,7 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n> * through the 'm' coefficient.\n> *\n> * When the gain is expressed in dB, 'a' is equal to 1 and 'm' to\n> - * \\f$log_{2}{10^{frac{1}{20}}}\\f$.\n> + * \\f$log_{2}{10^{\\frac{1}{20}}}\\f$.\n\n\nReviewed-by: Kieran Bingham \n\n> */\n> \n> /**\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBAA5BD160\n\tfor ;\n\tWed, 25 May 2022 23:26:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B45A65663;\n\tThu, 26 May 2022 01:26:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE61460422\n\tfor ;\n\tThu, 26 May 2022 01:26:15 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FD0F496;\n\tThu, 26 May 2022 01:26:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653521176;\n\tbh=vwbAVrPUJY8vW51pVKn192K4ZG2JWIATm64N0Bs7x40=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=3+gfhJpHfYbzf5AQqbTKk0EBtqoTqwx6HEsBTU/dc9rnVPXwj1VuBgbUpEI5e5OLV\n\txWwuUAZvn3b2x/BL+m2Ysu9xfg0161XAFSnQzzZDIxnH7/ltfmn8IXqiBqu/pMMoNj\n\t5Ji3O0mGF22vKOU3vMSscIIP6hkM5t4SmIZIEIVWKvODnyz54OeYCBCeJ+ycA/UFIA\n\tKXDWTC/YAoS76UtEx8jbWirXtbF5E4XrWYGn97ZIUKFKXgA2vd0FcLMW85hwuXf2BI\n\tOPlHDkftU9SOBOgpU0ur7BzKCW9YsKGoJzBetNN4zS2rNODSM8bB8Bl+FfUUHcaE4y\n\tAiLk6AhoroyQA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653521175;\n\tbh=vwbAVrPUJY8vW51pVKn192K4ZG2JWIATm64N0Bs7x40=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Pg69fHdQMwRaqgoPUfAOAHe/94vzCqXXF2ESMfWRcvpagiqIdu3yBB/ASV3vWACoq\n\tsC9bzMwjHDUJdrghEAUA8zlYgqilXlhmSJhOMmjRS0bc5QSaa9P7CJsyVSt3yboll5\n\t5JR5sE52dzLDdliQGke/jn7Pt8Dapqmp/onVWJcE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Pg69fHdQ\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220525083229.16880-1-laurent.pinchart@ideasonboard.com>","References":"<20220525083229.16880-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 26 May 2022 00:26:13 +0100","Message-ID":"<165352117308.141902.6002891151187883077@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: camera_sensor_helper: Fix\n\tequation in exponential gain documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]