[{"id":23164,"web_url":"https://patchwork.libcamera.org/comment/23164/","msgid":"","date":"2022-05-26T15:32:12","subject":"Re: [libcamera-devel] [PATCH v2 09/19] py: cam: Drop\n\tWA_ShowWithoutActivating","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Tue, May 24, 2022 at 02:46:00PM +0300, Tomi Valkeinen wrote:\n> Drop WA_ShowWithoutActivating from the Qt renderers. I added the flag\n> during development phase as I didn't want the window to take the focus,\n> but it should be removed now.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/cam/cam_qt.py | 1 -\n> src/py/cam/cam_qtgl.py | 1 -\n> 2 files changed, 2 deletions(-)\n> \n> diff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py\n> index 70bdb7bb..03096920 100644\n> --- a/src/py/cam/cam_qt.py\n> +++ b/src/py/cam/cam_qt.py\n> @@ -187,7 +187,6 @@ class QtRenderer:\n> for ctx in self.contexts:\n> for stream in ctx['streams']:\n> window = MainWindow(ctx, stream)\n> - window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)\n> window.show()\n> windows.append(window)\n> \n> diff --git a/src/py/cam/cam_qtgl.py b/src/py/cam/cam_qtgl.py\n> index 3fb7dde3..c9e367a2 100644\n> --- a/src/py/cam/cam_qtgl.py\n> +++ b/src/py/cam/cam_qtgl.py\n> @@ -137,7 +137,6 @@ class QtRenderer:\n> self.app = QtWidgets.QApplication([])\n> \n> window = MainWindow(self.state)\n> - window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)\n> window.show()\n> \n> self.window = window","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 139DBBD160\n\tfor ;\n\tThu, 26 May 2022 15:32:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2C61611BF;\n\tThu, 26 May 2022 17:32:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 928CF60DB0\n\tfor ;\n\tThu, 26 May 2022 17:32:18 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [37.120.212.14])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 16C9E32A;\n\tThu, 26 May 2022 17:32:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653579139;\n\tbh=8yOBwBWj/zpevLEwknm1Di47onM6PeSC51zl3cUCseQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VHzKpkRW1Lvul2OwTiNjulwcuntYJhNBDxuPNFlkOoap0gnixGIwaWdphqZDhgE96\n\tC/gRYwF0eLZAuNumDdTYEkGvmhIgPJNBE3mEO0k4hc3nOxebvLVvovYiyT+9mv5GTU\n\trMEDJwgMaYEJAo6Wr5W8Wl/NuhzrvXz3D2Qs2go4XK9MzrTXYX1KqSrJsrBru7jncg\n\t/6IYUKF35ZV15h3VlY/aKLzOowyYTrjn2EC4w5LkksUUlFeLVy1OOStEHmly+OHGXD\n\tDcVmBZcDnuF4n3RTovC5R5XyYKgzyqepa83Vzq0epg2E0vS5DyyAc4AuLvXTNWzRN8\n\t0vyNBPl7L8J4g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653579138;\n\tbh=8yOBwBWj/zpevLEwknm1Di47onM6PeSC51zl3cUCseQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=emHagqQYoV5iJ9ALcLIrMO+VHP4pdGMiyeJYRsGPvhVrFsigB6A69UoY0yIMVWe2k\n\t/MfOWR+K4kAF8JTWS394AII9lU/VXf/09uTPEj6XvXKHAVesMG87CrE+hudD85Hjre\n\tvlmoAIYIBNnm2LenrDCeN0JPPnXqtSPPbR4+G4Bw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"emHagqQY\"; dkim-atps=neutral","Date":"Thu, 26 May 2022 18:32:12 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>\n\t<20220524114610.41848-10-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220524114610.41848-10-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 09/19] py: cam: Drop\n\tWA_ShowWithoutActivating","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]