{"id":16010,"url":"https://patchwork.libcamera.org/api/patches/16010/?format=json","web_url":"https://patchwork.libcamera.org/patch/16010/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220524114610.41848-5-tomi.valkeinen@ideasonboard.com>","date":"2022-05-24T11:45:55","name":"[libcamera-devel,v2,04/19] py: Fix SceneFlicker enum values","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"302e350a9c92f4bfa0cd6889ed787bcec334c477","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16010/mbox/","series":[{"id":3134,"url":"https://patchwork.libcamera.org/api/series/3134/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3134","date":"2022-05-24T11:45:51","name":"More misc Python patches","version":2,"mbox":"https://patchwork.libcamera.org/series/3134/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16010/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16010/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6122CC326D\n\tfor ;\n\tTue, 24 May 2022 11:46:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39E7E65678;\n\tTue, 24 May 2022 13:46:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1473465666\n\tfor ;\n\tTue, 24 May 2022 13:46:32 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CAA4AEC;\n\tTue, 24 May 2022 13:46:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653392797;\n\tbh=J82y7/1hXVMiwHUAH2A1Gwma14uw5Jc//aizDlp0V5U=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=XutE+9veGd7UuRxKNeVOHptHTjhY0DEUCsnLAMo1Q3bGljM7EKCgbaVo7Ojj9kpb6\n\tsGsOGrPLANiciTEm6mrvQbJwjf+/u9wAksffcfJeZaiyfACYh31ET696/EAyPJuMi1\n\tva5f47prpHUkDZIOP171ZXfwti5jhsmVNkBP8Q57eT8XnmHQgDLIHeNTSjFRBswsF7\n\tVlgB+eTj49RpZSnrtMuD27dHxuX4l7nOeYYpvGGFPah8SVpXpAZAzGXJuDrt4bfZuw\n\t8MRo5s7u9ugFkkIS4tGmL6Yk9VTNaTnVZohuDOWkNY/U1GKNPGu53YvQ4wsLICibaM\n\tqzdoCeVEvePnQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653392791;\n\tbh=J82y7/1hXVMiwHUAH2A1Gwma14uw5Jc//aizDlp0V5U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=I0H1K9zqHtG5xJhQznh4wO4RH8WO8z+5rGLivtTK4A65Sk+/wgt2ACXo3qOCn3DIh\n\t/4a2V/b842oBg86chnaSNLZgz8/RTJhhmaKGdh/UUcpeLl1W1We1gTxNBmE2shOvwl\n\tQRAgSwwOXETdOjrWsXQBYJwRVrAiJohAHfjXDzHo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"I0H1K9zq\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Tue, 24 May 2022 14:45:55 +0300","Message-Id":"<20220524114610.41848-5-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>","References":"<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 04/19] py: Fix SceneFlicker enum values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Stripping 'SceneFlicker' prefix from the enum value names leads to\n'50Hz' and '60Hz', which are not valid names. So add another heuristics\nto keep the prefix for SceneFlicker.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \n---\n src/py/libcamera/gen-py-control-enums.py | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/py/libcamera/gen-py-control-enums.py b/src/py/libcamera/gen-py-control-enums.py\nindex dcc28b1a..6b2b5362 100755\n--- a/src/py/libcamera/gen-py-control-enums.py\n+++ b/src/py/libcamera/gen-py-control-enums.py\n@@ -42,6 +42,9 @@ def generate_py(controls):\n \n if name == 'LensShadingMapMode':\n prefix = 'LensShadingMapMode'\n+ elif name == 'SceneFlicker':\n+ # If we strip the prefix, we would get '50Hz', which is illegal name\n+ prefix = ''\n else:\n prefix = find_common_prefix([e['name'] for e in enum])\n \n","prefixes":["libcamera-devel","v2","04/19"]}