[{"id":23160,"web_url":"https://patchwork.libcamera.org/comment/23160/","msgid":"","date":"2022-05-26T15:25:42","subject":"Re: [libcamera-devel] [PATCH v2 03/19] py: cam: Cleanups","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Tue, May 24, 2022 at 02:45:54PM +0300, Tomi Valkeinen wrote:\n> No functional changes. Drop unused variables, reduce typechecker\n> warnings.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/cam/cam.py | 2 +-\n> src/py/cam/cam_qt.py | 12 ++----------\n> src/py/cam/cam_qtgl.py | 9 ++-------\n> 3 files changed, 5 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\n> index 2f0690b5..e2bc78da 100755\n> --- a/src/py/cam/cam.py\n> +++ b/src/py/cam/cam.py\n> @@ -304,7 +304,7 @@ def event_handler(state):\n> \n> running = any(ctx['reqs-completed'] < ctx['opt-capture'] for ctx in contexts)\n> return running\n> - except Exception as e:\n> + except Exception:\n> traceback.print_exc()\n> return False\n> \n> diff --git a/src/py/cam/cam_qt.py b/src/py/cam/cam_qt.py\n> index 0a25a823..bff1175b 100644\n> --- a/src/py/cam/cam_qt.py\n> +++ b/src/py/cam/cam_qt.py\n> @@ -184,12 +184,7 @@ class QtRenderer:\n> windows = []\n> \n> for ctx in self.contexts:\n> - camera = ctx['camera']\n> -\n> for stream in ctx['streams']:\n> - fmt = stream.configuration.pixel_format\n> - size = stream.configuration.size\n> -\n> window = MainWindow(ctx, stream)\n> window.setAttribute(QtCore.Qt.WA_ShowWithoutActivating)\n> window.show()\n> @@ -199,10 +194,10 @@ class QtRenderer:\n> \n> def run(self):\n> camnotif = QtCore.QSocketNotifier(self.cm.efd, QtCore.QSocketNotifier.Read)\n> - camnotif.activated.connect(lambda x: self.readcam())\n> + camnotif.activated.connect(lambda _: self.readcam())\n> \n> keynotif = QtCore.QSocketNotifier(sys.stdin.fileno(), QtCore.QSocketNotifier.Read)\n> - keynotif.activated.connect(lambda x: self.readkey())\n> + keynotif.activated.connect(lambda _: self.readkey())\n> \n> print('Capturing...')\n> \n> @@ -292,9 +287,6 @@ class MainWindow(QtWidgets.QWidget):\n> def buf_to_qpixmap(self, stream, fb):\n> with fb.mmap() as mfb:\n> cfg = stream.configuration\n> - w = cfg.size.width\n> - h = cfg.size.height\n> - pitch = cfg.stride\n> \n> if cfg.pixel_format == libcam.formats.MJPEG:\n> img = Image.open(BytesIO(mfb.planes[0]))\n> diff --git a/src/py/cam/cam_qtgl.py b/src/py/cam/cam_qtgl.py\n> index 4bbcda6c..3fb7dde3 100644\n> --- a/src/py/cam/cam_qtgl.py\n> +++ b/src/py/cam/cam_qtgl.py\n> @@ -5,16 +5,11 @@ from PyQt5 import QtCore, QtWidgets\n> from PyQt5.QtCore import Qt\n> \n> import math\n> -import numpy as np\n> import os\n> import sys\n> \n> os.environ['PYOPENGL_PLATFORM'] = 'egl'\n> \n> -import OpenGL\n> -# OpenGL.FULL_LOGGING = True\n> -\n> -from OpenGL import GL as gl\n> from OpenGL.EGL.EXT.image_dma_buf_import import *\n> from OpenGL.EGL.KHR.image import *\n> from OpenGL.EGL.VERSION.EGL_1_0 import *\n> @@ -149,10 +144,10 @@ class QtRenderer:\n> \n> def run(self):\n> camnotif = QtCore.QSocketNotifier(self.state['cm'].efd, QtCore.QSocketNotifier.Read)\n> - camnotif.activated.connect(lambda x: self.readcam())\n> + camnotif.activated.connect(lambda _: self.readcam())\n> \n> keynotif = QtCore.QSocketNotifier(sys.stdin.fileno(), QtCore.QSocketNotifier.Read)\n> - keynotif.activated.connect(lambda x: self.readkey())\n> + keynotif.activated.connect(lambda _: self.readkey())\n> \n> print('Capturing...')\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E06DBD161\n\tfor ;\n\tThu, 26 May 2022 15:25:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57BB8611BF;\n\tThu, 26 May 2022 17:25:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B14B660DB0\n\tfor ;\n\tThu, 26 May 2022 17:25:49 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [37.120.212.14])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA53F496;\n\tThu, 26 May 2022 17:25:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653578751;\n\tbh=n0zEdd8SAkFqn0pCfOLZ+FqNcHeSyQjHXS7NucQBq9M=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0PQ9mSbkbxNsm018ZFRi5PCw/ZXKIttIiyZs1ioeQzvk6dN+sphZJZEuZzmxSirkO\n\tVny23G6jUsMGFW6PGgPNLYRdBqnJrV3zkb18tM2gEDGF7SweWz6yyxPEMMvxMtUDA8\n\tRV08ju/dG6XgBDVd5K2+CZQ3J/EB5UIkOmGtkQPbUEqZgSzN6gv8ZgxgaCGR7nHzl2\n\tqDJM8i89/QeKG2h9bINVMsglITe5MCW1GPEk0LVGLbjH8JWVWnQBQ9DhCD+Juy/E2i\n\tEUSkY01a6oUdq3d98f++48pMlqMgUbwsMcIgRA9cYtVRb1yJSnShHuN8o4DSVlQmeQ\n\t/JGhApcnh5U1A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653578749;\n\tbh=n0zEdd8SAkFqn0pCfOLZ+FqNcHeSyQjHXS7NucQBq9M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vOUBauVAPhaLUu5sjqYIrvvPT8OCRhMqz23WbmcaH+rx8MXmJwgFN+1t+31SCvlQi\n\tRIunFlrzTI+wuI+0jZdJhDOxmLTM28kxJS49IfmnT2SSMo9SVO0PoavVeN7id5PnQ+\n\tNDdbK/mmSzcYXoFycdF8rRzi1q9kPcWFBG0qW19A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vOUBauVA\"; dkim-atps=neutral","Date":"Thu, 26 May 2022 18:25:42 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220524114610.41848-1-tomi.valkeinen@ideasonboard.com>\n\t<20220524114610.41848-4-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220524114610.41848-4-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 03/19] py: cam: Cleanups","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]