[{"id":23153,"web_url":"https://patchwork.libcamera.org/comment/23153/","msgid":"","date":"2022-05-25T23:25:23","subject":"Re: [libcamera-devel] [libcamera-devel 4/5] ipa: rkisp1: Add ov5640\n\tconfiguration file","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Florian,\n\nThank you for the patch.\n\n\"tuning file\" in the subject line.\n\nOn Mon, May 23, 2022 at 11:24:34AM +0200, Florian Sylvestre via libcamera-devel wrote:\n> Add the ov5640 tuning file containing default values for 'black level\n> correction' algorithm.\n> \n> Signed-off-by: Florian Sylvestre \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/data/meson.build | 8 ++++++++\n> src/ipa/rkisp1/data/ov5640.yaml | 8 ++++++++\n> src/ipa/rkisp1/meson.build | 1 +\n> 3 files changed, 17 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/meson.build\n> create mode 100644 src/ipa/rkisp1/data/ov5640.yaml\n> \n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> new file mode 100644\n> index 00000000..2656bb2e\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +conf_files = files([\n> + 'ov5640.yaml',\n> +])\n> +\n> +install_data(conf_files,\n> + install_dir : ipa_data_dir / 'rkisp1')\n> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\n> new file mode 100644\n> index 00000000..d8e56463\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/ov5640.yaml\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +---\n> +BlackLevelCorrection:\n> + R: 256\n> + Gr: 256\n> + Gb: 256\n> + B: 256\n> +...\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index 8c822fbb..ccb84b27 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> subdir('algorithms')\n> +subdir('data')\n> \n> ipa_name = 'ipa_rkisp1'\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BEFAABD160\n\tfor ;\n\tWed, 25 May 2022 23:25:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08B2660422;\n\tThu, 26 May 2022 01:25:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D2A460422\n\tfor ;\n\tThu, 26 May 2022 01:25:28 +0200 (CEST)","from pendragon.ideasonboard.com (ip-109-40-242-63.web.vodafone.de\n\t[109.40.242.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CACA0496;\n\tThu, 26 May 2022 01:25:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653521130;\n\tbh=nRO7ieOAiaS3zCdfmg+VoEakqMCZ/l3xQ9QShIhbhUU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yjG3LZyeJsWMpevPJ5/OkOIjRBO3We6JoweMJi5+sPLphnJ1rJpdN9IBnFCRCEDsF\n\t9SSrM3Hi/873uX2cPuCe72KCs7dyWcy8v0cEX7lRDoDX/tvNNQwGbgg9mdQTWwZw5o\n\tg6x0DlgIj1HTjL4hvWmUYJw2v6JhEbTjVqLZ7HWyx8br3cK5Nk+BpUrHD9vkJcNABK\n\tyvBIIeKwCDMbWSw/X3NKdpb0QhRSqs90a9Bd/MXYU5hd101RlQJzu/l5KUtX66e4Hv\n\ttdFZYmu+AVLQYiPRdHI6jm+4OgcTfznoELmdTFrexe+84fFXkYxWI7kkiWDAaaxc5m\n\t0m5S8l/LsPlSg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653521128;\n\tbh=nRO7ieOAiaS3zCdfmg+VoEakqMCZ/l3xQ9QShIhbhUU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YhbAgnCahaL+j1av5s+TeTlV4NEtnxSMhgOZZkwC3++iqvKrrgGdhCUN3x9x0Cj9O\n\t8RYq+dyPuIMBHdAlPS019cY9gOWczh2ne4aN7SdsgUEwYE77bguFUsdXyKAnVpegC3\n\t0aGnbp02EVfoSKDlitxW5p7LpcfsxWfstTkIcR64="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YhbAgnCa\"; dkim-atps=neutral","Date":"Thu, 26 May 2022 02:25:23 +0300","To":"Florian Sylvestre ","Message-ID":"","References":"<20220523092435.475510-1-fsylvestre@baylibre.com>\n\t<20220523092435.475510-5-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220523092435.475510-5-fsylvestre@baylibre.com>","Subject":"Re: [libcamera-devel] [libcamera-devel 4/5] ipa: rkisp1: Add ov5640\n\tconfiguration file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23184,"web_url":"https://patchwork.libcamera.org/comment/23184/","msgid":"<20220527082732.GI4117012@pyrite.rasen.tech>","date":"2022-05-27T08:27:32","subject":"Re: [libcamera-devel] [libcamera-devel 4/5] ipa: rkisp1: Add ov5640\n\tconfiguration file","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Florian,\n\nOn Mon, May 23, 2022 at 11:24:34AM +0200, Florian Sylvestre via libcamera-devel wrote:\n> Add the ov5640 tuning file containing default values for 'black level\n> correction' algorithm.\n> \n> Signed-off-by: Florian Sylvestre \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/data/meson.build | 8 ++++++++\n> src/ipa/rkisp1/data/ov5640.yaml | 8 ++++++++\n> src/ipa/rkisp1/meson.build | 1 +\n> 3 files changed, 17 insertions(+)\n> create mode 100644 src/ipa/rkisp1/data/meson.build\n> create mode 100644 src/ipa/rkisp1/data/ov5640.yaml\n> \n> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build\n> new file mode 100644\n> index 00000000..2656bb2e\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/meson.build\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +conf_files = files([\n> + 'ov5640.yaml',\n> +])\n> +\n> +install_data(conf_files,\n> + install_dir : ipa_data_dir / 'rkisp1')\n> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\n> new file mode 100644\n> index 00000000..d8e56463\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/data/ov5640.yaml\n> @@ -0,0 +1,8 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +---\n> +BlackLevelCorrection:\n> + R: 256\n> + Gr: 256\n> + Gb: 256\n> + B: 256\n> +...\n> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build\n> index 8c822fbb..ccb84b27 100644\n> --- a/src/ipa/rkisp1/meson.build\n> +++ b/src/ipa/rkisp1/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> subdir('algorithms')\n> +subdir('data')\n> \n> ipa_name = 'ipa_rkisp1'\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CDD7BD160\n\tfor ;\n\tFri, 27 May 2022 08:27:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C367633A1;\n\tFri, 27 May 2022 10:27:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEF3960415\n\tfor ;\n\tFri, 27 May 2022 10:27:38 +0200 (CEST)","from pyrite.rasen.tech (softbank036240126034.bbtec.net\n\t[36.240.126.34])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 640E730A;\n\tFri, 27 May 2022 10:27:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653640060;\n\tbh=91ts7dPTuNMZ/iIGqX3d/ohH8Ynro3ESKS233H4m47c=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EwTEQPTMNfNd+YWd8vh5SoLV4iVBDXAS4m+tvnz/oshydTD3o1HzQFqGwzf3ayWv3\n\trd1aH8xVMN/3qVCWrJm3zrQRUz4WnjxOCNoZQHrjC3gTMOS1wuSQFvy9I8c3e7xmFx\n\tw7kLbrGyzY/S8dVJcBj5AzeLbQaXzpR04QvfbKs3LnbQECethx8tjmQN6Of6u38BL/\n\tQVn3zxaCp99CGUmYQ8Yr2j+j5/R4cTdQ5ugHZPAywa5CJxbPU/li2JX37GS9z2uq6Y\n\tTi+n/trMKbqORfO51DcOrj2iJMoDhAq99GwwjaicXGAbr4miWR8VpTveYCugRRvk8v\n\t7hv8EZC5B8Wog==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653640058;\n\tbh=91ts7dPTuNMZ/iIGqX3d/ohH8Ynro3ESKS233H4m47c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OW6arBToUzLWutttWok7zF11TEtQdKXUlu7g2sIgSmlIJ4yywP/jqaKNDUf10uh0V\n\t3gmgwzkV1gFuHKf6o8WtT50fKdTvnFbSerRgsqGaFft8USx34zTzFTvgyb6QQ4Bi16\n\tYW0ujgqwlVQ/L6plkS9ku9gc36WkhLqsXhw1p3bU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OW6arBTo\"; dkim-atps=neutral","Date":"Fri, 27 May 2022 17:27:32 +0900","To":"Florian Sylvestre ","Message-ID":"<20220527082732.GI4117012@pyrite.rasen.tech>","References":"<20220523092435.475510-1-fsylvestre@baylibre.com>\n\t<20220523092435.475510-5-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220523092435.475510-5-fsylvestre@baylibre.com>","Subject":"Re: [libcamera-devel] [libcamera-devel 4/5] ipa: rkisp1: Add ov5640\n\tconfiguration file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]