{"id":16001,"url":"https://patchwork.libcamera.org/api/patches/16001/?format=json","web_url":"https://patchwork.libcamera.org/patch/16001/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220523092435.475510-2-fsylvestre@baylibre.com>","date":"2022-05-23T09:24:31","name":"[libcamera-devel,libcamera-devel,1/5] pipeline: rkisp1: Support sensor tuning file","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0d8a5d1a9514ca3786fb95fe440b62a1278bd0f6","submitter":{"id":123,"url":"https://patchwork.libcamera.org/api/people/123/?format=json","name":"Florian Sylvestre","email":"fsylvestre@baylibre.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16001/mbox/","series":[{"id":3133,"url":"https://patchwork.libcamera.org/api/series/3133/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3133","date":"2022-05-23T09:24:30","name":"Add configuration file support for rkisp1 blc algo","version":1,"mbox":"https://patchwork.libcamera.org/series/3133/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16001/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16001/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 617EFBD160\n\tfor ;\n\tMon, 23 May 2022 09:24:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1586A65665;\n\tMon, 23 May 2022 11:24:47 +0200 (CEST)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04E4A6565E\n\tfor ;\n\tMon, 23 May 2022 11:24:45 +0200 (CEST)","by mail-wr1-x435.google.com with SMTP id h14so20424211wrc.6\n\tfor ;\n\tMon, 23 May 2022 02:24:45 -0700 (PDT)","from BL087.. ([2a01:e34:eea9:e630:1bc6:bcdb:60b7:f1d3])\n\tby smtp.gmail.com with ESMTPSA id\n\tw22-20020a1cf616000000b003942a244eebsm8034250wmc.48.2022.05.23.02.24.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 23 May 2022 02:24:44 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653297887;\n\tbh=cUEB+NwwZLYKyjLZOzZxvMQapwWS39paO/S54zNivfg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tGKrBJIKZ9bEsT0mB9EyVthoHpm90eUgii4MKDytJ7Koi7JhFEWw4FvSljbCZQX/Y\n\to5yg55kybGjxITag7akNbOXyR5nIcZh1wIiWBknS+lrGD46YiNj+iS0IHkKn19nyyM\n\tXJiholTPIyOq+lCQW85ZvF07LPqPaD0pm9hBIJgQamFfuYsIKq779kx7VGHzs3dwVF\n\tq0K4n8eJkUpoHpKxGuSsHNc20J4TDVVHK14/xObLSQivyk6ho15DLx8LZZAB6Eaa9F\n\ttyahbIepatsuNATVWru0m4bSyQX7hxNeus8V3C/WDxnC2JFM6srYu+yIxXP3vhgSoG\n\tb6wH4apbJL8LQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=c87SE8ICoMPP/SKr7cW6b2KTo2OKSmdf4bbsdFw7VKQ=;\n\tb=AMINoZDifmeUtxSJyk5XyPShUHIn2kgihOMb0AxQxpJ1xP7LVaovODx7GXuKCdXkBZ\n\tDmddGjWnr1F6mgTgLXlckXpAL6g5+jTydGRs/NI9DcrDbId//8e2Z721lN/XNmiHWuVw\n\tqlJUnLoueHG9sEWEYOvffUU47jRh8rFL40wVFc+ykCrwT2eOkjzPFSPhRARA63HDVYSg\n\ttAQknMMBOjcNkPkIUlYFVpRH7KH/rW1QpfaddwxnihGbnkkDYXtr/YYw5ssdx6iRafKT\n\tpWveHlvizAQpZVxVV213yRWvXgSFIWDQEDZ44yStem2vftKcbykZleVVI22vFwhM2sDI\n\tPG4A=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"AMINoZDi\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=c87SE8ICoMPP/SKr7cW6b2KTo2OKSmdf4bbsdFw7VKQ=;\n\tb=i1GRHSHj9mquxojTbcKPqJNu4m4P+bXkjnliPY8XxGAHL1oUifaHptvLoxeZPljRcd\n\tKW0iTegdlstbn/RMiA/a1s9wwCQ8PwIjrLxV7Xuq4JkN5kkULrz+KL3mSOnnu53U6t7G\n\tSFGSf8LLZuhVLZ69d6slaO/7jcVHoQpQ6gGzBnErWQ42CgFUM37LZzkYfBoGQBXoK1wS\n\toGWR1U+nrzxbvBCyhPFnaue2rITnKbqfY8a+4n4EFiSHG3YvOQQMBtlsUxBP9WyNWCVP\n\txgQlfk/XAWeRuc/YDEGAqN2NkAJoWxor7k+22TRIE+YDYdyr2fFpeMQENf6UqBT2p7R9\n\tLeeg==","X-Gm-Message-State":"AOAM533kny7t+Nk9djAnPHHJryYdk+CCMlzq87n434aUhu1Fi1rQo8Iv\n\t1ob8NCEI3+WCZdNFP8MSWoejVN6/d5uhYg==","X-Google-Smtp-Source":"ABdhPJxSXAq8EDVhF5k8Hj4OFcdR079KOc+sg0GZXB1LICqfdA4NnFlMsjfk6CgT8sqDGudaGm0TMA==","X-Received":"by 2002:a5d:4a82:0:b0:20d:3b9:740e with SMTP id\n\to2-20020a5d4a82000000b0020d03b9740emr17725049wrq.718.1653297884534; \n\tMon, 23 May 2022 02:24:44 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 23 May 2022 11:24:31 +0200","Message-Id":"<20220523092435.475510-2-fsylvestre@baylibre.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220523092435.475510-1-fsylvestre@baylibre.com>","References":"<20220523092435.475510-1-fsylvestre@baylibre.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [libcamera-devel 1/5] pipeline: rkisp1: Support\n\tsensor tuning file","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Florian Sylvestre via libcamera-devel\n\t","Reply-To":"Florian Sylvestre ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Allow the usage of a Yaml configuration file that is either defined by\nthe sensor name (sensor_name.yaml) or defined by\nLIBCAMERA_RKISP1_TUNING_FILE environment variable.\n\nSigned-off-by: Florian Sylvestre \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 4b3d2cf7..865c4ab0 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -322,7 +322,18 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n \tipa_->paramsBufferReady.connect(this, &RkISP1CameraData::paramFilled);\n \tipa_->metadataReady.connect(this, &RkISP1CameraData::metadataReady);\n \n-\tint ret = ipa_->init(IPASettings{ \"\", sensor_->model() }, hwRevision);\n+\t/*\n+\t * The configuration (tuning file) is made from the sensor name unless\n+\t * the environment variable overrides it.\n+\t */\n+\tstd::string configurationFile;\n+\tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n+\tif (!configFromEnv || *configFromEnv == '\\0')\n+\t\tconfigurationFile = ipa_->configurationFile(sensor_->model() + \".yaml\");\n+\telse\n+\t\tconfigurationFile = std::string(configFromEnv);\n+\n+\tint ret = ipa_->init({ configurationFile, sensor_->model() }, hwRevision);\n \tif (ret < 0) {\n \t\tLOG(RkISP1, Error) << \"IPA initialization failure\";\n \t\treturn ret;\n","prefixes":["libcamera-devel","libcamera-devel","1/5"]}