[{"id":23100,"web_url":"https://patchwork.libcamera.org/comment/23100/","msgid":"<165303225507.368702.15858339459165089407@Monstersaurus>","date":"2022-05-20T07:37:35","subject":"Re: [libcamera-devel] [PATCH] android: Drop gcc 7 compatibility","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-05-19 19:54:04)\n> Now that we have dropped gcc 7 support, remove the compatibility with\n> gcc versions older than 8 that implemented the filesystem API in the\n> std::experimental namespace.\n> \n> Signed-off-by: Laurent Pinchart \n\nThis sounds good.\n\nWasn't there some (potential) task blocked about using \nbecause of the android hal, which would now be unblocked?\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_hal_config.cpp | 7 -------\n> 1 file changed, 7 deletions(-)\n> \n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index 29e506ff5e28..28072cb86285 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -6,14 +6,7 @@\n> */\n> #include \"camera_hal_config.h\"\n> \n> -#if defined(_GLIBCXX_RELEASE) && _GLIBCXX_RELEASE < 8\n> -#include \n> -namespace std {\n> -namespace filesystem = std::experimental::filesystem;\n> -}\n> -#else\n> #include \n> -#endif\n> #include \n> #include \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A7C3C3256\n\tfor ;\n\tFri, 20 May 2022 07:37:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A056165660;\n\tFri, 20 May 2022 09:37:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B27165653\n\tfor ;\n\tFri, 20 May 2022 09:37:38 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE18C332;\n\tFri, 20 May 2022 09:37:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653032259;\n\tbh=rBVhv5lAAzvoTPTQXyKG4LIfa2Zl3iWs55p8/4VU2uk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=nmio0qJDXqbNdV+E3xSW9N56qndKUYt/wGTqFEXIMsKxyRpb+R9L8mlEqbd1fkvnU\n\tqgfyr3UhoAkaxALU0OXoojwLkn7uEgfDSusR+bQ3n23NQwxA1EnWl9rp+hsoeKfcUU\n\trK1oSXga3j5TKRQSehNfLI1Qk7HPrntqOjlh2wBEtVOLVNyzEWd391CECw1hBPibht\n\tpqFZeao7/NT9wH+6QSMsEc1xFdkI47tAM0bVQ1mMIkVJ3LwPSq1K47R/RQTgohbuN7\n\tJG1nReYKwOy3mbG379/7pGL7hJ3w/VDGQAFTwP3mTLqAn8B8kLnPqIgEENN7BeUD3U\n\tMI+/27YMcgx0A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653032257;\n\tbh=rBVhv5lAAzvoTPTQXyKG4LIfa2Zl3iWs55p8/4VU2uk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=jLCnjoz1FqFyDIOpsFZV3oX+Nlfrz6f4gkZVHaMBDboiFXdnLLryMXk5NHcfxxcOb\n\tM7hKm2aj2E+YA0GpU+e67O7BvBW8sRqEOAoEXUXq1upQYpi8wQewXN+uWvoEomaics\n\t7MkoVMRX58HtspmjV1KjsPGoZncSpYdCnqIkmF4I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jLCnjoz1\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220519185404.16502-1-laurent.pinchart@ideasonboard.com>","References":"<20220519185404.16502-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 20 May 2022 08:37:35 +0100","Message-ID":"<165303225507.368702.15858339459165089407@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] android: Drop gcc 7 compatibility","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23101,"web_url":"https://patchwork.libcamera.org/comment/23101/","msgid":"","date":"2022-05-20T07:40:27","subject":"Re: [libcamera-devel] [PATCH] android: Drop gcc 7 compatibility","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 20, 2022 at 08:37:35AM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-05-19 19:54:04)\n> > Now that we have dropped gcc 7 support, remove the compatibility with\n> > gcc versions older than 8 that implemented the filesystem API in the\n> > std::experimental namespace.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> This sounds good.\n> \n> Wasn't there some (potential) task blocked about using \n> because of the android hal, which would now be unblocked?\n\nHmmmm... I recall something indeed. Was it that filesystem isn't\navailable on Android ? That would require us to stop using\nstd::filesystem, and this patch doesn't go in the opposite direction.\n\n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > src/android/camera_hal_config.cpp | 7 -------\n> > 1 file changed, 7 deletions(-)\n> > \n> > diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> > index 29e506ff5e28..28072cb86285 100644\n> > --- a/src/android/camera_hal_config.cpp\n> > +++ b/src/android/camera_hal_config.cpp\n> > @@ -6,14 +6,7 @@\n> > */\n> > #include \"camera_hal_config.h\"\n> > \n> > -#if defined(_GLIBCXX_RELEASE) && _GLIBCXX_RELEASE < 8\n> > -#include \n> > -namespace std {\n> > -namespace filesystem = std::experimental::filesystem;\n> > -}\n> > -#else\n> > #include \n> > -#endif\n> > #include \n> > #include \n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2060C3256\n\tfor ;\n\tFri, 20 May 2022 07:40:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D73A65660;\n\tFri, 20 May 2022 09:40:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9190B65653\n\tfor ;\n\tFri, 20 May 2022 09:40:33 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E051B5A9;\n\tFri, 20 May 2022 09:40:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653032435;\n\tbh=BkR+ehgvLVt9Y8ZgElSsxQEvyh1eLSGw149YUXIaZ6A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=VUdeDIKNh8XIGikyjxBaZ84jqMITwEPYo+tAy3+v5x/a7VWqjbYqJ4CxQqiXHHTgH\n\t/SE0Vq4bTV54NPez5GTPPq3QnNLslp+viRWRlPShdcZtyMllHUJor2GJOXeMkCMtJj\n\tTO1eP2M7lO3B3sXCN35O5MnRum+HtGQFEP0qTTDyzNGTM3gnU7N8tQa5MlU4+zaV1G\n\thBqHhTFS3MtOtgTf3C1R4fMjX0y8yCciMgmqcPa9Ff7QGdUUFKYebsQz2TNwmANJUG\n\ti603W4HWpa1A2LrK8WmVq09FL++W5kUXvOjZrmVm0RvD9n7uDwgl6oZ6bIDQv/3TH2\n\tcNw6GFrBQDfcw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653032433;\n\tbh=BkR+ehgvLVt9Y8ZgElSsxQEvyh1eLSGw149YUXIaZ6A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UPzKTsY0u3PxDlGTDGph9rBzY3UfPsrXRCr6dddvhSZuarl9sPK8VaU98z93WpxSm\n\ts1f0TjKrhzcas0p7qQaAvnc3lQ8tZjYi2Ch1kaqJjfFWqWFNSoUYkRu7/vtr9V+RUT\n\tYX3FmgrUH/vHkhTvYbXY+cTuT1ne+blNfEBB9n7A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UPzKTsY0\"; dkim-atps=neutral","Date":"Fri, 20 May 2022 10:40:27 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220519185404.16502-1-laurent.pinchart@ideasonboard.com>\n\t<165303225507.368702.15858339459165089407@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165303225507.368702.15858339459165089407@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] android: Drop gcc 7 compatibility","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23102,"web_url":"https://patchwork.libcamera.org/comment/23102/","msgid":"<20220520074046.GF1875478@pyrite.rasen.tech>","date":"2022-05-20T07:40:46","subject":"Re: [libcamera-devel] [PATCH] android: Drop gcc 7 compatibility","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, May 19, 2022 at 09:54:04PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Now that we have dropped gcc 7 support, remove the compatibility with\n> gcc versions older than 8 that implemented the filesystem API in the\n> std::experimental namespace.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_hal_config.cpp | 7 -------\n> 1 file changed, 7 deletions(-)\n> \n> diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\n> index 29e506ff5e28..28072cb86285 100644\n> --- a/src/android/camera_hal_config.cpp\n> +++ b/src/android/camera_hal_config.cpp\n> @@ -6,14 +6,7 @@\n> */\n> #include \"camera_hal_config.h\"\n> \n> -#if defined(_GLIBCXX_RELEASE) && _GLIBCXX_RELEASE < 8\n> -#include \n> -namespace std {\n> -namespace filesystem = std::experimental::filesystem;\n> -}\n> -#else\n> #include \n> -#endif\n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27985C0F2A\n\tfor ;\n\tFri, 20 May 2022 07:40:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB65865665;\n\tFri, 20 May 2022 09:40:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C99365653\n\tfor ;\n\tFri, 20 May 2022 09:40:50 +0200 (CEST)","from pyrite.rasen.tech (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD90F5A9;\n\tFri, 20 May 2022 09:40:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653032451;\n\tbh=teU9fYzDAtpVy9tRZ8+DE5EgJUjJdNq5YsNAtwHvi6Q=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hCNazlGnDHrbbBs9BRZsaKp6i+8rT7jAVn7Micm3WXy/FeButl82H9YQ33aV1ijS1\n\tDdqf+ms2M+yNYKHWUbM0Tm62HJL+bxKH0kQdjDq4ej2WQEodnfiU1VDlMFz2WN2KSs\n\tUF0DXA//rzmQRIXwxUB6Z4yL4aaOrBPGcPW+Xk6SA3O3WQ7/OdxFU/F+/LkwTWLmBw\n\t5vs5wO3fu42OwEhw9drG9PQcdstpba1KEjvFZER7ieJyxpFMl/OaGtHIyF4IERa5Qx\n\ttfjaATvOm0IzyMKGJfTOjx9ELtg+Cwh9qXnQmgTDu1S7kFFcnS6msbORomDlUyYGxn\n\tg/kefQXDK86Bw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653032449;\n\tbh=teU9fYzDAtpVy9tRZ8+DE5EgJUjJdNq5YsNAtwHvi6Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cf+jVp4IAGoCwuZLXhLlby4ZoWdk82iXbVSc3hi8S+8pSUS2DYTz9c/c+TIIiGz4H\n\tHea6qQRB3FN7FK7zbbVYK22bNVWzjiqmwkonq6GOOdXA0ddX4W6aGfx4JDj6muJK2E\n\t+HZNXpJUGTCkjkvrK4icmrT6C74JkSaKv3tV9SXY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cf+jVp4I\"; dkim-atps=neutral","Date":"Fri, 20 May 2022 09:40:46 +0200","To":"Laurent Pinchart ","Message-ID":"<20220520074046.GF1875478@pyrite.rasen.tech>","References":"<20220519185404.16502-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220519185404.16502-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: Drop gcc 7 compatibility","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]