[{"id":23088,"web_url":"https://patchwork.libcamera.org/comment/23088/","msgid":"","date":"2022-05-19T10:51:21","subject":"Re: [libcamera-devel] [PATCH 4/5] py: Fix SceneFlicker enum values","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, May 19, 2022 at 01:33:46PM +0300, Tomi Valkeinen wrote:\n> Stripping 'SceneFlicker' prefix from the enum value names leads to\n> '50Hz' and '60Hz', which are not valid names. So add another heuristics\n> to keep the prefix for SceneFlicker.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/gen-py-control-enums.py | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/py/libcamera/gen-py-control-enums.py b/src/py/libcamera/gen-py-control-enums.py\n> index dcc28b1a..6b2b5362 100755\n> --- a/src/py/libcamera/gen-py-control-enums.py\n> +++ b/src/py/libcamera/gen-py-control-enums.py\n> @@ -42,6 +42,9 @@ def generate_py(controls):\n> \n> if name == 'LensShadingMapMode':\n> prefix = 'LensShadingMapMode'\n> + elif name == 'SceneFlicker':\n> + # If we strip the prefix, we would get '50Hz', which is illegal name\n> + prefix = ''\n> else:\n> prefix = find_common_prefix([e['name'] for e in enum])\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53B33C0F2A\n\tfor ;\n\tThu, 19 May 2022 10:51:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10A0E65663;\n\tThu, 19 May 2022 12:51:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB8F660420\n\tfor ;\n\tThu, 19 May 2022 12:51:27 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60B41A16;\n\tThu, 19 May 2022 12:51:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652957489;\n\tbh=LRK2EImFzc5m7y6d5IPRS2cx5oRoU79EhMVw14Rm+RM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cVebHJvQhkNpYYPjwyJ5uaJEMnSy3MIWV4kDbn+dqLlsQYa3dCJpPDFru6WzsCiFh\n\tyrEYwcRTH+qroy3XtRULGl+HSv5M1U7a9bPVLMFalh5qpPVtpJy1/rrVhECEgEegmg\n\tyrL7xr2faN7R9M8w09BAjskjhINYO2cny9m53YEBA2y0E31zwh+ytTMzZbYXHOWKwB\n\tyfM4YZ2E4ZeeLLfp2ilVNP4dQJfov34M51lcAr+FLf3UV/6kCqYsR8itnm03NU6lz9\n\tsDRrQjlScBqkSXZsaa3XNmVzSGBl3vFhpCDjslTdep0SCorRaB3YqoTonN5U6kO5sX\n\teOiHRKJgh4BBw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652957487;\n\tbh=LRK2EImFzc5m7y6d5IPRS2cx5oRoU79EhMVw14Rm+RM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=acMj3w8zbb5K7cJPNdJlc56hCnRo88556ddIZGG0+fIL+9+QBgE81FZ3wPYg2jPRe\n\typ3txJbqarKywC4MkdC/wb6+/JK0yt/8KYRsNQSA3sHzxEtSqgb9c8OQMLWRoC6+j5\n\tv1wAvUw5a5KwfqbfWEV6wkaVKLzdhU3aLiqBHPIQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"acMj3w8z\"; dkim-atps=neutral","Date":"Thu, 19 May 2022 13:51:21 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220519103347.33295-1-tomi.valkeinen@ideasonboard.com>\n\t<20220519103347.33295-5-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220519103347.33295-5-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/5] py: Fix SceneFlicker enum values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]