[{"id":23084,"web_url":"https://patchwork.libcamera.org/comment/23084/","msgid":"","date":"2022-05-19T10:43:40","subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: formats: add\n\tmissing RGBX8888 info","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, May 19, 2022 at 10:06:20AM +0300, Tomi Valkeinen wrote:\n> Add missing RGBX8888 PixelFormatInfo.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> Changes to v1:\n> * Fixed the wrong v4l2 format\n> * Added entry to v4l2_pixelformat.cpp\n> \n> src/libcamera/formats.cpp | 13 +++++++++++++\n> src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> 2 files changed, 15 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 3e60ec7d..a4f27cd4 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -231,6 +231,19 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 1,\n> \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::RGBX8888, {\n> +\t\t.name = \"RGBX8888\",\n> +\t\t.format = formats::RGBX8888,\n> +\t\t.v4l2Formats = {\n> +\t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_BGRX32),\n> +\t\t\t.multi = V4L2PixelFormat(),\n> +\t\t},\n> +\t\t.bitsPerPixel = 32,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> \t{ formats::BGRX8888, {\n> \t\t.name = \"BGRX8888\",\n> \t\t.format = formats::BGRX8888,\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 1dd93baa..0b980a97 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -61,6 +61,8 @@ const std::map vpf2pf{\n> \t\t{ formats::BGRX8888, \"32-bit XRGB 8-8-8-8\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n> \t\t{ formats::XBGR8888, \"32-bit RGBX 8-8-8-8\" } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_BGRX32),\n> +\t\t{ formats::RGBX8888, \"32-bit XBGR 8-8-8-8\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32),\n> \t\t{ formats::ABGR8888, \"32-bit RGBA 8-8-8-8\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_ABGR32),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52A06C0F2A\n\tfor ;\n\tThu, 19 May 2022 10:43:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7DA5065665;\n\tThu, 19 May 2022 12:43:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE3EF60420\n\tfor ;\n\tThu, 19 May 2022 12:43:46 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 650E2A16;\n\tThu, 19 May 2022 12:43:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652957028;\n\tbh=avmz7j87UAqKW6OyESaY5aCz9+cTkB9N4kYB5t/E/ng=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=UNbTjIqyvdlIYQB3LgTTEqFF1k/fX0ik7a6gwbQQ0HYlwspd50c/K8oF7X6H8hHq2\n\t5ZOygG0b9PWMAFSIVgkEgNA4Jlo+LaxIxrGMk4LrUPgx0Y5uD0xyZpqCVwC35B12BH\n\tvGZQ8AOHVtXSGvI4GNF8afeAnT/s7W9ygH24JEcsq+sztSaqvucu7FSrvXhcc7HLJE\n\tGjR+rs0Monebjp4qCKDGoE2+ryG+deWr3ra3LOAI5wHD3G/xQAQ4JOuE+gvTe0FVFS\n\tWDe6zPRhJCkjbpcU+yaD8GSvHLLaKKCJLyQM9akQybCX5KCk/VKQqnJRxrpifnAQJs\n\t4mE4TxBaWkl2A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652957026;\n\tbh=avmz7j87UAqKW6OyESaY5aCz9+cTkB9N4kYB5t/E/ng=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KBSSBJ0mHk5lhCxHIesknsQadJUhhMs2qvr7G3wKoez6O6lIkZoVjEbEK1eEHQ6TK\n\t36cupH7NxQpyVEK/Fj4DOxQKgfeV4/inGvsSZGQ8cqV0JNEbC3zAKxgboJy40+si7m\n\t9d7E/+8WC8FrDyF8z26OyzxJCqfVc2gSme3V1jbg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KBSSBJ0m\"; dkim-atps=neutral","Date":"Thu, 19 May 2022 13:43:40 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220519070620.10373-1-tomi.valkeinen@ideasonboard.com>\n\t<20220519070620.10373-2-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220519070620.10373-2-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/2] libcamera: formats: add\n\tmissing RGBX8888 info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]