[{"id":23111,"web_url":"https://patchwork.libcamera.org/comment/23111/","msgid":"","date":"2022-05-20T10:24:51","subject":"Re: [libcamera-devel] [PATCH 4/5] cam: Add a --script option","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, May 18, 2022 at 07:19:20PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Add a \"--script\" option to the cam test application to allow specify a\n> capture script to be used to drive the capture session.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/cam/main.cpp | 4 ++++\n> src/cam/main.h | 1 +\n> 2 files changed, 5 insertions(+)\n> \n> diff --git a/src/cam/main.cpp b/src/cam/main.cpp\n> index fd3108b05d25..3428075c03dd 100644\n> --- a/src/cam/main.cpp\n> +++ b/src/cam/main.cpp\n> @@ -162,6 +162,10 @@ int CamApp::parseOptions(int argc, char *argv[])\n> \t\t\t \"Print the metadata for completed requests\",\n> \t\t\t \"metadata\", ArgumentNone, nullptr, false,\n> \t\t\t OptCamera);\n> +\tparser.addOption(OptCaptureScript, OptionString,\n> +\t\t\t \"Load a capture session configuration script from a file\\n\",\n\nStray \\n.\n\nI'd squash this with 5/5.\n\n> +\t\t\t \"script\", ArgumentRequired, \"script\", false,\n> +\t\t\t OptCamera);\n> \n> \toptions_ = parser.parse(argc, argv);\n> \tif (!options_.valid())\n> diff --git a/src/cam/main.h b/src/cam/main.h\n> index 2b2858084bb1..5ec20e1496eb 100644\n> --- a/src/cam/main.h\n> +++ b/src/cam/main.h\n> @@ -22,4 +22,5 @@ enum {\n> \tOptListControls = 256,\n> \tOptStrictFormats = 257,\n> \tOptMetadata = 258,\n> +\tOptCaptureScript = 259,\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24876C3256\n\tfor ;\n\tFri, 20 May 2022 10:24:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92F4465660;\n\tFri, 20 May 2022 12:24:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9FE760440\n\tfor ;\n\tFri, 20 May 2022 12:24:57 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D7D83E4;\n\tFri, 20 May 2022 12:24:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653042298;\n\tbh=oj/p+hdkkR/yj6IlHkHS+6bISBIdaLdYIOuIzSr8mxs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cgOaO2jZVHSFwjhfkYynqjP010iX6ZmUbtq2eBY8Qq2rgqQ+xBwiJji6Pt4Ca0qQl\n\tAmamwP1iwpFzNWLzvf0QUwNFw90R/FsTfBkaWGbVYgzC1wOoVumpb3pc6OP9z0nRa+\n\tEfZpWaOkV2BX6K3iV19YWuHkdIEtLdHwZa2M+f50nLYvbmg+nRNlFtUQTxJQAPNc/v\n\tVwZVzU1XCxZpuDsRtaSL2eU2gdeS0nlo/3DhCcUEDn0Wo5xwaksr1gJHBczsMYgoln\n\tqex371puglm9Zkf6GEDkxD3iswNDq/MS1s6FLhE5vdHJ67Mnkdj9EvTJTrataAFo63\n\tmGqWxkdWYyfkA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653042297;\n\tbh=oj/p+hdkkR/yj6IlHkHS+6bISBIdaLdYIOuIzSr8mxs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OohaPmA3ksL50LFHihcH8zc1OK5SAVSLBLKc+9ZhV5RnDroYs2v48bhzNnEMwTew6\n\tOk+UrmB8RgF6v16b+8ifsz5IwlYhVdhnGRS4FieWZWJjzFSLSZF+u7aCMNDPMsFco9\n\thOrduT/e8SEHyprnTMSt5TObWMeUGWqZm7+UrMpc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OohaPmA3\"; dkim-atps=neutral","Date":"Fri, 20 May 2022 13:24:51 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220518171921.244168-1-jacopo@jmondi.org>\n\t<20220518171921.244168-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220518171921.244168-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 4/5] cam: Add a --script option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]