[{"id":23110,"web_url":"https://patchwork.libcamera.org/comment/23110/","msgid":"","date":"2022-05-20T10:22:29","subject":"Re: [libcamera-devel] [PATCH 3/5] cam: Queue requests through\n\tCameraSession::queueRequest()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, May 18, 2022 at 07:19:19PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> The CameraSession::processRequest() frame completion handler currently\n> re-queues completed requests by calling Camera::queueRequests()\n> explicitely.\n> \n> In order to maintain the CameraSession::queuedRequest_ counter up to\n> date with the actual number of queued requests, call the\n> CameraSession::queueRequest() instead of operating the Camera directly.\n> \n> Signed-off-by: Jacopo Mondi \n\nThis looks right.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/cam/camera_session.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/cam/camera_session.cpp b/src/cam/camera_session.cpp\n> index 186072817367..a1b447235009 100644\n> --- a/src/cam/camera_session.cpp\n> +++ b/src/cam/camera_session.cpp\n> @@ -423,7 +423,7 @@ void CameraSession::processRequest(Request *request)\n> \t\treturn;\n> \n> \trequest->reuse(Request::ReuseBuffers);\n> -\tcamera_->queueRequest(request);\n> +\tqueueRequest(request);\n> }\n> \n> void CameraSession::sinkRelease(Request *request)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51FC0C3256\n\tfor ;\n\tFri, 20 May 2022 10:22:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 941B765660;\n\tFri, 20 May 2022 12:22:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C3F060440\n\tfor ;\n\tFri, 20 May 2022 12:22:36 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3E163E4;\n\tFri, 20 May 2022 12:22:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653042157;\n\tbh=2MISS6CfHc8Fq6g3/4MrOHSNgiuxM4h6XEmU/SdCywA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YnClrRmcrFJVxPqQrSv3wNnMzi/BFbPP0zH37nF0EIvnMuzC3DQs03KKYc+incghz\n\tu0zTN0HwdY6GsABSbVW1lmJyX/9OaixGjmLNO7AlxnQeR4ZBTotZovrjX4nGNpYnqm\n\tNfIQRj+ibRLWiDt75DIEyPX563k5pRewrqrZFWz60DcNHdQV3hisP5LmC+tkz6Zfbg\n\tG3JAZdLzYkk6tw17MuOdMMIgW+FKvgzekb9RU9MlJghfXwHNa/kaWJAuo+b0Pkv9NC\n\tkwwnZjyar1bVb/1aUFxU/11qomNGqPuP9BKoUwGC2M3v0vIlx0w7EFjPY3KQJiCTuT\n\tT3k5Hbpr3wW/w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653042156;\n\tbh=2MISS6CfHc8Fq6g3/4MrOHSNgiuxM4h6XEmU/SdCywA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WjjDyAhpNiVZTwyRHcj3rqaEZzpXj3rBDI2TzMac/NpT1gtru35W5yB7EI4eRedUV\n\tMivovn4ytEJD1fo6vbO+dnK+Xd5Skt8Aq2SXw8rZi2ZTzIWs/bhrCjT7Sda1Rwt00f\n\tY4euZtU1B1pJCT7DyPkaN8oO1QSw5ldG15+INGy4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WjjDyAhp\"; dkim-atps=neutral","Date":"Fri, 20 May 2022 13:22:29 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220518171921.244168-1-jacopo@jmondi.org>\n\t<20220518171921.244168-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220518171921.244168-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 3/5] cam: Queue requests through\n\tCameraSession::queueRequest()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]