{"id":15977,"url":"https://patchwork.libcamera.org/api/patches/15977/?format=json","web_url":"https://patchwork.libcamera.org/patch/15977/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220518171921.244168-4-jacopo@jmondi.org>","date":"2022-05-18T17:19:19","name":"[libcamera-devel,3/5] cam: Queue requests through CameraSession::queueRequest()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d8f576df54ce5fbb430a06289f70794ba02f5471","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15977/mbox/","series":[{"id":3125,"url":"https://patchwork.libcamera.org/api/series/3125/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3125","date":"2022-05-18T17:19:16","name":"cam: Add support for capture scripts","version":1,"mbox":"https://patchwork.libcamera.org/series/3125/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15977/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15977/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5D84C326C\n\tfor ;\n\tWed, 18 May 2022 17:19:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47F5B65663;\n\tWed, 18 May 2022 19:19:36 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2883865663\n\tfor ;\n\tWed, 18 May 2022 19:19:31 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 5D52C240002;\n\tWed, 18 May 2022 17:19:30 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652894376;\n\tbh=WcIU6SytRpLU14Pp8vq5u3xirFD8W77rkyjrHk1KLE8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wZbDO5NfJwhi6Dch6OTsParh9EkdaLc2xyEQpDHkdQC6dCpZhDkp5w/p3ngZB7F9q\n\taylvu/vr+nXKIraeP5iiKVfKtar+YYp2RltJKeQbAEQf45E6TzQ/2bxd2DyR12Dgbz\n\t2SjpwhXRom3+wZqn6CqUjIRxm2PJdDV/bIt3S2XgttF4YDlNeb/acM/cApU6sFp6u0\n\t/UjaElPEPsqx66kofmoHrQXmjTfcNUhXrnuQftsVqmZ2MJfGyRy71hb1Z5eNALqJnx\n\tTjyIGG32FV2jCtJpAcDyCNdutHgI3zY1CvRE3y7Okxvm7oCera2xzoSFR4GamNKn/h\n\tchSb9MqhAROVQ==","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 18 May 2022 19:19:19 +0200","Message-Id":"<20220518171921.244168-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220518171921.244168-1-jacopo@jmondi.org>","References":"<20220518171921.244168-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/5] cam: Queue requests through\n\tCameraSession::queueRequest()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraSession::processRequest() frame completion handler currently\nre-queues completed requests by calling Camera::queueRequests()\nexplicitely.\n\nIn order to maintain the CameraSession::queuedRequest_ counter up to\ndate with the actual number of queued requests, call the\nCameraSession::queueRequest() instead of operating the Camera directly.\n\nSigned-off-by: Jacopo Mondi \n---\n src/cam/camera_session.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/cam/camera_session.cpp b/src/cam/camera_session.cpp\nindex 186072817367..a1b447235009 100644\n--- a/src/cam/camera_session.cpp\n+++ b/src/cam/camera_session.cpp\n@@ -423,7 +423,7 @@ void CameraSession::processRequest(Request *request)\n \t\treturn;\n \n \trequest->reuse(Request::ReuseBuffers);\n-\tcamera_->queueRequest(request);\n+\tqueueRequest(request);\n }\n \n void CameraSession::sinkRelease(Request *request)\n","prefixes":["libcamera-devel","3/5"]}