{"id":15976,"url":"https://patchwork.libcamera.org/api/patches/15976/?format=json","web_url":"https://patchwork.libcamera.org/patch/15976/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220518171921.244168-3-jacopo@jmondi.org>","date":"2022-05-18T17:19:18","name":"[libcamera-devel,2/5] cam: Queue requests unconditionally","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"fa969fa0ee154bec96e73a2d78da237a18a45cb4","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15976/mbox/","series":[{"id":3125,"url":"https://patchwork.libcamera.org/api/series/3125/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3125","date":"2022-05-18T17:19:16","name":"cam: Add support for capture scripts","version":1,"mbox":"https://patchwork.libcamera.org/series/3125/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15976/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15976/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73FF0C3256\n\tfor ;\n\tWed, 18 May 2022 17:19:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC8F765665;\n\tWed, 18 May 2022 19:19:31 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30FE265656\n\tfor ;\n\tWed, 18 May 2022 19:19:30 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 85757240004;\n\tWed, 18 May 2022 17:19:29 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652894371;\n\tbh=JNaqr7MSYw0dzUfV1uFphmmHof9QCzSh+0d9Y9+SsPM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=IyfekSDhxq8QZ+hNe2+Ewjc7kApCAZpuoZx79fs8wcyfUmNJFr0ISkx7a+/VGQiTp\n\tuvQxlSK9N7g1Cw3SdL9D3n5BVzp7PnZ9Kod24W7oWgUdrPizvrHIAGpgvU2ZdNN/sO\n\t1FNmIsJ52wuMBHHnjm4Fs/guNLejHnDCRQkYG4iO3CZflKkIzTiPT4+NiWgdqvmYTQ\n\t0Neq+cQ0qZG8xzJ6bAeazdONm+OF9rOeclQCIxPlzgkph9HOiPi9MHl1gX91tMDQs6\n\tkII/0h2gxHEYYV9Dp/z1BExLvwP5/5FcrHj28TWdfPqtPYB6DMWIQiDyNDKU2pmKWJ\n\tXNcaZ3jTpmSmA==","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 18 May 2022 19:19:18 +0200","Message-Id":"<20220518171921.244168-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220518171921.244168-1-jacopo@jmondi.org>","References":"<20220518171921.244168-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/5] cam: Queue requests unconditionally","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CaptureSession::queueRequest() function increments the queueCount_\ncounter, which tracks the number of requests queued to the camera.\n\nThe number of queued requests is currently compared with the capture\nlimit which should instead only be compared with the number of captured\nframes, something which already happens in the\nCameraSession::processRequest() function.\n\nRemove the check and only compare the capture limit with the actual\nnumber of captured frames. If more requests than the frame capture\nlimits end up being queued to the Camera, they will be released on\nCamera::stop().\n\nSigned-off-by: Jacopo Mondi \n---\n src/cam/camera_session.cpp | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/src/cam/camera_session.cpp b/src/cam/camera_session.cpp\nindex 71e6bd605139..186072817367 100644\n--- a/src/cam/camera_session.cpp\n+++ b/src/cam/camera_session.cpp\n@@ -327,9 +327,6 @@ int CameraSession::startCapture()\n \n int CameraSession::queueRequest(Request *request)\n {\n-\tif (captureLimit_ && queueCount_ >= captureLimit_)\n-\t\treturn 0;\n-\n \tqueueCount_++;\n \n \treturn camera_->queueRequest(request);\n","prefixes":["libcamera-devel","2/5"]}