[{"id":23052,"web_url":"https://patchwork.libcamera.org/comment/23052/","msgid":"<YoT36rkEehlPlHF+@pendragon.ideasonboard.com>","date":"2022-05-18T13:43:06","subject":"Re: [libcamera-devel] [PATCH v3 15/18] py: rename pyxyz to py_xyz","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Wed, May 18, 2022 at 04:13:26PM +0300, Tomi Valkeinen wrote:\n> Having the underscore makes the names more readable, especially when\n> there are multiple words in the name.\n> \n> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/py/libcamera/meson.build                         | 10 +++++-----\n>  src/py/libcamera/{pyenums.cpp => py_enums.cpp}       |  2 +-\n>  ...ms_generated.cpp.in => py_enums_generated.cpp.in} |  2 +-\n>  src/py/libcamera/{pygeometry.cpp => py_geometry.cpp} |  2 +-\n>  src/py/libcamera/{pymain.cpp => py_main.cpp}         | 12 ++++++------\n>  5 files changed, 14 insertions(+), 14 deletions(-)\n>  rename src/py/libcamera/{pyenums.cpp => py_enums.cpp} (96%)\n>  rename src/py/libcamera/{pyenums_generated.cpp.in => py_enums_generated.cpp.in} (89%)\n>  rename src/py/libcamera/{pygeometry.cpp => py_geometry.cpp} (99%)\n>  rename src/py/libcamera/{pymain.cpp => py_main.cpp} (99%)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index de66bb48..55957252 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -13,21 +13,21 @@ pybind11_proj = subproject('pybind11')\n>  pybind11_dep = pybind11_proj.get_variable('pybind11_dep')\n>  \n>  pycamera_sources = files([\n> -    'pyenums.cpp',\n> -    'pygeometry.cpp',\n> -    'pymain.cpp',\n> +    'py_enums.cpp',\n> +    'py_geometry.cpp',\n> +    'py_main.cpp',\n>  ])\n>  \n>  gen_input_files = files([\n>      '../../libcamera/control_ids.yaml',\n> -    'pyenums_generated.cpp.in',\n> +    'py_enums_generated.cpp.in',\n>  ])\n>  \n>  gen_py_control_enums = files('gen-py-control-enums.py')\n>  \n>  generated_sources = custom_target('py_gen_controls',\n>                                    input : gen_input_files,\n> -                                  output : ['pyenums_generated.cpp'],\n> +                                  output : ['py_enums_generated.cpp'],\n>                                    command : [gen_py_control_enums, '-o', '@OUTPUT@', '@INPUT@'])\n>  \n>  pycamera_sources += generated_sources\n> diff --git a/src/py/libcamera/pyenums.cpp b/src/py/libcamera/py_enums.cpp\n> similarity index 96%\n> rename from src/py/libcamera/pyenums.cpp\n> rename to src/py/libcamera/py_enums.cpp\n> index b655e622..e55318f1 100644\n> --- a/src/py/libcamera/pyenums.cpp\n> +++ b/src/py/libcamera/py_enums.cpp\n> @@ -13,7 +13,7 @@ namespace py = pybind11;\n>  \n>  using namespace libcamera;\n>  \n> -void init_pyenums(py::module &m)\n> +void init_py_enums(py::module &m)\n>  {\n>  \tpy::enum_<StreamRole>(m, \"StreamRole\")\n>  \t\t.value(\"StillCapture\", StreamRole::StillCapture)\n> diff --git a/src/py/libcamera/pyenums_generated.cpp.in b/src/py/libcamera/py_enums_generated.cpp.in\n> similarity index 89%\n> rename from src/py/libcamera/pyenums_generated.cpp.in\n> rename to src/py/libcamera/py_enums_generated.cpp.in\n> index 6aaf4795..20e07528 100644\n> --- a/src/py/libcamera/pyenums_generated.cpp.in\n> +++ b/src/py/libcamera/py_enums_generated.cpp.in\n> @@ -15,7 +15,7 @@ namespace py = pybind11;\n>  \n>  using namespace libcamera;\n>  \n> -void init_pyenums_generated(py::module& m)\n> +void init_py_enums_generated(py::module& m)\n>  {\n>  ${enums}\n>  }\n> diff --git a/src/py/libcamera/pygeometry.cpp b/src/py/libcamera/py_geometry.cpp\n> similarity index 99%\n> rename from src/py/libcamera/pygeometry.cpp\n> rename to src/py/libcamera/py_geometry.cpp\n> index d77de144..84b0cb08 100644\n> --- a/src/py/libcamera/pygeometry.cpp\n> +++ b/src/py/libcamera/py_geometry.cpp\n> @@ -18,7 +18,7 @@ namespace py = pybind11;\n>  \n>  using namespace libcamera;\n>  \n> -void init_pygeometry(py::module &m)\n> +void init_py_geometry(py::module &m)\n>  {\n>  \tauto pyPoint = py::class_<Point>(m, \"Point\");\n>  \tauto pySize = py::class_<Size>(m, \"Size\");\n> diff --git a/src/py/libcamera/pymain.cpp b/src/py/libcamera/py_main.cpp\n> similarity index 99%\n> rename from src/py/libcamera/pymain.cpp\n> rename to src/py/libcamera/py_main.cpp\n> index ef3f157a..b05bbb22 100644\n> --- a/src/py/libcamera/pymain.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -130,15 +130,15 @@ static void handleRequestCompleted(Request *req)\n>  \t\tLOG(Fatal) << \"Unable to write to eventfd\";\n>  }\n>  \n> -void init_pyenums(py::module &m);\n> -void init_pyenums_generated(py::module &m);\n> -void init_pygeometry(py::module &m);\n> +void init_py_enums(py::module &m);\n> +void init_py_enums_generated(py::module &m);\n> +void init_py_geometry(py::module &m);\n>  \n>  PYBIND11_MODULE(_libcamera, m)\n>  {\n> -\tinit_pyenums(m);\n> -\tinit_pyenums_generated(m);\n> -\tinit_pygeometry(m);\n> +\tinit_py_enums(m);\n> +\tinit_py_enums_generated(m);\n> +\tinit_py_geometry(m);\n>  \n>  \t/* Forward declarations */\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E961C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 May 2022 13:43:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A6C66565B;\n\tWed, 18 May 2022 15:43:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7764B65656\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 May 2022 15:43:14 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F5261BBB;\n\tWed, 18 May 2022 15:43:13 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652881396;\n\tbh=bzXbGcEDNtBcS/LBZU3XukGT0yrBybT5lWu31MSkAEo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gm63tOPUd4WJEvlFl7eP0kVaSltiV6igZA920PcNpJud0fgoW15chpXIYTQx/HsCq\n\tioD09QD6gxuOtik2QYhgdPjT8HAYtpUU69p5ZUh3j9zGkyyczi12N+e0q8VootpAkt\n\tw544rRpOo3p8zGAWjPVv7M72uC11EMSazZZYr52UylYIB5d53UiAgvP+hGuTR/vs5Y\n\tRvzm3S8LCUlpUJV++k7ZqTLNvbAWkl3h7bt3D72gIIsrDUaejPU/21Hd0FawGzRi/X\n\tfAf+Bk2BNqX82QiaDjN8HwUzwL9FmwHf0jL5Jvp1nDCAXJSYuzOjrxFaikAKwLoEvc\n\tv+jNeJrv6Llfw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652881394;\n\tbh=bzXbGcEDNtBcS/LBZU3XukGT0yrBybT5lWu31MSkAEo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CFqy9ZZLTWlQDomcrOY44h8fDjcuA4h62jHFbIxVD+/nKJDhdn+1INd8AtQaHfFKl\n\thRf/ojovNuHiLKVrpR68JGOMaceIqE/rbV8c+kmGQDYOJgyUvdao0Sjth/4hWY9MxP\n\tQVthrpO5pvbLCF+joLb8N5iCTh17KLmAHavU3GeA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CFqy9ZZL\"; dkim-atps=neutral","Date":"Wed, 18 May 2022 16:43:06 +0300","To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Message-ID":"<YoT36rkEehlPlHF+@pendragon.ideasonboard.com>","References":"<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518131329.66994-16-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220518131329.66994-16-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 15/18] py: rename pyxyz to py_xyz","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23059,"web_url":"https://patchwork.libcamera.org/comment/23059/","msgid":"<165288300258.368702.10617116332860769874@Monstersaurus>","date":"2022-05-18T14:10:02","subject":"Re: [libcamera-devel] [PATCH v3 15/18] py: rename pyxyz to py_xyz","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2022-05-18 14:13:26)\n> Having the underscore makes the names more readable, especially when\n> there are multiple words in the name.\n> \n\nFine with me, is this going to break users of pycamera already? I.e.\ndoes picamera2 need a new rebase on top of this? If so - we should\nhighlight this to RPi.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n> ---\n>  src/py/libcamera/meson.build                         | 10 +++++-----\n>  src/py/libcamera/{pyenums.cpp => py_enums.cpp}       |  2 +-\n>  ...ms_generated.cpp.in => py_enums_generated.cpp.in} |  2 +-\n>  src/py/libcamera/{pygeometry.cpp => py_geometry.cpp} |  2 +-\n>  src/py/libcamera/{pymain.cpp => py_main.cpp}         | 12 ++++++------\n>  5 files changed, 14 insertions(+), 14 deletions(-)\n>  rename src/py/libcamera/{pyenums.cpp => py_enums.cpp} (96%)\n>  rename src/py/libcamera/{pyenums_generated.cpp.in => py_enums_generated.cpp.in} (89%)\n>  rename src/py/libcamera/{pygeometry.cpp => py_geometry.cpp} (99%)\n>  rename src/py/libcamera/{pymain.cpp => py_main.cpp} (99%)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index de66bb48..55957252 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -13,21 +13,21 @@ pybind11_proj = subproject('pybind11')\n>  pybind11_dep = pybind11_proj.get_variable('pybind11_dep')\n>  \n>  pycamera_sources = files([\n> -    'pyenums.cpp',\n> -    'pygeometry.cpp',\n> -    'pymain.cpp',\n> +    'py_enums.cpp',\n> +    'py_geometry.cpp',\n> +    'py_main.cpp',\n>  ])\n>  \n>  gen_input_files = files([\n>      '../../libcamera/control_ids.yaml',\n> -    'pyenums_generated.cpp.in',\n> +    'py_enums_generated.cpp.in',\n>  ])\n>  \n>  gen_py_control_enums = files('gen-py-control-enums.py')\n>  \n>  generated_sources = custom_target('py_gen_controls',\n>                                    input : gen_input_files,\n> -                                  output : ['pyenums_generated.cpp'],\n> +                                  output : ['py_enums_generated.cpp'],\n>                                    command : [gen_py_control_enums, '-o', '@OUTPUT@', '@INPUT@'])\n>  \n>  pycamera_sources += generated_sources\n> diff --git a/src/py/libcamera/pyenums.cpp b/src/py/libcamera/py_enums.cpp\n> similarity index 96%\n> rename from src/py/libcamera/pyenums.cpp\n> rename to src/py/libcamera/py_enums.cpp\n> index b655e622..e55318f1 100644\n> --- a/src/py/libcamera/pyenums.cpp\n> +++ b/src/py/libcamera/py_enums.cpp\n> @@ -13,7 +13,7 @@ namespace py = pybind11;\n>  \n>  using namespace libcamera;\n>  \n> -void init_pyenums(py::module &m)\n> +void init_py_enums(py::module &m)\n>  {\n>         py::enum_<StreamRole>(m, \"StreamRole\")\n>                 .value(\"StillCapture\", StreamRole::StillCapture)\n> diff --git a/src/py/libcamera/pyenums_generated.cpp.in b/src/py/libcamera/py_enums_generated.cpp.in\n> similarity index 89%\n> rename from src/py/libcamera/pyenums_generated.cpp.in\n> rename to src/py/libcamera/py_enums_generated.cpp.in\n> index 6aaf4795..20e07528 100644\n> --- a/src/py/libcamera/pyenums_generated.cpp.in\n> +++ b/src/py/libcamera/py_enums_generated.cpp.in\n> @@ -15,7 +15,7 @@ namespace py = pybind11;\n>  \n>  using namespace libcamera;\n>  \n> -void init_pyenums_generated(py::module& m)\n> +void init_py_enums_generated(py::module& m)\n>  {\n>  ${enums}\n>  }\n> diff --git a/src/py/libcamera/pygeometry.cpp b/src/py/libcamera/py_geometry.cpp\n> similarity index 99%\n> rename from src/py/libcamera/pygeometry.cpp\n> rename to src/py/libcamera/py_geometry.cpp\n> index d77de144..84b0cb08 100644\n> --- a/src/py/libcamera/pygeometry.cpp\n> +++ b/src/py/libcamera/py_geometry.cpp\n> @@ -18,7 +18,7 @@ namespace py = pybind11;\n>  \n>  using namespace libcamera;\n>  \n> -void init_pygeometry(py::module &m)\n> +void init_py_geometry(py::module &m)\n>  {\n>         auto pyPoint = py::class_<Point>(m, \"Point\");\n>         auto pySize = py::class_<Size>(m, \"Size\");\n> diff --git a/src/py/libcamera/pymain.cpp b/src/py/libcamera/py_main.cpp\n> similarity index 99%\n> rename from src/py/libcamera/pymain.cpp\n> rename to src/py/libcamera/py_main.cpp\n> index ef3f157a..b05bbb22 100644\n> --- a/src/py/libcamera/pymain.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -130,15 +130,15 @@ static void handleRequestCompleted(Request *req)\n>                 LOG(Fatal) << \"Unable to write to eventfd\";\n>  }\n>  \n> -void init_pyenums(py::module &m);\n> -void init_pyenums_generated(py::module &m);\n> -void init_pygeometry(py::module &m);\n> +void init_py_enums(py::module &m);\n> +void init_py_enums_generated(py::module &m);\n> +void init_py_geometry(py::module &m);\n>  \n>  PYBIND11_MODULE(_libcamera, m)\n>  {\n> -       init_pyenums(m);\n> -       init_pyenums_generated(m);\n> -       init_pygeometry(m);\n> +       init_py_enums(m);\n> +       init_py_enums_generated(m);\n> +       init_py_geometry(m);\n>  \n>         /* Forward declarations */\n>  \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF2A7C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 May 2022 14:10:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 644D165659;\n\tWed, 18 May 2022 16:10:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1670865656\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 May 2022 16:10:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C2C2CE50;\n\tWed, 18 May 2022 16:10:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652883006;\n\tbh=qtua/lVIrliyLKZa8I3gZDkmNUCyWyBsDVxcGfP1QTI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=thmSFZbVAJoMZBQQPpLDaBFsqs3+Eq085evu54eilBbkxbCjGjYhvQ3Uad3odiAqK\n\tweolbUnJ7PC4wUeLX+GpIkTYGsLswvakSxLujOSxQ0IaQDU+24u2yXzpcO8aKeKLUj\n\tJ5U6HechL117RWww00lA7/QMjXyPL55phlMNO3NGc9v1jRqqr0o4kRxcvxZHSBHK6G\n\t2J1aX7Vwch5Uug4ECTP7/EfHa6Dy2J69LGZSUXFjPMN1hEK+5vd+1FGp/VcKIc5qJp\n\tY8bhGSYzEpSWDYlUfF+8MUFxYMxmmwgZbMN4SdpgDDM4We/iwDZ7McBLw8kpzoFs3X\n\teJLlfK3uuLPng==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652883004;\n\tbh=qtua/lVIrliyLKZa8I3gZDkmNUCyWyBsDVxcGfP1QTI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=o0+rpgbdNOBXN0EDBN4x+AriIc5EhBPTei6t9RL7JegkwyI9URtYwLCASwyaF5QDH\n\t5FRVj+m5ReOVUNwCb7+WH9v1QkhbROSpGUlHxWCXIjq/ZxVRIWBHwIEiFObTnYu6J6\n\trpUuP2PFmbG03k5XRHbfJRh00dEPCrX51g7QTHT8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o0+rpgbd\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220518131329.66994-16-tomi.valkeinen@ideasonboard.com>","References":"<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518131329.66994-16-tomi.valkeinen@ideasonboard.com>","To":"David Plowman <david.plowman@raspberrypi.com>,\n\tJacopo Mondi <jacopo@jmondi.org>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tTomi Valkeinen <tomi.valkeinen@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 18 May 2022 15:10:02 +0100","Message-ID":"<165288300258.368702.10617116332860769874@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 15/18] py: rename pyxyz to py_xyz","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23063,"web_url":"https://patchwork.libcamera.org/comment/23063/","msgid":"<c9ac5557-1648-8123-fba8-58fbed83c16c@ideasonboard.com>","date":"2022-05-18T14:18:56","subject":"Re: [libcamera-devel] [PATCH v3 15/18] py: rename pyxyz to py_xyz","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 18/05/2022 17:10, Kieran Bingham wrote:\n> Quoting Tomi Valkeinen (2022-05-18 14:13:26)\n>> Having the underscore makes the names more readable, especially when\n>> there are multiple words in the name.\n>>\n> \n> Fine with me, is this going to break users of pycamera already? I.e.\n> does picamera2 need a new rebase on top of this? If so - we should\n> highlight this to RPi.\n\nThis patch? No, this is an internal change. The other patches in this \nseries? Yes. Although, the bindings support that was merged was already \ndifferent than the old-ish version that picamera2 uses/used.\n\n  Tomi","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 054BCC0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 May 2022 14:19:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4F606565C;\n\tWed, 18 May 2022 16:19:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 11DB965656\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 May 2022 16:19:00 +0200 (CEST)","from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99CE8E50;\n\tWed, 18 May 2022 16:18:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652883541;\n\tbh=N0lgrBxoieTAR8RKqIo3Qy92h6YWXHIwJXvHc4Hl37A=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=oH9YnwW6u8bNeOurbw5ggSQCqx9PgU925Ed8IA617ySDIthf2ZAC5fpfQbu3gq3a5\n\tI8Vnb8l7IKEQ+Mj37ScPhmzFRGsOLVvxvReivuw7suWy8tq3G3/9Klhz8pDdJaLLZf\n\tA8kRKdni/31XEMwDkD9oXZkyGsJQkQPYDAPvwjqwO5+OD27RsibKZ44LuLTWMWRpyx\n\tJPadSaKSFb1ebX8Vo8TFRf1m7488SSy7DpEpguVyZWg+XCE5tX06pbZqnGa4LfJuRy\n\tF/sEBdAwEzsVuYfVbrWrIxDuqirQpdEaVj/ciEevc1K/JtGm3nISInIny/nvcRiz/D\n\tnkY5R1FqbzwVQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652883539;\n\tbh=N0lgrBxoieTAR8RKqIo3Qy92h6YWXHIwJXvHc4Hl37A=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=F0Ouf+y6YGW73NJG0yb1CezulKLX9M6ydzD8ZZ/kooJJ513pnaZ4M1PNVEfmp0jXk\n\tVGpsPC5efQ0fUU9YTbou1GOb8KNQhoaaVkd/6apj8BU8R2hBAaGDVhLLCBaycfoSYY\n\tWiQQ1qJWjBaGThIFhNJxxNOa/v1ZL7rzPuDspqQE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"F0Ouf+y6\"; dkim-atps=neutral","Message-ID":"<c9ac5557-1648-8123-fba8-58fbed83c16c@ideasonboard.com>","Date":"Wed, 18 May 2022 17:18:56 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tJacopo Mondi <jacopo@jmondi.org>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518131329.66994-16-tomi.valkeinen@ideasonboard.com>\n\t<165288300258.368702.10617116332860769874@Monstersaurus>","In-Reply-To":"<165288300258.368702.10617116332860769874@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 15/18] py: rename pyxyz to py_xyz","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]