{"id":15960,"url":"https://patchwork.libcamera.org/api/patches/15960/?format=json","web_url":"https://patchwork.libcamera.org/patch/15960/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220518131329.66994-11-tomi.valkeinen@ideasonboard.com>","date":"2022-05-18T13:13:21","name":"[libcamera-devel,v3,10/18] py: cam_kms: fix multistream display","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"98a1bf7e6d0add2070599d24b24c37cbbd69bb74","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15960/mbox/","series":[{"id":3122,"url":"https://patchwork.libcamera.org/api/series/3122/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3122","date":"2022-05-18T13:13:11","name":"Misc Python bindings patches","version":3,"mbox":"https://patchwork.libcamera.org/series/3122/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15960/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15960/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4103C3271\n\tfor ;\n\tWed, 18 May 2022 13:14:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 260C365675;\n\tWed, 18 May 2022 15:14:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84B0C6566A\n\tfor ;\n\tWed, 18 May 2022 15:13:51 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB0F1E50;\n\tWed, 18 May 2022 15:13:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652879645;\n\tbh=kk3f22MHUK4RaU0Hou0Ocit2U5vTR7pWRoYQV7nTU8k=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=imh+drDrcDFgMktBwhbYeNQEOJ7j72eDtS2cdu/1OwEvqNOhNYJHPdAgsQ0cl4nsT\n\tWwHOqprt1bFXZ63b5xLeiMmcFO1ISSzMW/Rm35UwElU7XxJGqP2QJNFLr/cR2uS1Nr\n\tK+1LCWL2+h3XAqPJi4r6U1bT6+WHNHfMW7j7asNsxFP76etOWV7+rwXJFaD44tPN8Q\n\t1dPp88gP/GQuwk5y1DWG+mhPD0Rm4F8HackQzM7huZ9qoxSUOIpaxZcEy5gSZheFwQ\n\tzmQvzKPqPKq88i9R1O6enC/beJ33tabeJWjyH5D0Soqq5aD9Vsz2/fSlD4Vuf6Inun\n\t/Lxx0sIpqF+KQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652879631;\n\tbh=kk3f22MHUK4RaU0Hou0Ocit2U5vTR7pWRoYQV7nTU8k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EPKtiGT3kzKKnfcrFXygcQSJzrRJH8U8GRTKKTgkfDXYwm5HCvcz4zp4Idh9e9G8n\n\tGS9haDS/5+EBPZdkZjNJXqToVIwiJ4JWGIDx1OY0ONLTspjcZRBZlcbLYvgvou/0Ko\n\tcQ0vywKmrI873vavz7lEjpmrIVADnXu/zzNQnhfY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EPKtiGT3\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Wed, 18 May 2022 16:13:21 +0300","Message-Id":"<20220518131329.66994-11-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>","References":"<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 10/18] py: cam_kms: fix multistream\n\tdisplay","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of doing an atomic commit for each stream, do a single commit\nfor the two planes. This fixes the issue that only the first plane was\nactually shown.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/py/cam/cam_kms.py | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\nindex f1844717..d8ff0284 100644\n--- a/src/py/cam/cam_kms.py\n+++ b/src/py/cam/cam_kms.py\n@@ -75,12 +75,13 @@ class KMSRenderer:\n \n buffers = drmreq['camreq'].buffers\n \n+ req = pykms.AtomicReq(self.card)\n+\n for stream, fb in buffers.items():\n drmfb = self.cam_2_drm.get(fb, None)\n-\n- req = pykms.AtomicReq(self.card)\n self.add_plane(req, stream, drmfb)\n- req.commit()\n+\n+ req.commit()\n \n def handle_page_flip(self, frame, time):\n old = self.current\n","prefixes":["libcamera-devel","v3","10/18"]}