[{"id":2135,"web_url":"https://patchwork.libcamera.org/comment/2135/","msgid":"<20190703163748.GH5007@pendragon.ideasonboard.com>","date":"2019-07-03T16:37:48","subject":"Re: [libcamera-devel] [PATCH v3] libcamera: ipa_module: add path to\n\tmodule loading error message","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jul 03, 2019 at 10:58:25PM +0900, Paul Elder wrote:\n> Add an error message to tell, if an IPA module failed to load, the\n> path to the IPA module shared object that was attempted to be loaded.\n> \n> Signed-off-by: Paul Elder \n> ---\n> Changes in v3:\n> - error message wording change\n> - moved to under the close: label\n> \n> Changes in v2: don't show module version\n> \n> src/libcamera/ipa_module.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 58e8d1d..477f4b8 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -289,6 +289,11 @@ int IPAModule::loadIPAModuleInfo()\n> unmap:\n> \tmunmap(map, soSize);\n> close:\n> +\tif (ret)\n> +\t\tLOG(IPAModule, Error)\n> +\t\t\t<< \"Error loading IPA module \"\n\nI would write \"Error loading IPA module info for \" as this method loads\nthe module info only.\n\n> +\t\t\t<< libPath_;\n\nThis can fit on two lines:\n\n\t\tLOG(IPAModule, Error)\n\t\t\t<< \"Error loading IPA module info for \" << libPath_;\n\nApart from that,\n\nReviewed-by: Laurent Pinchart \n\nBy the way don't forget to remove the history changelog (everything from\n--- onwards) before pushing.\n\n> +\n> \tclose(fd);\n> \treturn ret;\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9ADBC60C01\n\tfor ;\n\tWed, 3 Jul 2019 18:38:09 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A20E24B;\n\tWed, 3 Jul 2019 18:38:09 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562171889;\n\tbh=LmRs5ILyJ/Tza2SVxrS9tVxaVwIKP+mgHbmol/uXNqI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GBW/BUigTXlKNP8qI8R99ZNF2eRVdGGRSRG9MV+OCZlrxZkUNfGMb0t/CHukoVU9X\n\tImAcc0AtDAxIvNieQEQFB06izxqQz/qCd1I3EBPAN+jgHaejRoR+pGpgS4RsjvOVtX\n\tKZR5FIeY3/fhUnc2pEU8OrXs1NhLSWEvNmVyT2n0=","Date":"Wed, 3 Jul 2019 19:37:48 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190703163748.GH5007@pendragon.ideasonboard.com>","References":"<20190703135825.32353-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190703135825.32353-1-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3] libcamera: ipa_module: add path to\n\tmodule loading error message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Jul 2019 16:38:09 -0000"}},{"id":2144,"web_url":"https://patchwork.libcamera.org/comment/2144/","msgid":"<20190703230146.GB17912@bigcity.dyn.berto.se>","date":"2019-07-03T23:01:46","subject":"Re: [libcamera-devel] [PATCH v3] libcamera: ipa_module: add path to\n\tmodule loading error message","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2019-07-03 22:58:25 +0900, Paul Elder wrote:\n> Add an error message to tell, if an IPA module failed to load, the\n> path to the IPA module shared object that was attempted to be loaded.\n> \n> Signed-off-by: Paul Elder \n\nWith Laurent's suggestions fixed,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> Changes in v3:\n> - error message wording change\n> - moved to under the close: label\n> \n> Changes in v2: don't show module version\n> \n> src/libcamera/ipa_module.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 58e8d1d..477f4b8 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -289,6 +289,11 @@ int IPAModule::loadIPAModuleInfo()\n> unmap:\n> \tmunmap(map, soSize);\n> close:\n> +\tif (ret)\n> +\t\tLOG(IPAModule, Error)\n> +\t\t\t<< \"Error loading IPA module \"\n> +\t\t\t<< libPath_;\n> +\n> \tclose(fd);\n> \treturn ret;\n> }\n> -- \n> 2.20.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1562360C01\n\tfor ;\n\tThu, 4 Jul 2019 01:01:48 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id r15so2882573lfm.11\n\tfor ;\n\tWed, 03 Jul 2019 16:01:48 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\tf16sm643500lfc.81.2019.07.03.16.01.46\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 03 Jul 2019 16:01:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=d9kCXsgyTfUrNt1gdUyvDfHDL1sBZQWNUYuQwfhO/co=;\n\tb=ntZyXteYrfTrP9NSRlj7PMX/h/76+l9LsOO/wkYBO4/e9SPqZRfIbzfmY2A2cnpgPo\n\tQwLxjuE6crHk4sKB63w1TxN8/yiDCO8ejAZ/jhEycTk3nsaQHVQaqhO63IP5CF/OyTYm\n\tGoRzKmZLPVLQvxWhDT4rVhJx87I3NKTV61sAvpuLaKaokOlFu4BXwrct1qiVMJmxhWLC\n\tWp/2UA56hi6KcN57OiWwlt4pvlTEsw7AECBvRyApWNCtNOqtIc6dGIiRWdpLXRcZ8u9C\n\tu1slHkSDUn0k/PJPgye1zVW7acViWomwFK5KO/6EThQ62meSTMQqbXE6r2SemlJUJzXH\n\t04Qg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=d9kCXsgyTfUrNt1gdUyvDfHDL1sBZQWNUYuQwfhO/co=;\n\tb=A3SDvWgdnmLHbRhGgl98bB54uaNgdM0335VhOkeQPG5SIzxlUFNTmpXc6RwMw4IxUU\n\txDYFCC8l91cetbqKlu03DZL0dWu9imq7GmGvoOxt30GBe93tBgobqDSltvxLvrNF32w4\n\tXaxfbCfxQr3t4F+lSOIv9xYGUsPRATaAtmJccBEBv+pRqAp6R1rqD9T54xoTgzQcEOX8\n\tRtc2oyECsjySj110naJzXEqGZUihTBVEpWxA2+JaLtgCGD8YwULGQ+QBPKG/3LX6NfSv\n\tP3s07pl1Te4V+Rl+jp0l4SvM1z4FllL92YKyObUF7rlMJfw+FtbUR/1GJ+vuYtoe2oaE\n\tvsSQ==","X-Gm-Message-State":"APjAAAVLxtrFLNIwadrXUN1DY2ENJNaIQGXWyYMuS0v3/p6iKm+XO6Ev\n\twIZjAE7RIgYJji/CrJxGdIswMg==","X-Google-Smtp-Source":"APXvYqyxjCi91GdRwjUKDplvVya1vYVbRPrh06zuQiqwJ+RB2aaFOtmDJNOjWiStFBSb1qRFEiCXXg==","X-Received":"by 2002:ac2:5dc8:: with SMTP id x8mr18487586lfq.94.1562194907461;\n\tWed, 03 Jul 2019 16:01:47 -0700 (PDT)","Date":"Thu, 4 Jul 2019 01:01:46 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190703230146.GB17912@bigcity.dyn.berto.se>","References":"<20190703135825.32353-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190703135825.32353-1-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v3] libcamera: ipa_module: add path to\n\tmodule loading error message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Jul 2019 23:01:48 -0000"}}]