[{"id":23051,"web_url":"https://patchwork.libcamera.org/comment/23051/","msgid":"","date":"2022-05-18T13:42:00","subject":"Re: [libcamera-devel] [PATCH v3 03/18] py: add comment about the\n\tsymlinks","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Wed, May 18, 2022 at 04:13:14PM +0300, Tomi Valkeinen wrote:\n> Add comment about the symlinks to clarify the purpose.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/libcamera/meson.build | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 3c0828b8..427716d7 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -54,6 +54,9 @@ pycamera = shared_module('_libcamera',\n> dependencies : pycamera_deps,\n> cpp_args : pycamera_args)\n> \n> +# Create symlinks from the build dir to the source dir so that we can use the\n> +# Python module directly from the build dir.\n> +\n> run_command('ln', '-fsT', files('__init__.py'),\n> meson.current_build_dir() / '__init__.py',\n> check: true)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05A93C0F2A\n\tfor ;\n\tWed, 18 May 2022 13:42:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1DF5365659;\n\tWed, 18 May 2022 15:42:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 547ED65656\n\tfor ;\n\tWed, 18 May 2022 15:42:08 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D79EE50;\n\tWed, 18 May 2022 15:42:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652881330;\n\tbh=q4e0rakRzYyyLcUftWfFTgwlyObZ4+zaWMr/EHYuSAg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=IPZwnuDk2ufSMZJ7wP0yo9im3BG9RzAlzAYfsiGxNAmoBVILC5mtW3igUntYEqZV/\n\tdWRHTSduWK1RHA2Gkht4HiM1W8mCJroiJcO25pEOrNwbfqcCtUhZ3PnkclDOzDKhwa\n\tnQBeIRIJguiMTWIM1ZJhQegA0OSbq/v0qIoGCdgq8/P8fsIWZvK88Qmsu1ldJng1lT\n\tSenyhisBvQb0NSLQZfsXtnmFETZ6FflmlUs4ttZ0DGAaeA54nLLl963iZ+6ESe57IB\n\tDpAmjGa/rtfkPGz7adhxsqrleKmApJEJ4FRbWA1nwfHmjdBytIKTVgc3gEUwsNA662\n\tLa5OcwYdEXa6Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652881327;\n\tbh=q4e0rakRzYyyLcUftWfFTgwlyObZ4+zaWMr/EHYuSAg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QQ1FheuvdE0HnyEZJMGxO3JX1k23agGtVSSzUnbn9s1xjPrhkT4rHCUvirEqpfQD8\n\tB0zbjgsA+azYdhkB9tyTlWYNKjmDHMFvOfhKoEQwy5StIRSka43IovUUCNXwK3oqcu\n\thSltTOmVzEwFGx7YcCtT9yfDloVMe31FLTkQOxI8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QQ1Fheuv\"; dkim-atps=neutral","Date":"Wed, 18 May 2022 16:42:00 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518131329.66994-4-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220518131329.66994-4-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 03/18] py: add comment about the\n\tsymlinks","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23057,"web_url":"https://patchwork.libcamera.org/comment/23057/","msgid":"<165288288905.368702.199094378432945250@Monstersaurus>","date":"2022-05-18T14:08:09","subject":"Re: [libcamera-devel] [PATCH v3 03/18] py: add comment about the\n\tsymlinks","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2022-05-18 14:13:14)\n> Add comment about the symlinks to clarify the purpose.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/py/libcamera/meson.build | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 3c0828b8..427716d7 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -54,6 +54,9 @@ pycamera = shared_module('_libcamera',\n> dependencies : pycamera_deps,\n> cpp_args : pycamera_args)\n> \n> +# Create symlinks from the build dir to the source dir so that we can use the\n> +# Python module directly from the build dir.\n> +\n> run_command('ln', '-fsT', files('__init__.py'),\n> meson.current_build_dir() / '__init__.py',\n> check: true)\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56634C0F2A\n\tfor ;\n\tWed, 18 May 2022 14:08:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0ED0565659;\n\tWed, 18 May 2022 16:08:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 916E265656\n\tfor ;\n\tWed, 18 May 2022 16:08:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 520FF4A8;\n\tWed, 18 May 2022 16:08:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652882893;\n\tbh=c1lnslPkd/Srr4AhZeHxDbmJduhBH/m4lqUxxX2bK+A=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pWC1ud6ADCZFyO55QHkmAjoGG0ufcc25OgNyZaTMgml9QlMl+/1BGb8kFytKhw63i\n\tfovHjloKCi8AbmJvlwAph0aCUWmLUFfFg2ThjXKFcfyamVcJ99EEYUygMbWXPKdHIg\n\tEIcJpi+BpT7mv15RN1AEUjVEQrM7FH4k2NHqNGWCypafOhJzEd9UeNXmv6+p53wICD\n\t9f89vxuRfJgES2Mz2ydLxyOOz5rMDkJj9v9Yt4xbKIV8gltDEQWodJMCNX37+/K1z3\n\tLRWN2oKqLc+VHIXtUW6AR6cFa0EjB1sf6KG5o8EYDIGbC+/PRhr09wQCmnKql3Kkgy\n\tntYC1S6DDzG6g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652882891;\n\tbh=c1lnslPkd/Srr4AhZeHxDbmJduhBH/m4lqUxxX2bK+A=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=T5rnyRdLUB8xjCfaOdMwgNqkcH3tiYCCH2ohjDRWrqNJ76mN/E8EFSJcs83DKuop6\n\t5SLewkNhg7dHFlytNyQFv8lS037Orb2LaOnJRw3vDacomKvIcaJYWmE3zdC8cJ9Gig\n\tyFBCYCpC5mlgc7LcZb42otht9jb76sMulsRgksd8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"T5rnyRdL\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220518131329.66994-4-tomi.valkeinen@ideasonboard.com>","References":"<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518131329.66994-4-tomi.valkeinen@ideasonboard.com>","To":"David Plowman ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ,\n\tTomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 18 May 2022 15:08:09 +0100","Message-ID":"<165288288905.368702.199094378432945250@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 03/18] py: add comment about the\n\tsymlinks","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]