[{"id":23056,"web_url":"https://patchwork.libcamera.org/comment/23056/","msgid":"<165288284824.368702.9384339791080798563@Monstersaurus>","date":"2022-05-18T14:07:28","subject":"Re: [libcamera-devel] [PATCH v3 01/18] py: meson: use files() for\n\tcustom_target input files","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2022-05-18 14:13:12)\n> Use files() for the input files for the custom_target(). I believe the\n> current code works, but perhaps it is safer to use files() here.\n> \n> Signed-off-by: Tomi Valkeinen \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/py/libcamera/meson.build | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 2fc2eaec..cd20bb00 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -17,10 +17,10 @@ pycamera_sources = files([\n> 'pymain.cpp',\n> ])\n> \n> -gen_input_files = [\n> - meson.project_source_root() / 'src' / 'libcamera' / 'control_ids.yaml',\n> +gen_input_files = files([\n> + '../../libcamera/control_ids.yaml',\n\nFine by me, but I wonder if we should set control_ids.yaml in a meson\nfiles() definition in the libcamera tree directly. But it probably only\nmakes a difference if there's another user of this ...\n\nBut - this is probably sufficient for now, as the usage of that to\ncreate the controls is more complex to support multiple headers. No\npoint changing that for the sake of this.\n\n\nReviewed-by: Kieran Bingham \n\n> 'pyenums_generated.cpp.in',\n> -]\n> +])\n> \n> gen_py_control_enums = files('gen-py-control-enums.py')\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34225C0F2A\n\tfor ;\n\tWed, 18 May 2022 14:07:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8969265657;\n\tWed, 18 May 2022 16:07:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7244B65656\n\tfor ;\n\tWed, 18 May 2022 16:07:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 078864A8;\n\tWed, 18 May 2022 16:07:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652882853;\n\tbh=oyWodCM37R+tB6AA2joQgP4EJpBrz9w1QMTkzaP/4eU=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QEoIKKBdhFys+nDO9j2c/TcbZOeovo/r4cpYOUYw2rwMFkrCwqSDyFJF+H3odZ1ri\n\tuCvM+rDx3ZF7IppDfkD2D9m/RETCEz7f02yw1UNaQVA5Cbc+doe0vDbHA00+JdQyBG\n\th1ZvPg3qhfiDG9BozvWWw/gQY5UW8jWYa+L8m69YfFIaFSw9zQvukoL1oJ/s3XMn87\n\t4m3Qo2As/v6+4XikQuE0LqMUwgFi3REupaxfx1B7nOl5wSAf/dLMNdvlIyTC92SKpU\n\t6dDjB19+Fh10X7i6gyDGqtG1/tShmGSorfSdcyIWVMrg4SoMEsvjOwrRLHoJNJDv1X\n\tFPOCzy2maL9uA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652882851;\n\tbh=oyWodCM37R+tB6AA2joQgP4EJpBrz9w1QMTkzaP/4eU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VFPBcL4kJw9xoih2Lfr5ewOA9x25Uz9ADe6M9jtOjZKD99yL2zeg1CVZGEu0lN4b9\n\tDQkFnLc8OhrmC7c45Ispum85lFax/pV1WhGKhKW9kIx/wFGGpXtyMy7yYGLjc8fKRD\n\t09AOAH87bWmnsAynwelCS3x9tEKf9OOt/M/1N1UM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VFPBcL4k\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220518131329.66994-2-tomi.valkeinen@ideasonboard.com>","References":"<20220518131329.66994-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518131329.66994-2-tomi.valkeinen@ideasonboard.com>","To":"David Plowman ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ,\n\tTomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 18 May 2022 15:07:28 +0100","Message-ID":"<165288284824.368702.9384339791080798563@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 01/18] py: meson: use files() for\n\tcustom_target input files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]