[{"id":23079,"web_url":"https://patchwork.libcamera.org/comment/23079/","msgid":"<YoV/Kxqkl8ypvfuQ@pendragon.ideasonboard.com>","date":"2022-05-18T23:20:11","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing\n\tRGBX8888 info","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Wed, May 18, 2022 at 03:20:14PM +0300, Tomi Valkeinen wrote:\n> Add missing RGBX8888 PixelFormatInfo.\n> \n> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n> ---\n>  src/libcamera/formats.cpp | 13 +++++++++++++\n>  1 file changed, 13 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 3e60ec7d..1c710541 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -231,6 +231,19 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n>  \t\t.pixelsPerGroup = 1,\n>  \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n>  \t} },\n> +\t{ formats::RGBX8888, {\n> +\t\t.name = \"RGBX8888\",\n> +\t\t.format = formats::RGBX8888,\n> +\t\t.v4l2Formats = {\n> +\t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n\nI think this should be BGRX32. Furthermore, you need to also update the\nvpf2pf map in v4l2_pixelformat.cpp.\n\n> +\t\t\t.multi = V4L2PixelFormat(),\n> +\t\t},\n> +\t\t.bitsPerPixel = 32,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n>  \t{ formats::BGRX8888, {\n>  \t\t.name = \"BGRX8888\",\n>  \t\t.format = formats::BGRX8888,","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34409C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 May 2022 23:20:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B71365659;\n\tThu, 19 May 2022 01:20:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F15B36041E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 May 2022 01:20:21 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9DEE383;\n\tThu, 19 May 2022 01:20:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652916023;\n\tbh=wVEFaSO0zqw5+Leat/gzPnVd3FLV28giY0s0+pt3hzM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=W0v6UAt486vEPm+5P420PhPw/Lsx+W8G4D17faIY0mE6Ht+aOx6Qi1phxh4EMSzdO\n\tYT1frZl2KWCIoUTj9QhsErObllcuCGm5j38/cYNXQqqNHswAKtSJwpGjor0xZr9yZO\n\tQnvEjO5EDZWCTKZorHXTxetTma8rJ+bnN5cx2tNbCYm3P16JqRT4hzNhap8YyndN4+\n\trzg5CLbnImeMCxxZV2sMeikxzP9eo/rNAHuwlkQqHGAjJqOfiqPto6Hb4i12Pbg3z0\n\t/hqtKOqkMiR1KL7X+udBqNHknayuNbcEVi4FacaMiWTtdD5sa6HEg5k1nSQjZSgcfE\n\t0lSgemM60KtfQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652916021;\n\tbh=wVEFaSO0zqw5+Leat/gzPnVd3FLV28giY0s0+pt3hzM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XP59fJV3GcETA/RWTulv6o1Su1zGDjc+QAG5dOCa8nX7AdbIrzBjupJlWoaFwpnaV\n\t3hwjry32emq1VpYQJWdGH1jPi0sgpT5Ij8VrBca4IhjfKYnUVZeTcblcgXSsVqy3qh\n\tr08P7PjqrxUoEWZpRc2Vhk2XifM4CNERqtZTla+E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XP59fJV3\"; dkim-atps=neutral","Date":"Thu, 19 May 2022 02:20:11 +0300","To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Message-ID":"<YoV/Kxqkl8ypvfuQ@pendragon.ideasonboard.com>","References":"<20220518122014.54506-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518122014.54506-2-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220518122014.54506-2-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing\n\tRGBX8888 info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23080,"web_url":"https://patchwork.libcamera.org/comment/23080/","msgid":"<18c30ca9-c236-438a-42c8-e06b8c4ec335@ideasonboard.com>","date":"2022-05-19T06:52:44","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing\n\tRGBX8888 info","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 19/05/2022 02:20, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> Thank you for the patch.\n> \n> On Wed, May 18, 2022 at 03:20:14PM +0300, Tomi Valkeinen wrote:\n>> Add missing RGBX8888 PixelFormatInfo.\n>>\n>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n>> ---\n>>   src/libcamera/formats.cpp | 13 +++++++++++++\n>>   1 file changed, 13 insertions(+)\n>>\n>> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n>> index 3e60ec7d..1c710541 100644\n>> --- a/src/libcamera/formats.cpp\n>> +++ b/src/libcamera/formats.cpp\n>> @@ -231,6 +231,19 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n>>   \t\t.pixelsPerGroup = 1,\n>>   \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n>>   \t} },\n>> +\t{ formats::RGBX8888, {\n>> +\t\t.name = \"RGBX8888\",\n>> +\t\t.format = formats::RGBX8888,\n>> +\t\t.v4l2Formats = {\n>> +\t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n> \n> I think this should be BGRX32. Furthermore, you need to also update the\n\nThanks. Yes, it is obviously wrong, as there was another \nV4L2_PIX_FMT_RGBX32 in the file already. I thought I checked that, but \napparently not...\n\nI have to say I don't get the V4L2 formats. Why is\n\nV4L2_PIX_FMT_XBGR32  BGRX-8-8-8-8\n\nso the X is not beside the R in the define. But\n\nV4L2_PIX_FMT_XRGB32  XRGB-8-8-8-8\n\nX is beside the R. Well, doesn't matter.\n\n> vpf2pf map in v4l2_pixelformat.cpp.\n\nOk.\n\n  Tomi","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B965EC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 May 2022 06:52:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E940E65663;\n\tThu, 19 May 2022 08:52:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2544560419\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 May 2022 08:52:48 +0200 (CEST)","from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 961004A8;\n\tThu, 19 May 2022 08:52:47 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652943169;\n\tbh=ma7LCK6qhqH82SUdo73URzgnvNUU0QWxk+yeOuqgbo8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZkGnibnyHT2BSnRxcphiQ/YcuWUiDmCJaqO4lI5NiARs6AO40GcyiSS5pHw1I48tD\n\t+hcCUmhnU5JKfG9I5teJ1Fb/CLBNkl6D4Dsmur/vwVfX6Sw/QDBcaS3kV1Vl2zM/On\n\t2b75S3+j2w4HOf1CXcDoHQFxEfsADdwVRCUaROtmQS0FtCgZcF1ro7RmgXR/mdxZrH\n\tqDvtcJj1Va1eGJdtQYM+5gPtoOWpD8mvc8PYxTwwapSf/OV06LXHi+FNLc4eLMrEch\n\tVALO6qJDYnC7awQ9tp3ASL5jCNZIPLCFsSf5LmUE71DAaLHZ/560V1xpJ2MqculXvU\n\tZE0krSS4zDwzA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652943167;\n\tbh=ma7LCK6qhqH82SUdo73URzgnvNUU0QWxk+yeOuqgbo8=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=jBO6nq84D3sUL+/LhPB57ViWU7MpaPw+jgX08/aSW5S7DCnWYwiat2/DaHASGs8o0\n\txmlKLgRoZyLuv7W1gAcLJvZBwVxcLcP7B1WHS5+TPadojy1dxk5i7fSHlUHkQN8/d4\n\tiuDl01cefMkweq0iMs1G3u/7/Gf0PRIxObrqcGnI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jBO6nq84\"; dkim-atps=neutral","Message-ID":"<18c30ca9-c236-438a-42c8-e06b8c4ec335@ideasonboard.com>","Date":"Thu, 19 May 2022 09:52:44 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20220518122014.54506-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518122014.54506-2-tomi.valkeinen@ideasonboard.com>\n\t<YoV/Kxqkl8ypvfuQ@pendragon.ideasonboard.com>","In-Reply-To":"<YoV/Kxqkl8ypvfuQ@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing\n\tRGBX8888 info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23082,"web_url":"https://patchwork.libcamera.org/comment/23082/","msgid":"<YoXsrQa1uy/aqzuf@pendragon.ideasonboard.com>","date":"2022-05-19T07:07:25","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing\n\tRGBX8888 info","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nOn Thu, May 19, 2022 at 09:52:44AM +0300, Tomi Valkeinen wrote:\n> On 19/05/2022 02:20, Laurent Pinchart wrote:\n> > On Wed, May 18, 2022 at 03:20:14PM +0300, Tomi Valkeinen wrote:\n> >> Add missing RGBX8888 PixelFormatInfo.\n> >>\n> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n> >> ---\n> >>   src/libcamera/formats.cpp | 13 +++++++++++++\n> >>   1 file changed, 13 insertions(+)\n> >>\n> >> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> >> index 3e60ec7d..1c710541 100644\n> >> --- a/src/libcamera/formats.cpp\n> >> +++ b/src/libcamera/formats.cpp\n> >> @@ -231,6 +231,19 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n> >>   \t\t.pixelsPerGroup = 1,\n> >>   \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> >>   \t} },\n> >> +\t{ formats::RGBX8888, {\n> >> +\t\t.name = \"RGBX8888\",\n> >> +\t\t.format = formats::RGBX8888,\n> >> +\t\t.v4l2Formats = {\n> >> +\t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n> > \n> > I think this should be BGRX32. Furthermore, you need to also update the\n> \n> Thanks. Yes, it is obviously wrong, as there was another \n> V4L2_PIX_FMT_RGBX32 in the file already. I thought I checked that, but \n> apparently not...\n> \n> I have to say I don't get the V4L2 formats. Why is\n> \n> V4L2_PIX_FMT_XBGR32  BGRX-8-8-8-8\n> \n> so the X is not beside the R in the define. But\n> \n> V4L2_PIX_FMT_XRGB32  XRGB-8-8-8-8\n> \n> X is beside the R. Well, doesn't matter.\n\nI think those are called historical mistakes. They tend to appear here\nand there. And again :-)\n\n> > vpf2pf map in v4l2_pixelformat.cpp.\n> \n> Ok.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75E4FC0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 May 2022 07:07:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 260C665663;\n\tThu, 19 May 2022 09:07:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A66765654\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 May 2022 09:07:32 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E742D6D4;\n\tThu, 19 May 2022 09:07:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652944054;\n\tbh=pR0zvWricqqEuUGoz8rv6pVURzZU0I22yKbQ2XbsD50=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=It94HXKk/dWFkZcCDhrMOxmGL7kD7wvpKBnJXaXnrLrxL52oOZF3cI7O+BhT5jszs\n\tiXqgqEl6PXOPBZ1w9uMymdLTgRzz/sHGRk8Qny1q6oIJNDftolhXoaHt7tiu1YreYf\n\tj3kW7e+3xll70DNKmOSloYdHynreVQ+6x4xsVbkjXDtD5q55ysYtain0Vu2prdVmeu\n\ttEMMaHIG3p5MPl/U2PEtTk0eUv/UWpj3rdcL722Ae29+SKg0I4ny0YSe5mJ2x2q3xf\n\tN4upx7iSnw9O/QT/9yYwJvoJjLfRHAap/jOHzdRFf1TE1xEyqjfpsj4qZWfHzaz4RD\n\tL6Sv7M0i9AykQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652944052;\n\tbh=pR0zvWricqqEuUGoz8rv6pVURzZU0I22yKbQ2XbsD50=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AbbWm9Fwqw26dJkcbBIil0R/TR6N5EYWmRynkIgopSqwhtmuqEV7424L8Qu8k2rqn\n\tAudnllTUiLwyqkEceA3xki75takUQzTdeV+EVFOoFWVV7xU8hvGl/nycIJ5UEJZSKR\n\tUrQneMD9pCqLFJSUw+I5RX4Olfn7ntUQRYtsEfTM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AbbWm9Fw\"; dkim-atps=neutral","Date":"Thu, 19 May 2022 10:07:25 +0300","To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Message-ID":"<YoXsrQa1uy/aqzuf@pendragon.ideasonboard.com>","References":"<20220518122014.54506-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518122014.54506-2-tomi.valkeinen@ideasonboard.com>\n\t<YoV/Kxqkl8ypvfuQ@pendragon.ideasonboard.com>\n\t<18c30ca9-c236-438a-42c8-e06b8c4ec335@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<18c30ca9-c236-438a-42c8-e06b8c4ec335@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing\n\tRGBX8888 info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":23083,"web_url":"https://patchwork.libcamera.org/comment/23083/","msgid":"<cfa558df-bfcf-6f46-34c4-2b4a164d9c22@ideasonboard.com>","date":"2022-05-19T07:09:15","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing\n\tRGBX8888 info","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 19/05/2022 10:07, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> On Thu, May 19, 2022 at 09:52:44AM +0300, Tomi Valkeinen wrote:\n>> On 19/05/2022 02:20, Laurent Pinchart wrote:\n>>> On Wed, May 18, 2022 at 03:20:14PM +0300, Tomi Valkeinen wrote:\n>>>> Add missing RGBX8888 PixelFormatInfo.\n>>>>\n>>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n>>>> ---\n>>>>    src/libcamera/formats.cpp | 13 +++++++++++++\n>>>>    1 file changed, 13 insertions(+)\n>>>>\n>>>> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n>>>> index 3e60ec7d..1c710541 100644\n>>>> --- a/src/libcamera/formats.cpp\n>>>> +++ b/src/libcamera/formats.cpp\n>>>> @@ -231,6 +231,19 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n>>>>    \t\t.pixelsPerGroup = 1,\n>>>>    \t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n>>>>    \t} },\n>>>> +\t{ formats::RGBX8888, {\n>>>> +\t\t.name = \"RGBX8888\",\n>>>> +\t\t.format = formats::RGBX8888,\n>>>> +\t\t.v4l2Formats = {\n>>>> +\t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_RGBX32),\n>>>\n>>> I think this should be BGRX32. Furthermore, you need to also update the\n>>\n>> Thanks. Yes, it is obviously wrong, as there was another\n>> V4L2_PIX_FMT_RGBX32 in the file already. I thought I checked that, but\n>> apparently not...\n>>\n>> I have to say I don't get the V4L2 formats. Why is\n>>\n>> V4L2_PIX_FMT_XBGR32  BGRX-8-8-8-8\n>>\n>> so the X is not beside the R in the define. But\n>>\n>> V4L2_PIX_FMT_XRGB32  XRGB-8-8-8-8\n>>\n>> X is beside the R. Well, doesn't matter.\n> \n> I think those are called historical mistakes. They tend to appear here\n> and there. And again :-)\n\nI guessed as much. Well, good that we don't make those. If only the \nother people would learn also.\n\n  Tomi","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BC52C0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 May 2022 07:09:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D260665663;\n\tThu, 19 May 2022 09:09:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6042265654\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 May 2022 09:09:19 +0200 (CEST)","from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AC266D4;\n\tThu, 19 May 2022 09:09:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652944160;\n\tbh=fctOeCIHjIAw0PXie+t6Gl1Whjp9esibjcAhpQEICBk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XV3YzY/ffuXiAb1052w/yj2RwgOKkBjaWtI1kaiAAQbkZpCABn6sLOMz6onAAvgoM\n\tATh/eCPtePY4co/fDFXxYYzg5TdC18lqMoYOEJJLGzI/ZTQbd4uc4/SlVTZRdIXNKF\n\te073yjFHpJQTLGWXAx7LbFYIKjTPK0UfeOQyhsKcYCt0ptP4MRKmJMbn6GldRaRSkb\n\tp0me+k0Fe8HskXa6Bn8t/RASIR8skLfxfJZOoCRaupt1yhGp0s2g03ykbmL5wVo32R\n\tfRz6YoaRqpy8fCR7qCk/PEwItDn2EMagfQL9wehviNBB9KKov2U7gfhca3yF+j1KJu\n\tZKx264IZauONQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652944158;\n\tbh=fctOeCIHjIAw0PXie+t6Gl1Whjp9esibjcAhpQEICBk=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=c1uq7N1TGk+C4ViHKHE4ds/n7U/dyfI16m00KLstZN6Iy8QdvnkuesWCyT68l2vIL\n\tGfKs1b3CnyXq0tsidCes8ScUSRNbMM9toM2n3KePf4NWFEhwVejHzkP05GzeX2h+Wh\n\tlpL3nb8NSn3p072PmdXCsalprKXACjOgkDyR22X0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"c1uq7N1T\"; dkim-atps=neutral","Message-ID":"<cfa558df-bfcf-6f46-34c4-2b4a164d9c22@ideasonboard.com>","Date":"Thu, 19 May 2022 10:09:15 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20220518122014.54506-1-tomi.valkeinen@ideasonboard.com>\n\t<20220518122014.54506-2-tomi.valkeinen@ideasonboard.com>\n\t<YoV/Kxqkl8ypvfuQ@pendragon.ideasonboard.com>\n\t<18c30ca9-c236-438a-42c8-e06b8c4ec335@ideasonboard.com>\n\t<YoXsrQa1uy/aqzuf@pendragon.ideasonboard.com>","In-Reply-To":"<YoXsrQa1uy/aqzuf@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: add missing\n\tRGBX8888 info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]