[{"id":23078,"web_url":"https://patchwork.libcamera.org/comment/23078/","msgid":"","date":"2022-05-18T22:26:50","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: formats: fix warning\n\tprint","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Wed, May 18, 2022 at 03:20:13PM +0300, Tomi Valkeinen wrote:\n> Remove extra \"0x\" from the print.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/formats.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index afcaabc5..3e60ec7d 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -926,7 +926,7 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n> \tconst auto iter = pixelFormatInfo.find(format);\n> \tif (iter == pixelFormatInfo.end()) {\n> \t\tLOG(Formats, Warning)\n> -\t\t\t<< \"Unsupported pixel format 0x\"\n> +\t\t\t<< \"Unsupported pixel format \"\n> \t\t\t<< utils::hex(format.fourcc());\n> \t\treturn pixelFormatInfoInvalid;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A751C0F2A\n\tfor ;\n\tWed, 18 May 2022 22:27:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4FB565659;\n\tThu, 19 May 2022 00:27:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ABEF6041E\n\tfor ;\n\tThu, 19 May 2022 00:26:59 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71C059E5;\n\tThu, 19 May 2022 00:26:58 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652912820;\n\tbh=rG53JrKnKhSJ1sEKXCH/Q8gKIpi0w9BC9nNvgzGXNVI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yK/2hpqI5q6sZmu/WVMYvnLBsDOVwnZkTI4FXPKHS3SwpNuT0KyJIlyklGIxJ1zvg\n\tcki1QExGsHzoFsZRr8o3QAuh8WMEBP1pXV6MKO+9RGb9AmT+C+Nt/8KbFHmUYJ8P0g\n\tT/Ntwa61T8Zu6NgoikhWZXoQNHi6QIIr4SzmoPi4/GfVgBLnnS6gikf6Epp+bm4f3e\n\tpV9Y8ddPY5m05n0YjIzaSpD6TSMU5Ywl4nykrEm6WIiUrj30TBuc3jfVB0U24cPuDp\n\tkCs3jijCz5P/lLndAvlGBgRbnGNFQeZB8V3g+hIyiWpiW9Xdlk7VCBaFPfMnVsEk8v\n\tbI0aTQ/lRF8Rw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652912818;\n\tbh=rG53JrKnKhSJ1sEKXCH/Q8gKIpi0w9BC9nNvgzGXNVI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Koer0OsjxQYFzDZDeZftRjPyaoo2kLh7bMfSgchLbx3rgwlTk1jGQSqly0rKmb3ts\n\tV6bFSWKtsUfiL44drKSsfoyebB71gI5Z7fF1jOF36+RHzcZ0BJVl+9Idiu573oFq+C\n\tOuFPjV0uCBfN3gGE7P0Ctl3Cj5P2PZHmQJ491ZIM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Koer0Osj\"; dkim-atps=neutral","Date":"Thu, 19 May 2022 01:26:50 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220518122014.54506-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220518122014.54506-1-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: formats: fix warning\n\tprint","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]