[{"id":2139,"web_url":"https://patchwork.libcamera.org/comment/2139/","msgid":"<20190703223122.GM5007@pendragon.ideasonboard.com>","date":"2019-07-03T22:31:22","subject":"Re: [libcamera-devel] [RFC PATCH v2 6/7] libcamera: ipa: add dummy\n\tIPA that needs to be isolated","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jul 03, 2019 at 05:00:06PM +0900, Paul Elder wrote:\n> Add a dummy IPA that needs to be isolated.\n> \n> Signed-off-by: Paul Elder \n> ---\n> Changes in v2:\n> - ipaModuleInfo contains license rather than \"please isolate me\"\n> \n> src/ipa/ipa_dummy_isolate.cpp | 46 +++++++++++++++++++++++++++++++++++\n> 1 file changed, 46 insertions(+)\n> create mode 100644 src/ipa/ipa_dummy_isolate.cpp\n> \n> diff --git a/src/ipa/ipa_dummy_isolate.cpp b/src/ipa/ipa_dummy_isolate.cpp\n> new file mode 100644\n> index 0000000..f546f43\n> --- /dev/null\n> +++ b/src/ipa/ipa_dummy_isolate.cpp\n> @@ -0,0 +1,46 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * ipa_dummy.cpp - Dummy Image Processing Algorithm module\n\nI think you forgot to update this.\n\n> + */\n> +\n> +#include \n> +\n> +#include \n> +#include \n> +\n> +namespace libcamera {\n> +\n> +class IPADummyIsolate : public IPAInterface\n> +{\n> +public:\n> +\tint init();\n> +};\n> +\n> +int IPADummyIsolate::init()\n> +{\n> +\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n\nI would mention here that the IPA is isolated.\n\nReviewed-by: Laurent Pinchart \n\nI however think this will need to be moved to the test directory as such\na module is really not useful in production. The ipa_dummy should\nprobably be moved there as well. Should we do so already as part of this\npatch series ?\n\n> +\treturn 0;\n> +}\n> +\n> +/*\n> + * External IPA module interface\n> + */\n> +\n> +extern \"C\" {\n> +const struct IPAModuleInfo ipaModuleInfo = {\n> +\tIPA_MODULE_API_VERSION,\n> +\t0,\n> +\t\"PipelineHandlerVimc\",\n> +\t\"Dummy IPA for Vimc that needs to be isolated\",\n> +\t\"Proprietary\",\n> +};\n> +\n> +IPAInterface *ipaCreate()\n> +{\n> +\treturn new IPADummyIsolate();\n> +}\n> +};\n> +\n> +}; /* namespace libcamera */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19E7F60C01\n\tfor ;\n\tThu, 4 Jul 2019 00:31:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9489724B;\n\tThu, 4 Jul 2019 00:31:42 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562193102;\n\tbh=IqHxuKk8CH0c6cab/ho+lqlQbHXd789X6kL/22LC42Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bbZG+hw0JpQDcotMseql0m4/ijvJIci5ahahZcjrgmsPI7Sle/9z7QtbaUcft+G8q\n\tzq9rNw/JFK0G+ZwQ0rMSOIwyeAla6Py8xq7iwpVO2CCv4OvcibrtQKhpdKyXY0ZRwK\n\tG/TPghGkRkJR/c1VPjdpi+f09fAZhX3JeXbckvwc=","Date":"Thu, 4 Jul 2019 01:31:22 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190703223122.GM5007@pendragon.ideasonboard.com>","References":"<20190703080007.21376-1-paul.elder@ideasonboard.com>\n\t<20190703080007.21376-7-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190703080007.21376-7-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [RFC PATCH v2 6/7] libcamera: ipa: add dummy\n\tIPA that needs to be isolated","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Jul 2019 22:31:43 -0000"}}]