[{"id":23016,"web_url":"https://patchwork.libcamera.org/comment/23016/","msgid":"<165280818095.2416244.10082272332851290520@Monstersaurus>","date":"2022-05-17T17:23:00","subject":"Re: [libcamera-devel] [PATCH] py: Fix link generation to __init__.py","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-05-17 18:16:38)\n> The command to create a symlink to the __init__.py file in the source\n> directory uses a relative path from the build directory, which hardcodes\n> the assumption that the build directory is a direct child of the source\n> directory. This isn't always true. Fix it by using the files() function.\n> \n> Fixes: 8aa02271fd71 (\"Add Python bindings\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/py/libcamera/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 0cd7c75bb86c..2fc2eaec1c82 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -54,7 +54,7 @@ pycamera = shared_module('_libcamera',\n> dependencies : pycamera_deps,\n> cpp_args : pycamera_args)\n> \n> -run_command('ln', '-fsT', '../../../../src/py/libcamera/__init__.py',\n> +run_command('ln', '-fsT', files('__init__.py'),\n\neep.\n\n\nReviewed-by: Kieran Bingham \n\n> meson.current_build_dir() / '__init__.py',\n> check: true)\n> \n> \n> base-commit: 5efb6c8e2acdc2dc9edf1f22f6c2a5818062b69e\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BDF8C0F2A\n\tfor ;\n\tTue, 17 May 2022 17:23:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4FAC65656;\n\tTue, 17 May 2022 19:23:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1D2C6041D\n\tfor ;\n\tTue, 17 May 2022 19:23:03 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 804AE6DC;\n\tTue, 17 May 2022 19:23:03 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652808184;\n\tbh=EjfHUF2zhlRffYmKpfsMArfFwo9KKNV/qthKEqaPRxA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iT9nNOmVjC2O92kQ4ZrjENmnJL9oGwgVXES42D4e3lHCMlvCOMl0ljMi71T1FU8nB\n\tk2rB0vAX57WzOtMlIze5Q7dmnnLNAQ6Afck3en2q1QZ+oiZn3qVEH49aA0MZJYhjEW\n\taZ+FttTyte/bnqX7ef4qj9B02fOxrmMP/7njZw79FyD/tIOKz9j3nAWHfZMxrGk4qx\n\tgYNxMcm+Zx2w5XiaPgNJHJ+jjF4fRSClZQ6Gk5ArZBG0wdru8r3NpwvafHtuKA3Kf0\n\tADyIVCTei7kU6DZyYsBVaPZXEnpdrSKuKN5mPAFt8tl4dpNrIad4+FbRUa8FHIPU9e\n\tlgHw+kWFTSQvA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652808183;\n\tbh=EjfHUF2zhlRffYmKpfsMArfFwo9KKNV/qthKEqaPRxA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Vr8jgpW4x5XG652nfbmwCCOxTnYEoUFxjPjoDb8GRj8WbJ0wAZlhSLoy81q3U1t+i\n\t5ENvkiPhotMyJ/4T+sjid4SCRIsMDfjqrp7fSErLHe00+M41PWzgsi5B9gjuGEhEbG\n\tHtLZL2wRehUNpVDagqIa2ASPvvkvuFyKnt7eYCII="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Vr8jgpW4\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220517171638.19164-1-laurent.pinchart@ideasonboard.com>","References":"<20220517171638.19164-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 17 May 2022 18:23:00 +0100","Message-ID":"<165280818095.2416244.10082272332851290520@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] py: Fix link generation to __init__.py","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23017,"web_url":"https://patchwork.libcamera.org/comment/23017/","msgid":"<647cffd9-a257-3bc1-fa97-f45acb49d33c@ideasonboard.com>","date":"2022-05-17T17:24:32","subject":"Re: [libcamera-devel] [PATCH] py: Fix link generation to __init__.py","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 17/05/2022 20:16, Laurent Pinchart wrote:\n> The command to create a symlink to the __init__.py file in the source\n> directory uses a relative path from the build directory, which hardcodes\n> the assumption that the build directory is a direct child of the source\n> directory. This isn't always true. Fix it by using the files() function.\n> \n> Fixes: 8aa02271fd71 (\"Add Python bindings\")\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/py/libcamera/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 0cd7c75bb86c..2fc2eaec1c82 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -54,7 +54,7 @@ pycamera = shared_module('_libcamera',\n> dependencies : pycamera_deps,\n> cpp_args : pycamera_args)\n> \n> -run_command('ln', '-fsT', '../../../../src/py/libcamera/__init__.py',\n> +run_command('ln', '-fsT', files('__init__.py'),\n> meson.current_build_dir() / '__init__.py',\n> check: true)\n> \n> \n> base-commit: 5efb6c8e2acdc2dc9edf1f22f6c2a5818062b69e\n\nReviewed-by: Tomi Valkeinen \n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E52BC0F2A\n\tfor ;\n\tTue, 17 May 2022 17:24:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 352A56041E;\n\tTue, 17 May 2022 19:24:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51C1D6041D\n\tfor ;\n\tTue, 17 May 2022 19:24:35 +0200 (CEST)","from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00B276DC;\n\tTue, 17 May 2022 19:24:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652808277;\n\tbh=PjEEGKREWCI6cjVF6Zo9/7GJkSlttiwvHca6MOn+lho=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=AwUtJ4xulXxXRSck8+IXF2jw6lGXjlWHHRXvHLoQeYpvr/r84GKebCPFQdqWk9sAL\n\t+Tnoyo4wAcSdsf2KvXyCHV0UW8O5kR4bo3VRFvMXRG2/GFwrKyrhYc4k3rvoX92Gwl\n\t3rTTfl2IBlyflJUuhLwnSAXgIjo1C9JCCbci8zSJ/6A6/NS+RekgVdBv2GARnxr1AO\n\tEQKCJwMveHWVr1eOtVgB1zRGIdW2Muto35+P043nMB5FBufuo23Cv0rQK6tTQiTmJd\n\tOGAOetjU63ugklWyVGZK+GOn2QmkdZ/5BQICJQZ6sL9etrKDR/v9onwtvrNvMm+NQc\n\t2b2kUT1qo0owQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652808275;\n\tbh=PjEEGKREWCI6cjVF6Zo9/7GJkSlttiwvHca6MOn+lho=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=osUb5XQJZawLm3s5FdKED3UwNU1BYODDH5PzGccmtrBhWktNgSXdJqd7cqeZmdYif\n\tYum+5uJ1OonDyi+2yWbHUY0SDj0piOAHlmDLpCSHmEQv+FoeihgEphStOiw2RiccC3\n\tIvpOpI8DGnIUYzrSQufoqD4LFMUb1hIvqKVpRAnM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"osUb5XQJ\"; dkim-atps=neutral","Message-ID":"<647cffd9-a257-3bc1-fa97-f45acb49d33c@ideasonboard.com>","Date":"Tue, 17 May 2022 20:24:32 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.8.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220517171638.19164-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220517171638.19164-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] py: Fix link generation to __init__.py","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]