{"id":15938,"url":"https://patchwork.libcamera.org/api/patches/15938/?format=json","web_url":"https://patchwork.libcamera.org/patch/15938/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220517171638.19164-1-laurent.pinchart@ideasonboard.com>","date":"2022-05-17T17:16:38","name":"[libcamera-devel] py: Fix link generation to __init__.py","commit_ref":"9f00e78bf5a6b311c6d0e72b7c79f793863ea942","pull_url":null,"state":"accepted","archived":false,"hash":"b0445d880644125c8be571c40840a79721ebadac","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15938/mbox/","series":[{"id":3117,"url":"https://patchwork.libcamera.org/api/series/3117/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3117","date":"2022-05-17T17:16:38","name":"[libcamera-devel] py: Fix link generation to __init__.py","version":1,"mbox":"https://patchwork.libcamera.org/series/3117/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15938/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15938/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCBC3C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 May 2022 17:16:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91A226041E;\n\tTue, 17 May 2022 19:16:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A45E6041D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 May 2022 19:16:49 +0200 (CEST)","from localhost.localdomain (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1BD74A8;\n\tTue, 17 May 2022 19:16:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652807810;\n\tbh=lQO2EooYXP8U8Hg9kIIOx+DH+8gbfUac75sFqCRKSYA=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=wk5THF3EDfe7HDp2ybFbyBxKZP6HMaFEEttR48/NNPxsluqZytK1TB9ijgKY53KiC\n\tWArEx8fALJQYi1gnfzOdUARHrHwK7qcos+oRSn0DQ8ydhmmiQi26ENng2uuZ4/M0wq\n\tP3hPdq/so5Gsv/HBPIZlatG5IG9kKLPcv3zAYS2YlY4nBtqLg5GlJFo3Ev+IjALXpc\n\tntp0Cyp0oP5K3x881sDIToaAApHTQ7Nqrxsl3Y2++KDDDYqB6jhRogK5Wp8hLapNF7\n\tcFDh2MSTzIm2bGL/ZnCyb/fMWMUD2Oq7CNnfYtY9/InNRUPGNAeFZ4VGSG/+k8YtHE\n\ts6S8h7y6yIgKQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652807808;\n\tbh=lQO2EooYXP8U8Hg9kIIOx+DH+8gbfUac75sFqCRKSYA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=f2cArq6XarNorluV1rWgK3F5vHvmVqDAAMI+ttb3Pykve8IbTCeSCE0s9n2naRjnp\n\t93J2roE6njkwRdanYMkcoIDW/4df0EcOxOgymHb/VEYUfiopbUvhAkZCrRJKPLCUyf\n\tlViquq8G1ykEyLidK5SLVcxRzhyaPes4QF4zQJ1k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f2cArq6X\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 17 May 2022 20:16:38 +0300","Message-Id":"<20220517171638.19164-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] py: Fix link generation to __init__.py","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The command to create a symlink to the __init__.py file in the source\ndirectory uses a relative path from the build directory, which hardcodes\nthe assumption that the build directory is a direct child of the source\ndirectory. This isn't always true. Fix it by using the files() function.\n\nFixes: 8aa02271fd71 (\"Add Python bindings\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 5efb6c8e2acdc2dc9edf1f22f6c2a5818062b69e","diff":"diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\nindex 0cd7c75bb86c..2fc2eaec1c82 100644\n--- a/src/py/libcamera/meson.build\n+++ b/src/py/libcamera/meson.build\n@@ -54,7 +54,7 @@ pycamera = shared_module('_libcamera',\n                          dependencies : pycamera_deps,\n                          cpp_args : pycamera_args)\n \n-run_command('ln', '-fsT', '../../../../src/py/libcamera/__init__.py',\n+run_command('ln', '-fsT', files('__init__.py'),\n             meson.current_build_dir() / '__init__.py',\n             check: true)\n \n","prefixes":["libcamera-devel"]}