[{"id":23010,"web_url":"https://patchwork.libcamera.org/comment/23010/","msgid":"<165280650319.2416244.7163351970425354261@Monstersaurus>","date":"2022-05-17T16:55:03","subject":"Re: [libcamera-devel] [PATCH v2 09/13] py: cam_kms: fix multistream\n\tdisplay","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2022-05-17 15:33:21)\n> Instead of doing an atomic commit for each stream, do a single commit\n> for the two planes. This fixes the issue that only the first plane was\n> actually shown.\n> \n> Signed-off-by: Tomi Valkeinen \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/py/cam/cam_kms.py | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\n> index f1844717..d8ff0284 100644\n> --- a/src/py/cam/cam_kms.py\n> +++ b/src/py/cam/cam_kms.py\n> @@ -75,12 +75,13 @@ class KMSRenderer:\n> \n> buffers = drmreq['camreq'].buffers\n> \n> + req = pykms.AtomicReq(self.card)\n> +\n> for stream, fb in buffers.items():\n> drmfb = self.cam_2_drm.get(fb, None)\n> -\n> - req = pykms.AtomicReq(self.card)\n> self.add_plane(req, stream, drmfb)\n> - req.commit()\n> +\n> + req.commit()\n> \n> def handle_page_flip(self, frame, time):\n> old = self.current\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7CF5C0F2A\n\tfor ;\n\tTue, 17 May 2022 16:55:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76C136041E;\n\tTue, 17 May 2022 18:55:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AEB66041D\n\tfor ;\n\tTue, 17 May 2022 18:55:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1909C4A8;\n\tTue, 17 May 2022 18:55:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652806506;\n\tbh=QpNnfAigxy2Ao9L8jouHROqum3pYi1zxMdXHqIQFeEU=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=sXRI+au5edR6zTM6rPqVPy3VQ1nzqmWJb9HX1To+IU7Tn4pYDNQk1jSOn8MAU31+U\n\tR6HZ3c9pYrRoK7OWDyRY2sPwj1xz5apeE1j/wOAuYaFtbHaF25HxBA5m9zsoA2+D50\n\tF+vtB/AY24Hea0Ud96/BGk52oZOnACTKqwW/sa+34IKt3ttzMK22JQkRr/C2DL1Qy4\n\te5vuvy2/eXDgGL86O1GNm9DIuhZN8DfPrdrTF58/KToNgpGjEDnBsT7cUahXmXcTn8\n\tl+/4zH+t0rnAHRuiIeEuQPcH+HURNyrPmlepLFtKGM7PghHhQ1QZgJIaSC8I61Fsb1\n\tZTqPiuBQ6ZlfA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652806505;\n\tbh=QpNnfAigxy2Ao9L8jouHROqum3pYi1zxMdXHqIQFeEU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=r5Qi2XnVZoLd5aJyURr8VNw7f4ABAfkyJFcHdwPAJZcCwXg1PaIRKnt3DAyaJnvZn\n\tha1+wz/WjViM/34MpcoSSdbr1UO21WpfP5x84SiOMIWvqHNZMu0KX00KXQ6SD6Crzj\n\tgefR9Y/sa47WAqDV/b/JFgmwwi9mh9LQTqQ5dvZQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r5Qi2XnV\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220517143325.71784-10-tomi.valkeinen@ideasonboard.com>","References":"<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>\n\t<20220517143325.71784-10-tomi.valkeinen@ideasonboard.com>","To":"David Plowman ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ,\n\tTomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 17 May 2022 17:55:03 +0100","Message-ID":"<165280650319.2416244.7163351970425354261@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 09/13] py: cam_kms: fix multistream\n\tdisplay","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]