{"id":15930,"url":"https://patchwork.libcamera.org/api/patches/15930/?format=json","web_url":"https://patchwork.libcamera.org/patch/15930/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220517143325.71784-7-tomi.valkeinen@ideasonboard.com>","date":"2022-05-17T14:33:18","name":"[libcamera-devel,v2,06/13] py: unittests: make typechecker happy","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0297681d36eb0ce3b9d84fc54dca782650db68a6","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15930/mbox/","series":[{"id":3116,"url":"https://patchwork.libcamera.org/api/series/3116/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3116","date":"2022-05-17T14:33:12","name":"Misc Python bindings patches","version":2,"mbox":"https://patchwork.libcamera.org/series/3116/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15930/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15930/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85F13C326E\n\tfor ;\n\tTue, 17 May 2022 14:33:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90BB56150E;\n\tTue, 17 May 2022 16:33:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4CB065665\n\tfor ;\n\tTue, 17 May 2022 16:33:54 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B80DDA8;\n\tTue, 17 May 2022 16:33:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652798038;\n\tbh=CtW1NDm3DIh/r1HdoChtqD1UBdwwy7iA9E7BTzTyYPc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=mOcxJ+z1pOelE0D8XdcFogY0gLn/k7IhTe3SF1PQ08vCKVDC4Bgt+Xj3fK6u3r4RK\n\tr14mQkz0MJYQniWLKUuh2zerM4CK2kx7+VEVTkZnBnUcmMDUv+DjqitKujgI+dtp4q\n\t7Dsa/nhSBi3KKJHUxGlhpuJ+aPH5d0pXSROQhdrR1AC4zBW6tJqTT6nL+Yi3tLeiPq\n\tZG5uixoi6lUa2Sd1/E+t/+ZI7lHdFOJpReMfVWZtVjU/iQ4ug5U9K8JJO07m9xVczf\n\tqcsUYT2VFUn+YnCclivxueqljfy6Q0NDo1T4Rum+Ks5LSjhOXUu8XMWMzcKymXdDj6\n\tUJWHGbqlk0/jw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652798034;\n\tbh=CtW1NDm3DIh/r1HdoChtqD1UBdwwy7iA9E7BTzTyYPc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YWja2EoeCoBcw/puNHr9uBSPP9CAaBSV+JwwZXViNUXSaKZfkriTvUK4VdH3Jpsj3\n\tVhPoXEkSYNBlk8fHC5zlKL/GFWlGhASK93NfB3J0rUE8di94ULLzmrappHRxesrx+a\n\tFvBEpp4DRFMocg9d/tfr1RZwQaoiQt8RkQvFgnmM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YWja2Eoe\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Tue, 17 May 2022 17:33:18 +0300","Message-Id":"<20220517143325.71784-7-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>","References":"<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 06/13] py: unittests: make typechecker\n\thappy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add some annotations and self.assertIsNotNone() calls to remove the\ntypechecker warnings.\n\nSigned-off-by: Tomi Valkeinen \n---\n test/py/unittests.py | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)","diff":"diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 4c214f0a..2ea5ca35 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -10,6 +10,7 @@ import libcamera as libcam\n import os\n import selectors\n import time\n+import typing\n import unittest\n import weakref\n \n@@ -70,6 +71,9 @@ class SimpleTestMethods(BaseTestCase):\n \n \n class CameraTesterBase(BaseTestCase):\n+ cm: typing.Any\n+ cam: typing.Any\n+\n def setUp(self):\n self.cm = libcam.CameraManager.singleton()\n self.cam = next((cam for cam in self.cm.cameras if 'platform/vimc' in cam.id), None)\n@@ -131,6 +135,7 @@ class AllocatorTestMethods(CameraTesterBase):\n wr_allocator = weakref.ref(allocator)\n \n buffers = allocator.buffers(stream)\n+ self.assertIsNotNone(buffers)\n buffers = None\n \n buffer = allocator.buffers(stream)[0]\n@@ -166,6 +171,8 @@ class SimpleCaptureMethods(CameraTesterBase):\n \n streamconfig = camconfig.at(0)\n fmts = streamconfig.formats\n+ self.assertIsNotNone(fmts)\n+ fmts = None\n \n ret = cam.configure(camconfig)\n self.assertZero(ret)\n@@ -225,6 +232,7 @@ class SimpleCaptureMethods(CameraTesterBase):\n \n streamconfig = camconfig.at(0)\n fmts = streamconfig.formats\n+ self.assertIsNotNone(fmts)\n \n ret = cam.configure(camconfig)\n self.assertZero(ret)\n@@ -348,9 +356,9 @@ if __name__ == '__main__':\n gc.unfreeze()\n gc.collect()\n \n- obs_after = get_all_objects([obs_before])\n+ obs_after = get_all_objects([obs_before]) # type: ignore\n \n- before = create_type_count_map(obs_before)\n+ before = create_type_count_map(obs_before) # type: ignore\n after = create_type_count_map(obs_after)\n \n leaks = diff_type_count_maps(before, after)\n","prefixes":["libcamera-devel","v2","06/13"]}