[{"id":23002,"web_url":"https://patchwork.libcamera.org/comment/23002/","msgid":"<165280461103.2416244.1657994981583462478@Monstersaurus>","date":"2022-05-17T16:23:31","subject":"Re: [libcamera-devel] [PATCH v2 04/13] py: unittests: fix selector\n\tfd use","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2022-05-17 15:33:16)\n> pyright complains about passing fileobj to os.read. Indeed, the\n> parameter should be an int, but I guess fileobj gets automatically\n> converted. In any case, using the fd is better.\n> \n> Signed-off-by: Tomi Valkeinen \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> test/py/unittests.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/py/unittests.py b/test/py/unittests.py\n> index cbc00ff3..9326358d 100755\n> --- a/test/py/unittests.py\n> +++ b/test/py/unittests.py\n> @@ -262,8 +262,8 @@ class SimpleCaptureMethods(CameraTesterBase):\n> running = True\n> while running:\n> events = sel.select()\n> - for key, mask in events:\n> - os.read(key.fileobj, 8)\n> + for key, _ in events:\n> + os.read(key.fd, 8)\n> \n> ready_reqs = cm.get_ready_requests()\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F125C0F2A\n\tfor ;\n\tTue, 17 May 2022 16:23:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 06DEA6041E;\n\tTue, 17 May 2022 18:23:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3CAE6041D\n\tfor ;\n\tTue, 17 May 2022 18:23:33 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7329D48F;\n\tTue, 17 May 2022 18:23:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652804615;\n\tbh=cb+g2qs8BKcIYjgGgd423w/y5h6zkvoGDxZ+RxNObQM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=FsTqoTiX9huqemdy0fGRe+odyTOjwQPRrR0KlvLzRKJPtPDzwm/ykV/J6MGnbHSN0\n\tKteAc5AyN75N4w7Js8ZVKrcYGGoZhE+Z5rXW26U9EwJYDXiZbqCjIjMHfBqseACGDn\n\ts+UedyJBOxmR948e8rNHomzJj9bs6TZethD25JYFWsVvPD/3dVUhpSLvo/bcSqLdGe\n\t8tPamdOAaVeb9mLQ9wRaV1KIAz5kWRF3Ysej4ySwmF/FLDzFv+4TyUfRKUZO7LGJkp\n\tkxChycajF319NQnUvhISuo7vedNmoB19D/QD764ss2/V7XmHzVGttG/X77LXzHXp/L\n\tcl8eLg6mkoKJw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652804613;\n\tbh=cb+g2qs8BKcIYjgGgd423w/y5h6zkvoGDxZ+RxNObQM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=QuN/MXLY8d9xfxOZCv2PVg28VD26QrckQ+bKE3ijQeyAto4J8PMwc39MXSjPeMJpV\n\tv75oLDobB9T9QrR9qo2q7VntNVYh5PhCRDAzE+j648dxoTJevbFfZK+UOPyODtLYn9\n\tnD2vVQAgmGsi/MStlJB5/MevUrwPwdh2X/sTg0SM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"QuN/MXLY\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220517143325.71784-5-tomi.valkeinen@ideasonboard.com>","References":"<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>\n\t<20220517143325.71784-5-tomi.valkeinen@ideasonboard.com>","To":"David Plowman ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ,\n\tTomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 17 May 2022 17:23:31 +0100","Message-ID":"<165280461103.2416244.1657994981583462478@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 04/13] py: unittests: fix selector\n\tfd use","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]