[{"id":22996,"web_url":"https://patchwork.libcamera.org/comment/22996/","msgid":"<165280373729.2416244.3150482506203510836@Monstersaurus>","date":"2022-05-17T16:08:57","subject":"Re: [libcamera-devel] [PATCH v2 01/13] py: meson: fix comment about\n\tstubs","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2022-05-17 15:33:13)\n> At least pyright seems to be able to use the stubs from the\n> libcamera-stubs directory, so no need to copy the generated files.\n> Adjust the comment accordingly.\n> \n> Signed-off-by: Tomi Valkeinen \n> Reviewed-by: Laurent Pinchart \n\nSeems trivial.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/py/libcamera/meson.build | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build\n> index 0cd7c75b..38f619d0 100644\n> --- a/src/py/libcamera/meson.build\n> +++ b/src/py/libcamera/meson.build\n> @@ -63,4 +63,3 @@ install_data(['__init__.py'], install_dir : destdir)\n> # \\todo Generate stubs when building. See https://peps.python.org/pep-0484/#stub-files\n> # Note: Depends on pybind11-stubgen. To generate pylibcamera stubs:\n> # $ PYTHONPATH=build/src/py pybind11-stubgen --no-setup-py -o build/src/py libcamera\n> -# $ mv build/src/py/libcamera-stubs/* build/src/py/libcamera/\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A8D5C3256\n\tfor ;\n\tTue, 17 May 2022 16:09:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4676A65659;\n\tTue, 17 May 2022 18:09:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 640FC6041E\n\tfor ;\n\tTue, 17 May 2022 18:09:00 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22A9E484;\n\tTue, 17 May 2022 18:09:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652803741;\n\tbh=/iEUAkyjVNz3Z6mJ524ProUP7RAgpKSK3rFXZi2Tchk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=KPoRg9TumYObxjnkj4KHKxq090VsBqupPyCt7Bg4NJ01gH7F5QfF2mKnVVGficy5M\n\tXkDlrqhd0nhNaoB26DtNC72Kk306QQfMT3ldic2I3bvzBbQopJlTQNdvwURcSZ1pk5\n\t3AJisamzHaoeJCI8CY9X22JL5qzhhYL8avs3F7stUH3wqk06mEizZ25tVl8iYEOELc\n\tYOluvd3iAFc6qi33asxSooPXxHtVoht8lhHU2+IpdCJu6m72yw+MAyyzYlFnfn4G9V\n\tilbRDqSK7KQbXwjeID2VrhF2G7Yg9RljSCGUc7EpdjfhgPJLHRaS3eRLJjlPH1+Vhy\n\tsZr8PP5bFEc6g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652803740;\n\tbh=/iEUAkyjVNz3Z6mJ524ProUP7RAgpKSK3rFXZi2Tchk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Tn8O8TSxH28q+AFOr6+99WrX4aCowUakVxQo1wiOOlvUjwyRwiOibefKDRfP2hz2Y\n\tUF4JoPK+IykXB60SI9G+mzyrr52m8zAggY6Idr3NanraI+LLgoWF/LMJyy7pY+1Ghc\n\twEmpUjULi8J62d+S6l9NjsPyHRKcSO2x27OjWOrM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Tn8O8TSx\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220517143325.71784-2-tomi.valkeinen@ideasonboard.com>","References":"<20220517143325.71784-1-tomi.valkeinen@ideasonboard.com>\n\t<20220517143325.71784-2-tomi.valkeinen@ideasonboard.com>","To":"David Plowman ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ,\n\tTomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 17 May 2022 17:08:57 +0100","Message-ID":"<165280373729.2416244.3150482506203510836@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 01/13] py: meson: fix comment about\n\tstubs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]