[{"id":22978,"web_url":"https://patchwork.libcamera.org/comment/22978/","msgid":"","date":"2022-05-17T08:42:27","subject":"Re: [libcamera-devel] [PATCH 14/14] py: cam_kms: fix multistream\n\tdisplay","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Mon, May 16, 2022 at 05:10:22PM +0300, Tomi Valkeinen wrote:\n> Instead of doing an atomic commit for each stream, do a single commit\n> for the two planes. This fixes the issue that only the first plane was\n> actually shown.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/cam/cam_kms.py | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\n> index 90aac5f6..74cd3b38 100644\n> --- a/src/py/cam/cam_kms.py\n> +++ b/src/py/cam/cam_kms.py\n> @@ -67,12 +67,13 @@ class KMSRenderer:\n> \n> buffers = drmreq['camreq'].buffers\n> \n> + req = pykms.AtomicReq(self.card)\n> +\n> for stream, fb in buffers.items():\n> drmfb = self.cam_2_drm.get(fb, None)\n> -\n> - req = pykms.AtomicReq(self.card)\n> self.add_plane(req, stream, drmfb)\n> - req.commit()\n> +\n> + req.commit()\n> \n> def handle_page_flip(self, frame, time):\n> old = self.current","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2E18C0F2A\n\tfor ;\n\tTue, 17 May 2022 08:42:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E64C6565A;\n\tTue, 17 May 2022 10:42:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B579660420\n\tfor ;\n\tTue, 17 May 2022 10:42:34 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 482EC48F;\n\tTue, 17 May 2022 10:42:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652776956;\n\tbh=7p5kZvQwk0zNXAo+3zFkqUORjadfz5XYwDlsgHjp+dE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=28oP+0uGWhCiFWdmQDfPYAsuLOjWNg2tujI86XxacfWyj+v+Cu5DY/8B2GQufzUm6\n\tAawpWwvNdFcAqZkdDi8wu/KJkFwRoEE03vXNEaE6i1oV3/XAnDGDolZm0tUVpdIU6x\n\tuHL9C+GSqPePWEBTqDqMjGKD9Una9dfNjKLm6D1uCaHCBvkE8Iiwt+eTp1iuawCVvF\n\tiLTxyIL/cjXWLyzFIzd1X5XxJwjAwP7O6l5RGlG+qhRAAaMXeRBkLfFH/4WIY8bvbf\n\tb93d5VON61vVmSq32EM6vFl7KIaZy8AodSekcqynaQ2Ddld/4aWltkiT0tJ0AFBAlm\n\tZrLzDQvwUk3IA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652776954;\n\tbh=7p5kZvQwk0zNXAo+3zFkqUORjadfz5XYwDlsgHjp+dE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jTWiqU30/AlFaiFdyGOf5Th0E/n251Xy0iikB7ZkGKPdqqedTiJlMfHF87o2Wcu+W\n\tnTunt9gEoTBGyEedxha8/EOjH4bqxzCdwBAT7/mBF63hevgdDkmCIxbol8V7Eyv8FQ\n\tIduZ7ZSrA0OXyC0acFvpdUUb+bGpaGFP7+NajYmU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jTWiqU30\"; dkim-atps=neutral","Date":"Tue, 17 May 2022 11:42:27 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>\n\t<20220516141022.96327-15-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220516141022.96327-15-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 14/14] py: cam_kms: fix multistream\n\tdisplay","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]