{"id":15920,"url":"https://patchwork.libcamera.org/api/patches/15920/?format=json","web_url":"https://patchwork.libcamera.org/patch/15920/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220516141022.96327-15-tomi.valkeinen@ideasonboard.com>","date":"2022-05-16T14:10:22","name":"[libcamera-devel,14/14] py: cam_kms: fix multistream display","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"98a1bf7e6d0add2070599d24b24c37cbbd69bb74","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15920/mbox/","series":[{"id":3113,"url":"https://patchwork.libcamera.org/api/series/3113/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3113","date":"2022-05-16T14:10:08","name":"Misc Python bindings patches","version":1,"mbox":"https://patchwork.libcamera.org/series/3113/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15920/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15920/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D3C6C3271\n\tfor ;\n\tMon, 16 May 2022 14:11:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C4A5A65680;\n\tMon, 16 May 2022 16:11:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 284D765653\n\tfor ;\n\tMon, 16 May 2022 16:10:55 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8E8F98EF;\n\tMon, 16 May 2022 16:10:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652710264;\n\tbh=MRxE+WJDv6nB+zC5V/SxfwJvigsEeyodx4QT1Xo+d+s=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=MTeiA0+iKipv9Wm5jcuqBADuFBjirTEfftZDt+0NBrWFhDy3iye7nrEWRqUsPuWQF\n\tUx0zRy6Fxh+4Hfpidle3BoZ5hkBUK3q2CteHgt5EvJxXP+FM/cm55YG7/oB3FhmbMi\n\tTxNdUKzaoXlu8pdw05wbe+tyngu69lhlzBzvvhj5gMpBztDTCdYkNKIwXUYkB4VjQS\n\tfsu+pPvpx6N2NopFNr8ZcLL//40rHxIVX4QTimBkeEEBLi+o1oAMetzT/EJTL8GBOE\n\trKcun8P3sg1KKJeg/4381f46UEX02kSg1ETWfFfmUUnkvjb39yMt43CtB27hzMP0xs\n\tW8mdvrett2Upg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652710254;\n\tbh=MRxE+WJDv6nB+zC5V/SxfwJvigsEeyodx4QT1Xo+d+s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Qpx2U2LiyJ2PlL9K9GCHqE7vZKja8dpr3fQxfB3F4epDjSz/57XZTpTtnufDKMxbB\n\t3ONDOjmQoZ+XM7OrSFQPNXa5zRQpm8AFCmAUvdanvp46KfLgLGVpOyTZpWvcjMrJkw\n\tA+JChmClr04DSl4+ni/iGcCp9FQyScn9X5m4jXHs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Qpx2U2Li\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Mon, 16 May 2022 17:10:22 +0300","Message-Id":"<20220516141022.96327-15-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 14/14] py: cam_kms: fix multistream display","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of doing an atomic commit for each stream, do a single commit\nfor the two planes. This fixes the issue that only the first plane was\nactually shown.\n\nSigned-off-by: Tomi Valkeinen \n---\n src/py/cam/cam_kms.py | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\nindex 90aac5f6..74cd3b38 100644\n--- a/src/py/cam/cam_kms.py\n+++ b/src/py/cam/cam_kms.py\n@@ -67,12 +67,13 @@ class KMSRenderer:\n \n buffers = drmreq['camreq'].buffers\n \n+ req = pykms.AtomicReq(self.card)\n+\n for stream, fb in buffers.items():\n drmfb = self.cam_2_drm.get(fb, None)\n-\n- req = pykms.AtomicReq(self.card)\n self.add_plane(req, stream, drmfb)\n- req.commit()\n+\n+ req.commit()\n \n def handle_page_flip(self, frame, time):\n old = self.current\n","prefixes":["libcamera-devel","14/14"]}