[{"id":22977,"web_url":"https://patchwork.libcamera.org/comment/22977/","msgid":"","date":"2022-05-17T08:41:37","subject":"Re: [libcamera-devel] [PATCH 13/14] py: cam_kms: support\n\tmultiplanar formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Mon, May 16, 2022 at 05:10:21PM +0300, Tomi Valkeinen wrote:\n> Support multiplanar formats in the kms renderer. Tested with RPi and\n> NV12.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/cam/cam_kms.py | 12 +++++++++---\n> 1 file changed, 9 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/py/cam/cam_kms.py b/src/py/cam/cam_kms.py\n> index da3dd4e0..90aac5f6 100644\n> --- a/src/py/cam/cam_kms.py\n> +++ b/src/py/cam/cam_kms.py\n> @@ -127,10 +127,16 @@ class KMSRenderer:\n> for fb in ctx['allocator'].buffers(stream):\n> w = cfg.size.width\n> h = cfg.size.height\n> - stride = cfg.stride\n> - fd = fb.fd(0)\n> + fds = []\n> + strides = []\n> + offsets = []\n> + for i in range(fb.num_planes):\n> + fds.append(fb.fd(i))\n> + strides.append(cfg.stride)\n> + offsets.append(fb.offset(i))\n> +\n> drmfb = pykms.DmabufFramebuffer(self.card, w, h, fmt,\n> - [fd], [stride], [0])\n> + fds, strides, offsets)\n> self.cam_2_drm[fb] = drmfb\n> \n> idx += 1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DFA8C0F2A\n\tfor ;\n\tTue, 17 May 2022 08:41:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 072B56565A;\n\tTue, 17 May 2022 10:41:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4EB560420\n\tfor ;\n\tTue, 17 May 2022 10:41:43 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EDE148F;\n\tTue, 17 May 2022 10:41:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652776905;\n\tbh=CGesZlbCkIsg3ZvXlFvegbogTUrAYCho4NIeDmf7dXc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vdh63PcuvnL+HypzNuIqxxzAMfFYXqFnJsj1we5uoRqMUf+Hm4phsN5vtAMSIkDDb\n\tj+AXVUPgf095wEeIiD2EmB2FPlAD1LGNh2MaCrKp8c0doiKGcFORciaFVfgoYeyP8k\n\t5PNlvJYWMtDiNfbzBDrSt1oZKDPi8spl+V3bAR9IxJLf8HYRAOCdL6OjDVz14z/IbK\n\tdKUoTAPoayYp1S9KvVmUHzihrPjaRhV6wZYXDUkjI84LAhwj+7JUWka2rqzWLgIsrG\n\tNjx0xYUT6x/6FRgLvO5/xz3kWkn2b+vvdZjL2PlILM6rqa0vQoHwPDfFK1FdK0DHul\n\tYmZDI3KluhT2A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652776903;\n\tbh=CGesZlbCkIsg3ZvXlFvegbogTUrAYCho4NIeDmf7dXc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pKn8qWIKEEBqEYP4QYiN659bY0LK3nLDSrv2cL51WyCbATO2h3i1TIRb1lF7zZFEP\n\tetooE5O00Xe6Tk3ZjLJzSRMYGwzRKaaeYf45Z4xqDYyy57O+AuaGms8NqVWRlJT5/y\n\tjKDjUVQOdSD8oINW4c9pudHLsydqutMj4cvcI8tw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pKn8qWIK\"; dkim-atps=neutral","Date":"Tue, 17 May 2022 11:41:37 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>\n\t<20220516141022.96327-14-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220516141022.96327-14-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 13/14] py: cam_kms: support\n\tmultiplanar formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]