[{"id":22968,"web_url":"https://patchwork.libcamera.org/comment/22968/","msgid":"","date":"2022-05-17T08:21:13","subject":"Re: [libcamera-devel] [PATCH 07/14] py: cam.py: exit on exception","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Mon, May 16, 2022 at 05:10:15PM +0300, Tomi Valkeinen wrote:\n> Catch exceptions in the event_handler, as they would get ignored\n> otherwise. Print the exception and return False so that the main loop\n> exits.\n> \n> Signed-off-by: Tomi Valkeinen \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/py/cam/cam.py | 23 ++++++++++++++---------\n> 1 file changed, 14 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\n> index 012b191c..c7da97d7 100755\n> --- a/src/py/cam/cam.py\n> +++ b/src/py/cam/cam.py\n> @@ -11,6 +11,7 @@ import binascii\n> import libcamera as libcam\n> import os\n> import sys\n> +import traceback\n> \n> \n> class CustomAction(argparse.Action):\n> @@ -286,19 +287,23 @@ def capture_start(contexts):\n> \n> # Called from renderer when there is a libcamera event\n> def event_handler(state):\n> - cm = state['cm']\n> - contexts = state['contexts']\n> + try:\n> + cm = state['cm']\n> + contexts = state['contexts']\n> \n> - os.read(cm.efd, 8)\n> + os.read(cm.efd, 8)\n> \n> - reqs = cm.get_ready_requests()\n> + reqs = cm.get_ready_requests()\n> \n> - for req in reqs:\n> - ctx = next(ctx for ctx in contexts if ctx['idx'] == req.cookie)\n> - request_handler(state, ctx, req)\n> + for req in reqs:\n> + ctx = next(ctx for ctx in contexts if ctx['idx'] == req.cookie)\n> + request_handler(state, ctx, req)\n> \n> - running = any(ctx['reqs-completed'] < ctx['opt-capture'] for ctx in contexts)\n> - return running\n> + running = any(ctx['reqs-completed'] < ctx['opt-capture'] for ctx in contexts)\n> + return running\n> + except Exception as e:\n> + traceback.print_exc()\n> + return False\n> \n> \n> def request_handler(state, ctx, req):","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7376AC0F2A\n\tfor ;\n\tTue, 17 May 2022 08:21:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FF906565A;\n\tTue, 17 May 2022 10:21:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20A6760420\n\tfor ;\n\tTue, 17 May 2022 10:21:20 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A90C948F;\n\tTue, 17 May 2022 10:21:19 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652775681;\n\tbh=n1VmcAEfBF7CuDgl2TJ+sIdOcm7iq00Xe2IIbAPz/Rk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0JzmtM837dzggxTbSQwQ5QFaLAHaGirTOV6zHSt3dL4etNItAsm/Jxglwb13MZ7s0\n\tPKNduexLqcr825fFD92GNy/GROyvoZ7auDCOfx87W0ERikiYRiZxhiTQwvrpq3uB2S\n\tqspp9TzV2NwrvyB1hHIq7q8XbpZzhzIz+FkarISFKd7LCogroDFcdhXQ0gSigFI+IN\n\t0GK5ER2IBLEiTkJj43cQMHRm+qYiR4ORItHNTiCNZuBzYPfyypW9TImigS8dTgrmnD\n\th36ZvyIs4CS6J9beOmWCnt9VV13tKq8EKJX8Dg18w1xmZ1rZrO83ytR0mcm4Njf1hZ\n\t+ZQyeoR92UnMA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652775679;\n\tbh=n1VmcAEfBF7CuDgl2TJ+sIdOcm7iq00Xe2IIbAPz/Rk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Tnkxgqedb59yonsFgxm65gPXadHX6kjT9ZPdFzAMTh0RAdSZzzi2dTbU+raRy04s9\n\t9yVpPqzkib3bGS6Ph7Fy3XenXsXb+iYgZ0jIP3IBJW9nf0naGST5MSWZRNoOY4aFZa\n\tENr5PElK0W6cnuZT11XeN9fNaZ9RGMmuRV0KMXt4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Tnkxgqed\"; dkim-atps=neutral","Date":"Tue, 17 May 2022 11:21:13 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>\n\t<20220516141022.96327-8-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220516141022.96327-8-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 07/14] py: cam.py: exit on exception","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]