{"id":15913,"url":"https://patchwork.libcamera.org/api/patches/15913/?format=json","web_url":"https://patchwork.libcamera.org/patch/15913/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220516141022.96327-8-tomi.valkeinen@ideasonboard.com>","date":"2022-05-16T14:10:15","name":"[libcamera-devel,07/14] py: cam.py: exit on exception","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8db3cbce0707dc8a53e3554098b13442ca4fae88","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15913/mbox/","series":[{"id":3113,"url":"https://patchwork.libcamera.org/api/series/3113/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3113","date":"2022-05-16T14:10:08","name":"Misc Python bindings patches","version":1,"mbox":"https://patchwork.libcamera.org/series/3113/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15913/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15913/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A445EC326E\n\tfor ;\n\tMon, 16 May 2022 14:10:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D243065672;\n\tMon, 16 May 2022 16:10:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 731496565C\n\tfor ;\n\tMon, 16 May 2022 16:10:51 +0200 (CEST)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBF2A484;\n\tMon, 16 May 2022 16:10:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652710257;\n\tbh=PnHyInzBKWeLdu4GkQm2Sbu5jWaEQC26GxZMioyOato=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=b4fzGUI8Ya9kKZ8LKCESsQombsWZte2uMlR+ke6hfPr9SWJ51dZHYA+w0GkQU+fZC\n\tK5mWkvkEyIK2WcCaxQjmxWnnEFU5unYZr6eINZH6dHBo1a4BXioQ0Zk9Mcn4fOOGsn\n\tQhQNddM0McMoUSBHwOKcAOkk7WcrJGJU2D/6gLevWV5zp4Zqyr47Rc8bQrgpo1Xixg\n\t50VT7/LsSz4THAmsPqmYSujHAb8T1bo6U1DAv/g65fBpp1ofR2c2C1yVCLgfqQGSjr\n\t9g/P8mGyRiykeh8RD6HCRDUADDGxwNqVKdfyDTPTebTZjPpXIvTMkO7+0zf/en+NRT\n\tqy3JRi540v16Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652710251;\n\tbh=PnHyInzBKWeLdu4GkQm2Sbu5jWaEQC26GxZMioyOato=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XvePJBxT/5Iv/6IskRsJhB722UnJtPTLndUSzATnWVK3e6cT3oemOdjLRs9WYFtPA\n\tAWQpMxUUbH5eiVYdw1u1e89X8fDT0TCTfQCt77lxBBoW/QrBxiD3TET0AgOhvkMvY7\n\tjuNr2o95HYk0CwOgzmu16vGbM0usv5iyL1wCeUQQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XvePJBxT\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tJacopo Mondi ","Date":"Mon, 16 May 2022 17:10:15 +0300","Message-Id":"<20220516141022.96327-8-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 07/14] py: cam.py: exit on exception","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Tomi Valkeinen via libcamera-devel\n\t","Reply-To":"Tomi Valkeinen ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Catch exceptions in the event_handler, as they would get ignored\notherwise. Print the exception and return False so that the main loop\nexits.\n\nSigned-off-by: Tomi Valkeinen \n---\n src/py/cam/cam.py | 23 ++++++++++++++---------\n 1 file changed, 14 insertions(+), 9 deletions(-)","diff":"diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex 012b191c..c7da97d7 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -11,6 +11,7 @@ import binascii\n import libcamera as libcam\n import os\n import sys\n+import traceback\n \n \n class CustomAction(argparse.Action):\n@@ -286,19 +287,23 @@ def capture_start(contexts):\n \n # Called from renderer when there is a libcamera event\n def event_handler(state):\n- cm = state['cm']\n- contexts = state['contexts']\n+ try:\n+ cm = state['cm']\n+ contexts = state['contexts']\n \n- os.read(cm.efd, 8)\n+ os.read(cm.efd, 8)\n \n- reqs = cm.get_ready_requests()\n+ reqs = cm.get_ready_requests()\n \n- for req in reqs:\n- ctx = next(ctx for ctx in contexts if ctx['idx'] == req.cookie)\n- request_handler(state, ctx, req)\n+ for req in reqs:\n+ ctx = next(ctx for ctx in contexts if ctx['idx'] == req.cookie)\n+ request_handler(state, ctx, req)\n \n- running = any(ctx['reqs-completed'] < ctx['opt-capture'] for ctx in contexts)\n- return running\n+ running = any(ctx['reqs-completed'] < ctx['opt-capture'] for ctx in contexts)\n+ return running\n+ except Exception as e:\n+ traceback.print_exc()\n+ return False\n \n \n def request_handler(state, ctx, req):\n","prefixes":["libcamera-devel","07/14"]}