[{"id":22965,"web_url":"https://patchwork.libcamera.org/comment/22965/","msgid":"","date":"2022-05-17T08:18:08","subject":"Re: [libcamera-devel] [PATCH 05/14] py: unittests: verify that cam\n\tand cm are freed","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Mon, May 16, 2022 at 05:10:13PM +0300, Tomi Valkeinen wrote:\n> Add checks to CameraTesterBase to verify that both the Camera and the\n> CameraManager gets freed.\n> \n> Signed-off-by: Tomi Valkeinen \n> ---\n> test/py/unittests.py | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/test/py/unittests.py b/test/py/unittests.py\n> index 9326358d..288dcd48 100755\n> --- a/test/py/unittests.py\n> +++ b/test/py/unittests.py\n> @@ -83,6 +83,10 @@ class CameraTesterBase(BaseTestCase):\n> self.cm = None\n> raise Exception('Failed to acquire camera')\n> \n> + self.wr_cam = weakref.ref(self.cam)\n> + self.wr_cm = weakref.ref(self.cm)\n> +\n> +\n\nExtra blank line ? Apart from that,\n\nReviewed-by: Laurent Pinchart \n\n> def tearDown(self):\n> # If a test fails, the camera may be in running state. So always stop.\n> self.cam.stop()\n> @@ -94,6 +98,9 @@ class CameraTesterBase(BaseTestCase):\n> self.cam = None\n> self.cm = None\n> \n> + self.assertIsNone(self.wr_cm())\n> + self.assertIsNone(self.wr_cam())\n> +\n> \n> class AllocatorTestMethods(CameraTesterBase):\n> def test_allocator(self):","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55CCDC3256\n\tfor ;\n\tTue, 17 May 2022 08:18:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1689B6565C;\n\tTue, 17 May 2022 10:18:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4657C60420\n\tfor ;\n\tTue, 17 May 2022 10:18:15 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB1D94A8;\n\tTue, 17 May 2022 10:18:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652775496;\n\tbh=d1DMjdZUvMGqSP0tKOa/HzNAzS4a4dr2khyfdA5tdxs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PT5ewOn+Wmuud3K75408PwmmpBOq5XDHVqqGBkm2qbspJFCSArCcnJ2ytADYbwJYy\n\tJ4ifAcfqm15fp/kmIpygFsP9ptChhYRFK5ncQjERlSqU79WrpCj56A5aQlzXXbdDwA\n\t8tpKp//UID8F7nXFPQhqHaInijpEmoT0TS21yt8ZWhUrooWISFuwq5TBRpiAtoWyWC\n\t5L9V/6cILbGhFGt/MiPl2lTQpst8l5YfOuwnSTUxY1U0hjDlmUMtSEzdbtGySab4E+\n\tWwQzLkidBhfmF7DugSvhWYnMxJEMHLertt3fNUkzuEx4EI51Qjgy5GSPYMvDcnIiJB\n\tGDFuPTJWUUtxw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652775495;\n\tbh=d1DMjdZUvMGqSP0tKOa/HzNAzS4a4dr2khyfdA5tdxs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YUvE1+g9E2csM8P8nCEy9oei8nob6ppjF9is4eNxxK2xLamMZhh2f+vQcw+d2ZGy1\n\tt7GH4SjbGHiDrpPxViPbD2sFg5CVAno+O3PxQw0q+JO7CV03/ICrpyZ9YhDjTyLrny\n\tO8eDWfvM1ZqSOEq8o52nkXMUWwOMSQhxIGbI7FhE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YUvE1+g9\"; dkim-atps=neutral","Date":"Tue, 17 May 2022 11:18:08 +0300","To":"Tomi Valkeinen ","Message-ID":"","References":"<20220516141022.96327-1-tomi.valkeinen@ideasonboard.com>\n\t<20220516141022.96327-6-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220516141022.96327-6-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/14] py: unittests: verify that cam\n\tand cm are freed","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]